Activity dgfirmware/

Tree
Accordion

Stats

Commits this week: 9

Total Committers:	17
Last Commit:	19:46
Commits this week:	9

Lines of code count not available

Commit Activity

last updated a few seconds ago

Constraints

Constraints: committers

Committer:

Log Comment:

Constraints: files

File Extension:

File Name:

Constraints: dates

Start Date:

Start Date:

End Date:

End Date:

Wednesday 14 Jun 2023

9:39 am

Dara Navaei

More
8993fd4
changed 0 files
master, DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error and 108 more

Merged DEN-15367

9:12 am

Sean Nash

More
DG-DEN-15367-1
finished reviewing

9:09 am

Dara Navaei

More
80b41ef
changed 1 file
master, DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error and 109 more DG-DEN-15367-1

Merge branch 'staging' into DEN-15367-hd_dg_test_configuration_setup

- -7
- +21
/firmware/App/Controllers/DrainPump.c
- History
- Source
- Diff
/firmware/App/Controllers/DrainPump.c

9:05 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Tuesday 13 Jun 2023

5:05 pm

Dara Navaei

More
2891252
changed 1 file
develop

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

- -1
- +1
/firmware/App/DGCommon.h
- History
- Source
- Diff
/firmware/App/DGCommon.h

5:05 pm

Dara Navaei

More
cfa8289
changed 0 files
develop

Merge branch 'DEN-15367-hd_dg_test_configuration_setup' into develop

5:04 pm

Dara Navaei

More
1a4ffea
changed 1 file
master, DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error and 109 more DG-DEN-15367-1

DEN-14657 removed code to not check the error bit of a temperature sensor and let the temperature out of range alarm trigger the alarm

- -52
- +3
/firmware/App/Controllers/TemperatureSensors.c
- History
- Source
- Diff
/firmware/App/.../TemperatureSensors.c

3:31 pm

Dara Navaei

More
Re: DG-DEN-15367-1
replied to Sean Nash

Done

Done

1:56 pm

Dara Navaei

More
c430223
changed 1 file
develop

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

- -1
- +1
/firmware/App/DGCommon.h
- History
- Source
- Diff
/firmware/App/DGCommon.h

1:56 pm

Dara Navaei

More
6625048
changed 0 files
develop

Merge branch 'DEN-15367-hd_dg_test_configuration_setup' into develop

1:56 pm

Dara Navaei

More
2024427
changed 1 file
master, DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error and 109 more DG-DEN-15367-1

DEN-15571 changed the chemical disinfect temperature timeout from 1 minute to 5 minutes

- -1
- +1
/firmware/App/Modes/ModeChemicalDisinfect.c
- History
- Source
- Diff
/firmware/App/.../ModeChemicalDisinfect.c

1:35 pm

Dara Navaei

More
0b02dd5
changed 1 file
develop

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

- -1
- +1
/firmware/App/DGCommon.h
- History
- Source
- Diff
/firmware/App/DGCommon.h

1:34 pm

Dara Navaei

More
150ea9e
changed 5 files
develop

Merge branch 'DEN-15367-hd_dg_test_configuration_setup' into develop

- -3
- +3
/firmware/App/Controllers/ConcentratePumps.c
- History
- Source
- Diff
/firmware/App/.../ConcentratePumps.c
- -4
- +4
/firmware/App/Controllers/DrainPump.c
- History
- Source
- Diff
/firmware/App/Controllers/DrainPump.c
- -7
- +11
/firmware/App/Modes/ModeFill.c
- History
- Source
- Diff
/firmware/App/Modes/ModeFill.c
- -7
- +4
/firmware/App/Services/SystemCommMessages.c
- History
- Source
- Diff
/firmware/App/.../SystemCommMessages.c
- -1
- +1
/firmware/App/Services/SystemCommMessages.h
- History
- Source
- Diff
/firmware/App/.../SystemCommMessages.h

1:33 pm

Dara Navaei

More
5e47cac
changed 2 files
master, DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error and 109 more DG-DEN-15367-1

DEN-15367 removed the payload from the message that informs HD that DG is ready to dispense more fluid in DG. DEN-15571 fixed the chemical disinfect state machine to transition to cancel water path once the target temperature was not reached within the specified time

- -6
- +11
/firmware/App/Modes/ModeChemicalDisinfect.c
- History
- Source
- Diff
/firmware/App/.../ModeChemicalDisinfect.c
- -5
- +2
/firmware/App/Services/SystemCommMessages.c
- History
- Source
- Diff
/firmware/App/.../SystemCommMessages.c

12:50 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

12:50 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

12:48 pm

Sean Nash

Still has a payload. Should remove it.

Still has a payload. Should remove it.

12:47 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

12:46 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

12:46 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

12:42 pm

Dara Navaei

More
fc05ef5
changed 1 file
master, DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error and 109 more DG-DEN-15367-1

DEN-15367 addressed a code review comment

- -1
- +1
/firmware/App/Controllers/ConcentratePumps.c
- History
- Source
- Diff
/firmware/App/.../ConcentratePumps.c

12:42 pm

Dara Navaei

More
Re: DG-DEN-15367-1
replied to Sean Nash

Removed the check to make sure the target speed is > 0. The current speed is always >= 0.0 mL/min.

Removed the check to make sure the target speed is > 0. The current speed is always >= 0.0 mL/min.

11:39 am

wbracken (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

11:38 am

wbracken (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

11:38 am

wbracken (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

11:37 am

wbracken (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

10:37 am

Dara Navaei

More
fab0257
changed 8 files
master, DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error and 109 more DG-DEN-15367-1

DEN-15367 addressed the code review comments

- -2
- +2
/firmware/App/Controllers/ConcentratePumps.c
- History
- Source
- Diff
/firmware/App/.../ConcentratePumps.c
- -4
- +4
/firmware/App/Controllers/DrainPump.c
- History
- Source
- Diff
/firmware/App/Controllers/DrainPump.c
- -3
- +3
/firmware/App/Controllers/ROPump.c
- History
- Source
- Diff
/firmware/App/Controllers/ROPump.c
- -7
- +11
/firmware/App/Modes/ModeFill.c
- History
- Source
- Diff
/firmware/App/Modes/ModeFill.c
- -3
- +14
/firmware/App/Modes/ModeROPermeateSample.c
- History
- Source
- Diff
/firmware/App/.../ModeROPermeateSample.c
- -1
- +1
/firmware/App/Modes/ModeStandby.c
- History
- Source
- Diff
/firmware/App/Modes/ModeStandby.c
- -3
- +3
/firmware/App/Services/SystemCommMessages.c
- History
- Source
- Diff
/firmware/App/.../SystemCommMessages.c
- -1
- +1
/firmware/App/Services/SystemCommMessages.h
- History
- Source
- Diff
/firmware/App/.../SystemCommMessages.h

10:27 am

Dara Navaei

More
Re: DG-DEN-15367-1
replied to Sean Nash

Done

Done

9:38 am

Sean Nash

More
Re: DG-DEN-15367-1
commented on review

Remove "handle" from this function name. It should start with "send". And why does this message have a payload. Message itself infers ready.

Remove "handle" from this function name. It should start with "send". And why does this message have a payload. Message itself infers ready.

9:37 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Atlassian Fisheye Git analysis with Crucible code review. (Version:4.8.14 Build:20240111091859 2024-01-11 09:20) - Administration - Page generated 2026-06-10 22:53 -0700