dgfirmware

Clone Tools

Stats

Commits this week: 0
Total Committers: 17
Last Commit: 10 Jun
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 21 Jun 2023
11:13 am

Bill Bracken <bill@criticalsoftwaresolutions.com>

DEN-15683 Updates per code review comments

Options
    • -9
    • +5
    /firmware/App/Controllers/ConcentratePumps.c
    • -2
    • +2
    /firmware/App/Controllers/ConcentratePumps.h
11:10 am

wbracken  (deleted user)

Removed

Removed

11:09 am

wbracken  (deleted user)

Done.

Done.

11:07 am

wbracken  (deleted user)

Done

Done

10:48 am

wbracken  (deleted user)

Add hasFlushStatusBeenWrittenToNV to header

Add hasFlushStatusBeenWrittenToNV to header

10:48 am

wbracken  (deleted user)

Add hasFlushStatusBeenWrittenToNV to header

Add hasFlushStatusBeenWrittenToNV to header

9:59 am

Sean Nash

Declarations should be at top of scope.

Declarations should be at top of scope.

9:57 am

Sean Nash

Add comment that other cases are ignored because loop makes them impossible.

Add comment that other cases are ignored because loop makes them impossible.

9:56 am

Sean Nash

Why have {} in cases?

Why have {} in cases?

9:55 am

Sean Nash

Comments are swapped.

Comments are swapped.

Tuesday 20 Jun 2023
6:04 pm

Bill Bracken <bill@criticalsoftwaresolutions.com>

DEN-15683 Correct proper alarming of concentrate pumps

Options
    • -20
    • +56
    /firmware/App/Controllers/ConcentratePumps.c
    • -1
    • +3
    /firmware/App/Controllers/ConcentratePumps.h
5:31 pm

Dara Navaei

DEN-15610 fixed DG flush to write basic flush complete timestamp in the usage record

Options
    • -3
    • +8
    /firmware/App/Modes/ModeFlush.c
4:02 pm

Dara Navaei

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    /firmware/App/DGCommon.h
4:02 pm

Dara Navaei

Merged DEN-15647

Options
    • -3
    • +4
    /firmware/App/Controllers/ConcentratePumps.c
    • -2
    • +2
    /firmware/App/Modes/ModeFill.c
4:02 pm

Dara Navaei

DG-DEN-15647_Active Cool Cancel Water Path High Temp UV Reactor ON With NO Flow Alarm Triggers
DG-DEN-15647_Active Cool Cancel Water Path High Temp UV Reactor ON With NO Flow Alarm Triggers
4:00 pm

Dara Navaei

DEN-15647 updated the heat disinfect active cool mode to deenergize the actuators prior to transitioning to cancel water path state

Options
    • -1
    • +8
    /firmware/App/Modes/ModeHeatDisinfectActiveCool.c
2:02 pm

Dara Navaei

DG-DEN-15683_FW Alarm Handling OF Concentrate Pumps IS Incorrect
DG-DEN-15683_FW Alarm Handling OF Concentrate Pumps IS Incorrect
Friday 16 Jun 2023
1:15 pm

jtaylor  (deleted user)

1:15 pm

jtaylor  (deleted user)

12:01 pm

Dara Navaei

DG-DEN-15660_Test Configuration Treatment Recovery
DG-DEN-15660_Test Configuration Treatment Recovery
Thursday 15 Jun 2023
5:09 pm

Dara Navaei

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    /firmware/App/DGCommon.h
5:09 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -1
    • +1
    /firmware/App/Controllers/ConcentratePumps.c
    • -1
    • +1
    /firmware/App/Modes/ModeChemicalDisinfect.c
    • -1
    • +1
    /firmware/App/Modes/ModeFill.c
5:08 pm

Dara Navaei

Merged DEN-15571

Options
5:07 pm

Dara Navaei

5:06 pm

wbracken  (deleted user) and Sean Nash

5:06 pm

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

4:29 pm

Dara Navaei

DEN-15571 updated the code

Options
    • -2
    • +3
    /firmware/App/Controllers/ConcentratePumps.c
4:24 pm

Dara Navaei

DEN-15571, DEN-15398 changed the fill mode full speed prime time from 8 seconds to 7 seconds

Options
    • -1
    • +1
    /firmware/App/Modes/ModeFill.c
4:22 pm

Dara Navaei

DEN-15571 addressed the code review comments

Options
    • -14
    • +11
    /firmware/App/Modes/ModeChemicalDisinfect.c
2:05 pm

Dara Navaei

Done

Done