dgfirmware

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
What about acid?

What about acid?

This looks strange. If we have a empty bottle alarm, shouldn't we just not start a fill in the first place? With this approach, you're just stuck in fill start state until user clears the alarm.

This looks strange. If we have a empty bottle alarm, shouldn't we just not start a fill in the first place?
With this approach, you're just stuck in fill start state until user clears the alarm.

Can we move these declarations up to top of scope?

Can we move these declarations up to top of scope?

Replace "TIMEOUT" with "TIME"

Replace "TIMEOUT" with "TIME"

Is this really a timeout? Or is it a minimum duration?

Is this really a timeout? Or is it a minimum duration?

Do we still want un-averaged TDi and TRo in this broadcast? Is anybody using them? If not, why not replace the old temps with the new averages?

Do we still want un-averaged TDi and TRo in this broadcast? Is anybody using them? If not, why not replace the old temps with the new averages?

Swap first and TRo positions in enum. TRo should be first, then we add a first to mark it as first.

Swap first and TRo positions in enum. TRo should be first, then we add a first to mark it as first.

Don't like "timeout" in this constant. It's not really a timeout. It's a sample time (or collection time if you prefer). Change TIMEOUT to TIME.

Don't like "timeout" in this constant. It's not really a timeout. It's a sample time (or collection time if you prefer). Change TIMEOUT to TIME.

Check alarm Ids 191, 192 in Heat Disinfect Active Cool

Check alarm Ids 191, 192 in Heat Disinfect Active Cool

DG-DEN-15802_NO DG Flow Rate Out OF Range Alarms 191 192 For Heat Disinfect Active Cool
DG-DEN-15802_NO DG Flow Rate Out OF Range Alarms 191 192 For Heat Disinfect Active Cool
Ready - DG-DEN-15691_Heat Disinfect Reservoir Leak Alarm Triggers After 5S When Srsdg 512 And 521 Say IT
Ready - DG-DEN-15691_Heat Disinfect Reservoir Leak Alarm Triggers After 5S When Srsdg 512 And 521 Say IT
Add nelsonSupport

Add nelsonSupport

Update header.

Update header.

Update header: rsrvr2Status, isRsrveLeadking, chemDisinfectReservoirTime, isChemDisinfectTempAboveTarget, ischemDisinfectWarmupTargetReached (should be isChemDisinfectWarmupTargetReached).

Update header: rsrvr2Status, isRsrveLeadking, chemDisinfectReservoirTime, isChemDisinfectTempAboveTarget, ischemDisinfectWarmupTargetReached (should be isChemDisinfectWarmupTargetReached).

Add stateTrialCounter

Add stateTrialCounter

Add nelsonSupport, stateTrialCounter to header.

Add nelsonSupport, stateTrialCounter to header.

DG-DEN-15701_Cannot Create Treatment After End Treatment During Pre Treatement
DG-DEN-15701_Cannot Create Treatment After End Treatment During Pre Treatement
RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.