Activity dgfirmware/

Tree
Accordion

Stats

Commits this week: 9

Total Committers:	17
Last Commit:	10 Jun
Commits this week:	9

Lines of code count not available

Commit Activity

last updated a few minutes ago

Constraints

Constraints: committers

Committer:

Log Comment:

Constraints: files

File Extension:

File Name:

Constraints: dates

Start Date:

Start Date:

End Date:

End Date:

Wednesday 12 Jul 2023

11:00 am

Dara Navaei

More
5857de3
changed 2 files
master, DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error and 100 more DG-DEN-15660-1

DEN-15660 addressed the code review comments

- -1
- +1
/firmware/App/Controllers/TemperatureSensors.c
- History
- Source
- Diff
/firmware/App/.../TemperatureSensors.c
- -4
- +7
/firmware/App/Modes/ModeGenIdle.c
- History
- Source
- Diff
/firmware/App/Modes/ModeGenIdle.c

10:53 am

Sean Nash

More
Re: DG-DEN-15660-1
replied to Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:53 am

Michael Garthwaite and jtaylor (deleted user)

More
DG-DEN-15802-1
finished reviewing

10:53 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:52 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:51 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:51 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:50 am

Sean Nash

TRo needs comment for doxygen.

TRo needs comment for doxygen.

10:49 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:48 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:47 am

Dara Navaei

More
965a35a
changed 6 files
master, DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error and 100 more DG-DEN-15660-1

DEN-15660 addressed the code review comments

- -5
- +5
/firmware/App/Controllers/TemperatureSensors.c
- History
- Source
- Diff
/firmware/App/.../TemperatureSensors.c
- -21
- +24
/firmware/App/Modes/ModeChemicalDisinfect.c
- History
- Source
- Diff
/firmware/App/.../ModeChemicalDisinfect.c
- -2
- +0
/firmware/App/Modes/ModeDrain.c
- History
- Source
- Diff
/firmware/App/Modes/ModeDrain.c
- -12
- +2
/firmware/App/Modes/ModeFill.c
- History
- Source
- Diff
/firmware/App/Modes/ModeFill.c
- -28
- +16
/firmware/App/Modes/ModeGenIdle.c
- History
- Source
- Diff
/firmware/App/Modes/ModeGenIdle.c
- -2
- +0
/firmware/App/Modes/ModeGenIdle.h
- History
- Source
- Diff
/firmware/App/Modes/ModeGenIdle.h

9:58 am

Dara Navaei

More
Re: DG-DEN-15660-1
replied to wbracken (deleted user)

Nelson is not part of the commercial code.

Nelson is not part of the commercial code.

9:57 am

Dara Navaei

More
Re: DG-DEN-15660-1
replied to wbracken (deleted user)

Done

Done

9:08 am

Dara Navaei

More
Re: DG-DEN-15660-1
replied to wbracken (deleted user)

Done

Done

9:06 am

Dara Navaei

More
Re: DG-DEN-15660-1
replied to wbracken (deleted user)

Done

Done

8:53 am

Dara Navaei

More
Re: DG-DEN-15660-1
replied to wbracken (deleted user)

Nelson support is only in debug mode.

Nelson support is only in debug mode.

8:51 am

Dara Navaei

More
Re: DG-DEN-15660-1
replied to Sean Nash

Done

Done

8:49 am

Dara Navaei

More
Re: DG-DEN-15660-1
replied to Sean Nash

Done

Done

8:47 am

Dara Navaei

More
Re: DG-DEN-15660-1
replied to Sean Nash

The un-averaged TDi and TRo are used for dialysate temperature checking and trimmer heater control I think we should keep them to be able to have a full picture if needed unless the CAN bus is real...

The un-averaged TDi and TRo are used for dialysate temperature checking and trimmer heater control I think we should keep them to be able to have a full picture if needed unless the CAN bus is really flooded.

8:44 am

Dara Navaei

More
Re: DG-DEN-15660-1
replied to Sean Nash

This is a time and not timeout.

This is a time and not timeout.

8:42 am

Dara Navaei

More
Re: DG-DEN-15660-1
replied to Sean Nash

Done

Done

8:41 am

Dara Navaei

More
Re: DG-DEN-15660-1
replied to Sean Nash

Done

Done

8:39 am

Dara Navaei

More
Re: DG-DEN-15660-1
replied to Sean Nash

Done

Done

8:39 am

Dara Navaei

More
Re: DG-DEN-15660-1
replied to wbracken (deleted user)

Done

Done

Tuesday 11 Jul 2023

5:42 pm

wbracken (deleted user)

More
Re: DG-DEN-15702-1
commented on review

Correct indentation

Correct indentation

5:42 pm

wbracken (deleted user)

More
Re: DG-DEN-15702-1
commented on review

Correct indentation

Correct indentation

5:41 pm

wbracken (deleted user)

More
Re: DG-DEN-15702-1
commented on review

Indentation needs to be corrected.

Indentation needs to be corrected.

5:30 pm

wbracken (deleted user)

More
Re: DG-DEN-15660-1
commented on review

handleEmptyBottleFlag is only an input

handleEmptyBottleFlag is only an input

4:03 pm

Dara Navaei

More
DG-DEN-15702-1
started review

DG-DEN-15702_Alarm 150 Inlet Water Conductivity High Does Not Disappear ON Standby Screen When

DG-DEN-15702_Alarm 150 Inlet Water Conductivity High Does Not Disappear ON Standby Screen When

3:37 pm

Darren Cox <darren_m@cox.net>

More
3163683
changed 4 files
master, DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error and 101 more DG-DEN-15702-1

DEN-15702 Check VPI Open for Inlet Conductivity, Pressure, temperature. If VPI Closed, clear alarms.

- -8
- +17
/firmware/App/Controllers/ConductivitySensors.c
- History
- Source
- Diff
/firmware/App/.../ConductivitySensors.c
- -8
- +17
/firmware/App/Controllers/Pressures.c
- History
- Source
- Diff
/firmware/App/Controllers/Pressures.c
- -10
- +24
/firmware/App/Controllers/TemperatureSensors.c
- History
- Source
- Diff
/firmware/App/.../TemperatureSensors.c
- -14
- +11
/firmware/App/Modes/ModeStandby.c
- History
- Source
- Diff
/firmware/App/Modes/ModeStandby.c

Atlassian Fisheye Git analysis with Crucible code review. (Version:4.8.14 Build:20240111091859 2024-01-11 09:20) - Administration - Page generated 2026-06-11 06:00 -0700