dgfirmware

Clone Tools

Stats

Commits this week: 0
Total Committers: 17
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 01 Sep 2023
10:01 am

Michael Garthwaite

DEN-14706: code review comments.

Options
    • -7
    • +2
    /firmware/App/Services/SystemComm.c
Thursday 31 Aug 2023
11:29 pm

Dara Navaei

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    /firmware/App/DGCommon.h
11:28 pm

Bill Bracken <bill@criticalsoftwaresolutions.com>

Merge branch 'DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment' into develop

Options
    • -2
    • +2
    /firmware/App/Controllers/Pressures.c
11:23 pm

Bill Bracken <bill@criticalsoftwaresolutions.com>

DEN-15973 Requirements changes

Options
    • -2
    • +3
    /firmware/App/Controllers/ROPump.c
2:38 pm

Bill Bracken <bill@criticalsoftwaresolutions.com>

DEN-15973 Change to alarm limits and persistence values

Options
    • -2
    • +2
    /firmware/App/Controllers/Pressures.c
    • -2
    • +4
    /firmware/App/Controllers/ROPump.c
2:37 pm

Sean Nash

This if doesn't appear to be doing anything. Remove.

This if doesn't appear to be doing anything. Remove.

2:36 pm

Sean Nash

This should be inverse of what you had before. I think this is too brief.

This should be inverse of what you had before. I think this is too brief.

2:12 pm

Michael Garthwaite

DEN-14706: wip of code review comments.

Options
    • -9
    • +9
    /firmware/App/Services/SystemComm.c
2:11 pm

Michael Garthwaite

Pushed wip code. I'm unsure what or if we need to put anything to compare override values.

Pushed wip code. I'm unsure what or if we need to put anything to compare override values.

2:11 pm

Dara Navaei

2:11 pm

Michael Garthwaite

Fixed. Thanks!

Fixed. Thanks!

2:10 pm

Michael Garthwaite

Fixed. Thanks!

Fixed. Thanks!

1:09 pm

Dara Navaei

12:45 pm

Sean Nash

Too many () after &&?

Too many () after &&?

12:44 pm

Sean Nash

Remove extra blank line.

Remove extra blank line.

12:44 pm

Sean Nash

Already TRUE - why set again? I think "if" should be reversed - if not override, set used to FALSE. And then after if, always set result to TRUE (means we found a match - which we did).

Already TRUE - why set again?
I think "if" should be reversed - if not override, set used to FALSE. And then after if, always set result to TRUE (means we found a match - which we did).

12:30 pm

Michael Garthwaite

Merge branch 'staging' into DEN-14706-can-messge-not-acked-fix

Options
12:30 pm

Michael Garthwaite

DEN-14706: Fixed DG pending ack override.

Options
    • -5
    • +18
    /firmware/App/Services/SystemComm.c
12:18 pm

Dara Navaei

DG-DEN-14706_Need Mechanism For Alarm ID Can Message Not Acked And Alarm ID DG Can Message Not Acked
DG-DEN-14706_Need Mechanism For Alarm ID Can Message Not Acked And Alarm ID DG Can Message Not Acked
12:03 pm

Dara Navaei

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    /firmware/App/DGCommon.h
12:03 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -2
    • +2
    /firmware/App/Controllers/ConductivitySensors.c
    • -1
    • +1
    /firmware/App/Controllers/Heaters.c
    • -2
    • +2
    /firmware/App/Controllers/Pressures.c
    • -1
    • +1
    /firmware/App/Modes/ModeChemicalDisinfect.c
    • -1
    • +1
    /firmware/App/Modes/ModeFault.c
    • -2
    • +2
    /firmware/App/Modes/ModeHeatDisinfect.c
    • -2
    • +2
    /firmware/App/Modes/ModeHeatDisinfect.h
11:46 am

Dara Navaei

Merged DEN-16309

Options
11:26 am

Dara Navaei

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    /firmware/App/DGCommon.h
9:51 am

wbracken  (deleted user) and Sean Nash

9:31 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

9:14 am

Dara Navaei

DEN-16309 merged staging

Options
    • -6
    • +107
    /firmware/App/Modes/ModeHeatDisinfect.c
    • -2
    • +6
    /firmware/App/Modes/ModeHeatDisinfect.h
9:12 am

Dara Navaei

DEN-16309 addressed a code review comment

Options
    • -1
    • +1
    /firmware/App/Modes/ModeChemicalDisinfect.c
9:08 am

Dara Navaei

Done.

Done.

8:55 am

Sean Nash

Why 0.0F? memset() doesn't care about type - it just sets a number of bytes to given value.

Why 0.0F? memset() doesn't care about type - it just sets a number of bytes to given value.

Wednesday 30 Aug 2023
3:49 pm

Dara Navaei

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    /firmware/App/DGCommon.h