dgfirmware

Clone Tools
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
DEN-14706: code review comments.

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Merge branch 'DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment' into develop

DEN-15973 Requirements changes

DEN-15973 Change to alarm limits and persistence values

This if doesn't appear to be doing anything. Remove.

This if doesn't appear to be doing anything. Remove.

This should be inverse of what you had before. I think this is too brief.

This should be inverse of what you had before. I think this is too brief.

DEN-14706: wip of code review comments.

Pushed wip code. I'm unsure what or if we need to put anything to compare override values.

Pushed wip code. I'm unsure what or if we need to put anything to compare override values.

Fixed. Thanks!

Fixed. Thanks!

Fixed. Thanks!

Fixed. Thanks!

Too many () after &&?

Too many () after &&?

Remove extra blank line.

Remove extra blank line.

Already TRUE - why set again? I think "if" should be reversed - if not override, set used to FALSE. And then after if, always set result to TRUE (means we found a match - which we did).

Already TRUE - why set again?
I think "if" should be reversed - if not override, set used to FALSE. And then after if, always set result to TRUE (means we found a match - which we did).

Merge branch 'staging' into DEN-14706-can-messge-not-acked-fix

DEN-14706: Fixed DG pending ack override.

    • -5
    • +18
    /firmware/App/Services/SystemComm.c
DG-DEN-14706_Need Mechanism For Alarm ID Can Message Not Acked And Alarm ID DG Can Message Not Acked
DG-DEN-14706_Need Mechanism For Alarm ID Can Message Not Acked And Alarm ID DG Can Message Not Acked
Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

    • -2
    • +2
    /firmware/App/Modes/ModeHeatDisinfect.c
    • -2
    • +2
    /firmware/App/Modes/ModeHeatDisinfect.h
Merged DEN-16309

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

DEN-16309 merged staging

    • -6
    • +107
    /firmware/App/Modes/ModeHeatDisinfect.c
    • -2
    • +6
    /firmware/App/Modes/ModeHeatDisinfect.h
DEN-16309 addressed a code review comment

Done.

Done.

Why 0.0F? memset() doesn't care about type - it just sets a number of bytes to given value.

Why 0.0F? memset() doesn't care about type - it just sets a number of bytes to given value.

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo