dgfirmware

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
DG-DEN-16314_Alarm 206 Triggers After Resuming From Incoming Water Conductivity High OR Low 2
DG-DEN-16314_Alarm 206 Triggers After Resuming From Incoming Water Conductivity High OR Low 2
DG-DEN-16382_Alarm 207 DG Flow Meter Check Failure Triggers After Alarm 282 Bicarbonate Volume
DG-DEN-16382_Alarm 207 DG Flow Meter Check Failure Triggers After Alarm 282 Bicarbonate Volume
RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Dara suggested removing this, as the feature was incomplete and appears to cause odd timer/alarm behavior.

Dara suggested removing this, as the feature was incomplete and appears to cause odd timer/alarm behavior.

You are removing recover treatment test config functionality? Is this moving somewhere else or we've decided not to implement?

You are removing recover treatment test config functionality? Is this moving somewhere else or we've decided not to implement?

DG-DIAL-285_Event Log 15 Missing Fill Prime Concentrate State
DG-DIAL-285_Event Log 15 Missing Fill Prime Concentrate State
RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Done

Done

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Dara, I mean inline comments for the magic numbers. Explain what 40 and 32 mean and why you're using those values.

Dara, I mean inline comments for the magic numbers. Explain what 40 and 32 mean and why you're using those values.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Done

Done

Done

Done

You at least need to add a comment explaining what they are.

You at least need to add a comment explaining what they are.

Done

Done

No, these are the minimum values to trigger the alarm. But they are named maximums.

No, these are the minimum values to trigger the alarm. But they are named maximums.

Yes these are for software configuration disable only so I did not make any #defines for them.

Yes these are for software configuration disable only so I did not make any #defines for them.

Yes, so name should reflect that. These names suggest they are minimum pressures below which we would alarm.

Yes, so name should reflect that. These names suggest they are minimum pressures below which we would alarm.