dgfirmware

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
This code is the theoretical code for treatment recovery. At the moment this code is not reachable neither in the firmware or VectorCAST.

This code is the theoretical code for treatment recovery. At the moment this code is not reachable neither in the firmware or VectorCAST.

This default is in an if statement to make sure we are less than NUM_OF_VALVES so the default cannot be reached in VectorCAST. But we keep the default in the code in case there was a memory stomp o...

This default is in an if statement to make sure we are less than NUM_OF_VALVES so the default cannot be reached in VectorCAST. But we keep the default in the code in case there was a memory stomp or other anomalies.

Our coding standard encourages always including default as the last clause, even if it is empty. (following misra 16.5). I would suggest using the ifdef within the body of the default clause, even ...

Our coding standard encourages always including default as the last clause, even if it is empty. (following misra 16.5).
I would suggest using the ifdef within the body of the default clause, even with the statement duplicated, or adding an else clause to the ifndef with a second, empty default.

What's left? When would this code ever become reachable?

What's left? When would this code ever become reachable?

The default case should probably be present, whether or not VECTORCAST is defined. I suggest bringing the ifdef in, to eliminate only the "name =" line (479).

The default case should probably be present, whether or not VECTORCAST is defined. I suggest bringing the ifdef in, to eliminate only the "name =" line (479).

DG-DEN-16446_DG Dev Test Clean UP
DG-DEN-16446_DG Dev Test Clean UP
DG-DEN-16314_Alarm 206 Triggers After Resuming From Incoming Water Conductivity High OR Low 2
DG-DEN-16314_Alarm 206 Triggers After Resuming From Incoming Water Conductivity High OR Low 2
DG-DEN-16382_Alarm 207 DG Flow Meter Check Failure Triggers After Alarm 282 Bicarbonate Volume
DG-DEN-16382_Alarm 207 DG Flow Meter Check Failure Triggers After Alarm 282 Bicarbonate Volume
RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Dara suggested removing this, as the feature was incomplete and appears to cause odd timer/alarm behavior.

Dara suggested removing this, as the feature was incomplete and appears to cause odd timer/alarm behavior.

You are removing recover treatment test config functionality? Is this moving somewhere else or we've decided not to implement?

You are removing recover treatment test config functionality? Is this moving somewhere else or we've decided not to implement?

DG-DIAL-285_Event Log 15 Missing Fill Prime Concentrate State
DG-DIAL-285_Event Log 15 Missing Fill Prime Concentrate State
RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Done

Done

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Dara, I mean inline comments for the magic numbers. Explain what 40 and 32 mean and why you're using those values.

Dara, I mean inline comments for the magic numbers. Explain what 40 and 32 mean and why you're using those values.