dgfirmware / firmware

.ccsproject

Clone Tools

Stats

Commits this week: 0
Total Committers: 1
Last Commit: 19 Nov
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 03 Aug 2023
1:21 pm

Sean Nash

10:09 am

Dara Navaei

Wednesday 02 Aug 2023
4:01 pm

Sean Nash

Monday 08 May 2023
9:44 am

Dara Navaei

DG Staging Unreviewed Commits
DG Staging Unreviewed Commits
Tuesday 21 Mar 2023
5:12 pm

Dara Navaei

8:35 am

Sean Nash

8:33 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

8:32 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

8:30 am

Dara Navaei

Done

Done

8:28 am

Dara Navaei

Done

Done

Monday 20 Mar 2023
11:50 pm

Sean Nash

This seems wrong.

This seems wrong.

11:50 pm

Sean Nash

This seems wrong.

This seems wrong.

8:31 pm

wbracken  (deleted user) and jtaylor  (deleted user)

4:34 pm

jtaylor  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

1:32 pm

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

9:49 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

9:48 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

9:48 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

9:34 am

Dara Navaei

Done. Thanks for catching it.

Done. Thanks for catching it.

9:28 am

Dara Navaei

Done

Done

9:28 am

Dara Navaei

Done

Done

8:57 am

Sean Nash

Not all of these are disinfect usage (e.g. RO water generated) so I don't think disinfect_usage is appropriate. I am ok with usage_info, though I think DG_USAGE_INFO is better.

Not all of these are disinfect usage (e.g. RO water generated) so I don't think disinfect_usage is appropriate. I am ok with usage_info, though I think DG_USAGE_INFO is better.

8:48 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

8:43 am

Sean Nash

Missing comment?

Missing comment?

8:42 am

Sean Nash

Everything else in this function should be in an else body if given reservoir ID is invalid so we don't try to use an invalid ID.

Everything else in this function should be in an else body if given reservoir ID is invalid so we don't try to use an invalid ID.

8:36 am

Sean Nash

Why lower case when others are uppercase?

Why lower case when others are uppercase?

Saturday 18 Mar 2023
2:43 pm

Dara Navaei

DEN-14763 addressed the code review comments'

Options
    • -1
    • +1
    ./.ccsproject
  2. … 2 more files in changeset.
2:41 pm

Dara Navaei

This is to find the target configuration which in our case it is XDS-110 automatically. It seems the .ccxml file in the targetConfigs folder sets the right debugger and target regardless of this ch...

This is to find the target configuration which in our case it is XDS-110 automatically. It seems the .ccxml file in the targetConfigs folder sets the right debugger and target regardless of this check box being true or false. I set it back to true to be consistent.

Friday 17 Mar 2023
2:42 pm

Dara Navaei

Done

Done

8:56 am

jtaylor  (deleted user)

I would suggest a more consistent naming for the enum items. "DISINFECT_USAGE_" rather than USAGE_INFO_ in the enum elements, and eliminating the "_DIS". This would be more specific since "USAGE" a...

I would suggest a more consistent naming for the enum items. "DISINFECT_USAGE_" rather than USAGE_INFO_ in the enum elements, and eliminating the "_DIS".
This would be more specific since "USAGE" and "INFO" are redundant, and "DIS" can be confused with "dis-", the Latin prefix.