ConductivitySensors.c

Clone Tools
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Done

Done

I did. I still see a call to sendAckResponseMsg() and I don't think it should be here.

I did. I still see a call to sendAckResponseMsg() and I don't think it should be here.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Check the diff of the last two commits.

Check the diff of the last two commits.

What I meant is that we don't need to send anything other than response.

What I meant is that we don't need to send anything other than response.

Done

Done

Remove TODO?

Remove TODO?

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Done

Done

Changed it to TRUE/FALSE.

Changed it to TRUE/FALSE.

Updated the code.

Updated the code.

Done

Done

Done

Done

Done

Done

Done

Done

Done

Done

Prefer to say RO only != TRUE so that any other value than 1 will cause RR alarm to be enforced.

Prefer to say RO only != TRUE so that any other value than 1 will cause RR alarm to be enforced.

Needs param so caller can set it to FALSE too?

Needs param so caller can set it to FALSE too?

Doesn't look like this list is complete. In my opinion, init functions should be allowed to generalize here (e.g. Fill mode variables initialized.).

Doesn't look like this list is complete. In my opinion, init functions should be allowed to generalize here (e.g. Fill mode variables initialized.).

I don't think we need to ack/nak since we always respond with response msg.

I don't think we need to ack/nak since we always respond with response msg.

Need else for if FALSE - disable RO only.

Need else for if FALSE - disable RO only.