ConductivitySensors.c

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
RESOLVED IN CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

Removed 2nd comment.

Removed 2nd comment.

This section will be automatically created.

This section will be automatically created.

A single comment marker (c++ style), aligned with the other comments in the block would be a little more readable.

A single comment marker (c++ style), aligned with the other comments in the block would be a little more readable.

Alignment

Alignment

DG-DEN-14999_Alarm Table Updates Part 2
DG-DEN-14999_Alarm Table Updates Part 2
RESOLVED IN CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH.

Corrected

Corrected

Corrected

Corrected

Corrected

Corrected

Does TODO need to be resolved?

Does TODO need to be resolved?

Extra space before the last paren.

Extra space before the last paren.

Missing space.

Missing space.

RESOLVED IN CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH.

I think VPi is closed during standby mode, so not sure why we want to check inlet conductivity in this mode. I imagine new system would get installed by service - would need some kind of priming do...

I think VPi is closed during standby mode, so not sure why we want to check inlet conductivity in this mode.
I imagine new system would get installed by service - would need some kind of priming done in service mode, so I'm not worried about that.

will these alarms trigger with open air? Ex: if a user has a device shipped to them, will they be greeted with conductivity alarms on first power up before any water has ran through the system? If...

will these alarms trigger with open air?

Ex: if a user has a device shipped to them, will they be greeted with conductivity alarms on first power up before any water has ran through the system? If so, how will they be able to fix it?

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

I don't see it, but resolving anyway. RESOLVED in CODE WALKTHROUGH.

I don't see it, but resolving anyway.
RESOLVED in CODE WALKTHROUGH.

Spaces inside (). And explicit condition (i.e. ( TRUE == isConvNotValid ).

Spaces inside (). And explicit condition (i.e. ( TRUE == isConvNotValid ).

Corrected

Corrected