Pressures.c

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
DEN-14999 merged staging

  1. … 9 more files in changeset.
RESOLVED IN CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

DEN-14999 updated the code based on the alarms table

  1. … 9 more files in changeset.
Removed 2nd comment.

Removed 2nd comment.

This section will be automatically created.

This section will be automatically created.

A single comment marker (c++ style), aligned with the other comments in the block would be a little more readable.

A single comment marker (c++ style), aligned with the other comments in the block would be a little more readable.

Alignment

Alignment

DG-DEN-14999_Alarm Table Updates Part 2
DG-DEN-14999_Alarm Table Updates Part 2
Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

  1. … 17 more files in changeset.
RESOLVED IN CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH.

I think VPi is closed during standby mode, so not sure why we want to check inlet conductivity in this mode. I imagine new system would get installed by service - would need some kind of priming do...

I think VPi is closed during standby mode, so not sure why we want to check inlet conductivity in this mode.
I imagine new system would get installed by service - would need some kind of priming done in service mode, so I'm not worried about that.

will these alarms trigger with open air? Ex: if a user has a device shipped to them, will they be greeted with conductivity alarms on first power up before any water has ran through the system? If...

will these alarms trigger with open air?

Ex: if a user has a device shipped to them, will they be greeted with conductivity alarms on first power up before any water has ran through the system? If so, how will they be able to fix it?

DEN-14999 updated the code based on the alarms table update

  1. … 8 more files in changeset.
DEN-14999 fixed the pressures self test

DEN-14999: Removed alarm 203 (dg POST adc rail check for pressure sensors). Removed alarm 116 (dg temperature sensors adc rail check). Removed adc temperature sensors from alarm 115 (dg temperature sensors range check).

  1. … 1 more file in changeset.
DG-DEN-14999_Alarm Table Updates
DG-DEN-14999_Alarm Table Updates
Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

  1. … 17 more files in changeset.
RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Done

Done

Done

Done

This seems wrong.

This seems wrong.