dgfirmware / firmware / App / Controllers

TemperatureSensors.c

Clone Tools

Stats

Commits this week: 0
Total Committers: 10
Last Commit: 19 Nov
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 03 Aug 2022
11:12 am

Sean Nash

Use explicit condition ( TRUE == resetStateTimer ).

Use explicit condition ( TRUE == resetStateTimer ).

11:11 am

Sean Nash

Use explicit condition ( TRUE == resetStateTimer ).

Use explicit condition ( TRUE == resetStateTimer ).

11:11 am

Sean Nash

Add resetStateTimer @param.

Add resetStateTimer @param.

11:07 am

Sean Nash

Why commented out? Remove if no longer needed. If coming back, use explicit condition ( TRUE == resetStateTimer ).

Why commented out? Remove if no longer needed. If coming back, use explicit condition ( TRUE == resetStateTimer ).

11:07 am

Sean Nash

Use explicit condition ( TRUE == resetStateTimer ).

Use explicit condition ( TRUE == resetStateTimer ).

11:06 am

Sean Nash

Add resetStateTimer @param.

Add resetStateTimer @param.

11:06 am

Sean Nash

I don't see resetStateTimer being used (unless commented out code is coming back). Also, it is not in function header.

I don't see resetStateTimer being used (unless commented out code is coming back). Also, it is not in function header.

11:04 am

Sean Nash

Why commented out? Remove if no longer needed.

Why commented out? Remove if no longer needed.

11:03 am

Sean Nash

Separate assignments or at least put all in same line.

Separate assignments or at least put all in same line.

11:02 am

Sean Nash

Separate assignments or at least put all in same line.

Separate assignments or at least put all in same line.

11:02 am

Sean Nash

Separate assignments or at least put all in same line.

Separate assignments or at least put all in same line.

11:02 am

Sean Nash

Separate assignments or at least put all in same line.

Separate assignments or at least put all in same line.

11:01 am

Sean Nash

Separate assignments or at least put all in same line.

Separate assignments or at least put all in same line.

10:58 am

Sean Nash

Use explicit condition ( TRUE == resetStateTimer ).

Use explicit condition ( TRUE == resetStateTimer ).

10:56 am

Sean Nash

This looks like it allows flows > maximum now. What is the intent here?

This looks like it allows flows > maximum now. What is the intent here?

10:55 am

Sean Nash

This looks like it allows flows > maximum now. What is the intent here?

This looks like it allows flows > maximum now. What is the intent here?

10:55 am

Sean Nash

This looks like it allows flows > maximum now. What is the intent here?

This looks like it allows flows > maximum now. What is the intent here?

Monday 01 Aug 2022
2:52 pm

wbracken  (deleted user)

Remove comment at end of line. Is fpgaReadByteSize replacing sizeof(DG_FPGA_SENSORS_T)?

Remove comment at end of line. Is fpgaReadByteSize replacing sizeof(DG_FPGA_SENSORS_T)?

2:46 pm

wbracken  (deleted user)

Remove comment at end of line? sam for 710/822.

Remove comment at end of line? sam for 710/822.

10:44 am

wbracken  (deleted user)

Does the monitorPumpSpeed function generate the alarm

Does the monitorPumpSpeed function generate the alarm

Saturday 23 Jul 2022
2:46 pm

Sean Nash

Should 0.5 be a #define?

Should 0.5 be a #define?

2:45 pm

Sean Nash

TODO should be all CAPS.

TODO should be all CAPS.

2:43 pm

Sean Nash

Is it really true that all function below this line are DVT?

Is it really true that all function below this line are DVT?

2:42 pm

Sean Nash

If these comment outs are not permanent, add a TODO. Otherwise remove the commented out code.

If these comment outs are not permanent, add a TODO. Otherwise remove the commented out code.

2:37 pm

Sean Nash

Is this logic right? Looks like it should be || instead of && and it should be == instead of != DG_MODE_INIT.

Is this logic right? Looks like it should be || instead of && and it should be == instead of != DG_MODE_INIT.

2:35 pm

Sean Nash

No point in initializing here - gets set by exec function.

No point in initializing here - gets set by exec function.

2:29 pm

Sean Nash

Is this a TODO?

Is this a TODO?

2:26 pm

Sean Nash

Fix alignment.

Fix alignment.

2:25 pm

Sean Nash

Fix alignment.

Fix alignment.

2:24 pm

Sean Nash

Should go to NV data POST state regardless of RTC pass/fail. Still need to get calibration and system records read.

Should go to NV data POST state regardless of RTC pass/fail. Still need to get calibration and system records read.