TemperatureSensors.c

Clone Tools
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
DEN-14646 Update per code review comments.

  1. … 5 more files in changeset.
RESOLVED IN CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH.

Corrected.

Corrected.

Correct as is per conversation with Darren.

Correct as is per conversation with Darren.

Removed.

Removed.

Yes.

Yes.

Per our alarms discussion it was decided that this alarm was no longer necessary.

Per our alarms discussion it was decided that this alarm was no longer necessary.

Add concCap and diaCap to header.

Add concCap and diaCap to header.

Function header.

Function header.

Function header.

Function header.

Function header.

Function header.

Function header.

Function header.

Function header.

Function header.

Function header.

Function header.

Add function header.

Add function header.

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

DEBUG bread crumb comment?

DEBUG bread crumb comment?

DEBUG bread crumb comment.

DEBUG bread crumb comment.

Maybe we should put a bread crumb comment here to make it easier to find lines of code that need to be commented out when debugging (e.g. // comment this line for DEBUG).

Maybe we should put a bread crumb comment here to make it easier to find lines of code that need to be commented out when debugging (e.g. // comment this line for DEBUG).

A small thing, but 24V Main should come before first voltage.

A small thing, but 24V Main should come before first voltage.

Why is this indented?

Why is this indented?

Is prefix guaranteed to not be zero?

Is prefix guaranteed to not be zero?

Is it ok to ignore P if package has already been started? Should this ever happen?

Is it ok to ignore P if package has already been started? Should this ever happen?

Use #define for bit mask. Remove extra ";".

Use #define for bit mask. Remove extra ";".

Merge branch 'staging' into DEN-14646-fpga-alarm-properties-and-timing-3

# Conflicts:

# firmware/App/Controllers/TemperatureSensors.c

  1. … 1 more file in changeset.
Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

  1. … 7 more files in changeset.
RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.