Thermistors.h

Clone Tools
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

  1. … 100 more files in changeset.
Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

  1. … 100 more files in changeset.
Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

  1. … 100 more files in changeset.
Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

  1. … 100 more files in changeset.
RESOLVED in CODE WALKTHROUGH

RESOLVED in CODE WALKTHROUGH

DG-DEN-3421_DG Heat Disinfection
DG-DEN-3421_DG Heat Disinfection
Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

  1. … 9 more files in changeset.
RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

Updated comment

Updated comment

DEN-13946 Corrections per code review

  1. … 6 more files in changeset.
RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

Corrected.

Corrected.

Only used if Temperature is in alarm.

Only used if Temperature is in alarm.

Only used if the load cell is out of range.

Only used if the load cell is out of range.

No initial value for alarmID. Can it end up not set before use in checkPersistentAlarm?

No initial value for alarmID. Can it end up not set before use in checkPersistentAlarm?

Why remove initial value for alarmIndex?

Why remove initial value for alarmIndex?

Comment does not explain what the numbers are - 3, 10, 10.

Comment does not explain what the numbers are - 3, 10, 10.

Comment is 12bit specific, but code updated to use different references per thermistor.

Comment is 12bit specific, but code updated to use different references per thermistor.

Setting first iterator to 0 seems safer (in case somebody adds a new enum before what used to be the first enum). Could also create a redundant 0 enum like below and use the "first" enum to initial...

Setting first iterator to 0 seems safer (in case somebody adds a new enum before what used to be the first enum).
Could also create a redundant 0 enum like below and use the "first" enum to initialize a loop iterator safely:
enum list
{
FIRST_TEMP_SENSOR = 0,
TPI_SENSOR = FIRST_TEMP_SENSOR,
TPO_SENSOR,
TD1_SENSOR,
....
}
RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Similar code is in other monitoring functions. monitorTemperatureSensors, monitorPressureSensors iterate over their list of sensors using U08. monitorThermistors iterates over thermistors using typ...

Similar code is in other monitoring functions. monitorTemperatureSensors, monitorPressureSensors iterate over their list of sensors using U08. monitorThermistors iterates over thermistors using typedef THERMISTORS_TEMP_SENSORS_T. Changed load cells to use U08 to be consistent with temperature and pressure monitoring.

Should probably change temperature, pressure and load cells to use correct typedef.

Also, it looks like why the typedefs weren't used was in order to set the initial value of the iterator to 0 (i.e, the first sensor in the list). Seems like there should be a value that is the first item in the list, i.e. TEMPSENSORS_FIRST_SENSOR.

Removed.

Removed.

Remove blank line.

Remove blank line.

Why change this to U08?

Why change this to U08?