dgfirmware / firmware / App

Controllers

Clone Tools

Stats

Commits this week: 0
Total Committers: 16
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 06 Apr 2021
11:32 am

Quang Nguyen <qnguyen@diality.com>

Merge branch 'staging' into DEN-7091-pre-treatment-mode

Options
    • -2
    • +3
    ./DrainPump.c
    • -0
    • +90
    ./LoadCell.c
  3. … 7 more files in changeset.
10:30 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:28 am

qnguyen  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:10 am

Dara Navaei

Done.

Done.

10:08 am

Dara Navaei

Yes, they are going to be used in mode flush and chemical disinfect as well as heat disinfect.

Yes, they are going to be used in mode flush and chemical disinfect as well as heat disinfect.

9:38 am

Sean Nash

Any reason why these are in common header? Does anybody else use them? If not, make private to HeatDisinfect module.

Any reason why these are in common header? Does anybody else use them? If not, make private to HeatDisinfect module.

Monday 05 Apr 2021
6:01 pm

qnguyen  (deleted user)

Recommend adding TRUE to the comparison and parenthesis around each condition.

Recommend adding TRUE to the comparison and parenthesis around each condition.

Saturday 03 Apr 2021
6:47 pm

Dara Navaei

I do not know what happened. I brought it back.

I do not know what happened. I brought it back.

6:43 pm

Dara Navaei

I brought it back.

I brought it back.

6:42 pm

Dara Navaei

Done.

Done.

6:41 pm

Dara Navaei

Done.

Done.

6:41 pm

Dara Navaei

Done.

Done.

6:40 pm

Dara Navaei

No, this variable is used to time both the disinfect states.

No, this variable is used to time both the disinfect states.

6:39 pm

Dara Navaei

This was in the flow chart. So far both values to do the difference comes from TRo so it should be tested in V3.

This was in the flow chart. So far both values to do the difference comes from TRo so it should be tested in V3.

6:38 pm

Dara Navaei

The #defines are aligned.

The #defines are aligned.

6:36 pm

Dara Navaei

These enums are the possible status that can occur during the actual heat disinfect.

These enums are the possible status that can occur during the actual heat disinfect.

6:35 pm

Dara Navaei

They are both in Water Cancellation Path state. They are separate because hot cancellation requires mix drain.

They are both in Water Cancellation Path state. They are separate because hot cancellation requires mix drain.

6:32 pm

Dara Navaei

I added the function to reset the actuators.

I added the function to reset the actuators.

6:31 pm

Dara Navaei

Done.

Done.

6:31 pm

Dara Navaei

I moved the location of the comment.

I moved the location of the comment.

6:29 pm

Dara Navaei

I added more description for all the states.

I added more description for all the states.

6:28 pm

Dara Navaei

I rephrased it.

I rephrased it.

6:27 pm

Dara Navaei

THd belongs to this group. TRo is temporarily used as THd.

THd belongs to this group. TRo is temporarily used as THd.

6:26 pm

Dara Navaei

This is the oneliner syntax, what do you mean by setting them explicitly?

This is the oneliner syntax, what do you mean by setting them explicitly?

6:25 pm

Dara Navaei

Done.

Done.

6:24 pm

Dara Navaei

Done.

Done.

6:22 pm

Dara Navaei

Yes. In Disinfect R1 to R2 and Disinfect R2 to R1, the reservoirs might leak, or we might not be able to reach to 81C within the specified time.

Yes. In Disinfect R1 to R2 and Disinfect R2 to R1, the reservoirs might leak, or we might not be able to reach to 81C within the specified time.

6:21 pm

Dara Navaei

This state has been removed.

This state has been removed.

6:20 pm

Dara Navaei

Yes. Drain can time out. It transitions to Basic Cancellation path.

Yes. Drain can time out. It transitions to Basic Cancellation path.

6:19 pm

Dara Navaei

TRo is used as the coldest spot until V3.

TRo is used as the coldest spot until V3.