Controllers

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
DEN-5963 addressed code review comments

  1. … 4 more files in changeset.
Done.

Done.

Done.

Done.

This is another way to be able to turn off the pump by just setting the RPM to 0.

This is another way to be able to turn off the pump by just setting the RPM to 0.

I added a build switch to ignore this part.

I added a build switch to ignore this part.

I added a build switch to ignore this part.

I added a build switch to ignore this part.

I added a build switch to ignore this part.

I added a build switch to ignore this part.

I added a TODO on top to explain that this part will be addressed once the drain pump RPM can be read reliably. I added a build switch to ignore this part.

I added a TODO on top to explain that this part will be addressed once the drain pump RPM can be read reliably. I added a build switch to ignore this part.

Done.

Done.

Done.

Done.

This is an and. I changed the comment.

This is an and. I changed the comment.

Done.

Done.

Done.

Done.

Recommend adding TRUE or FALSE to check explicitly. Apply to the rest of the file.

Recommend adding TRUE or FALSE to check explicitly. Apply to the rest of the file.

This should be a post-increment. Otherwise, it will never retry with MAX_ALLOWED_STATE_TRIALS = 1. Apply to the rest of the file.

This should be a post-increment. Otherwise, it will never retry with MAX_ALLOWED_STATE_TRIALS = 1.
Apply to the rest of the file.

Should this be an OR (according to the comment)?

Should this be an OR (according to the comment)?

Align the define value (for most of the define section).

Align the define value (for most of the define section).

Use SEC_PER_MIN to replace 60.

Use SEC_PER_MIN to replace 60.

I changed the publish interval to 1 second. I also removed the extra parentheses.

I changed the publish interval to 1 second. I also removed the extra parentheses.

I brought it back.

I brought it back.

I set them explicitly.

I set them explicitly.

The minimum is not needed and I removed it.

The minimum is not needed and I removed it.

The alarm is different for each condition, so that explains what failed and in what state (i.e reservoir drain time out in drain R1 state)

The alarm is different for each condition, so that explains what failed and in what state (i.e reservoir drain time out in drain R1 state)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.