Controllers

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
DEN-8103: Moved integrity module to fwcommon

  1. … 4 more files in changeset.
Done.

Done.

Noe said they updated the ID and this is the new ID for DG FPGA. The FPGA test will fail without this change.

Noe said they updated the ID and this is the new ID for DG FPGA.
The FPGA test will fail without this change.

Should mention somewhere that timer is counting ms.

Should mention somewhere that timer is counting ms.

Why did this change?

Why did this change?

Is there a reason why this module isn't in fwcommon? And if it can't be common for some reason, should this module (or group name) be named DGIntegrity?

Is there a reason why this module isn't in fwcommon? And if it can't be common for some reason, should this module (or group name) be named DGIntegrity?

Do we need to support more than one 32-bit CRC algorithm in firmware? If not, do we need this wrapper function?

Do we need to support more than one 32-bit CRC algorithm in firmware? If not, do we need this wrapper function?

Done.

Done.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Fixed.

Fixed.

Yes. Fixed.

Yes. Fixed.

Consider re-word to something more general. This function might be used by ModeHeatDisinfect to tare on an active reservoir.

Consider re-word to something more general. This function might be used by ModeHeatDisinfect to tare on an active reservoir.

Should this be in interval count?

Should this be in interval count?

DEN-7802: Updated temperature sensor alarms

DEN-7802: Added persistence to concentrate pumps check

  1. … 1 more file in changeset.
Fixed merge conflicts.

  1. … 6 more files in changeset.
DEN-7605: Fixed merge conflicts.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

DEN-7605: Addressed code review feedback.

Fixed.

Fixed.

Fixed.

Fixed.

Fixed merge conflicts.

  1. … 5 more files in changeset.
DEN-7605: Added delays to drain mode.

  1. … 1 more file in changeset.
The only preference is to put TRUE first if it is == such as below.

The only preference is to put TRUE first if it is == such as below.

I have no preference on that. Data is temporary either way. By reference is a little easier on the stack.

I have no preference on that. Data is temporary either way. By reference is a little easier on the stack.

Should we move this enum to separate .h file?

Should we move this enum to separate .h file?