dgfirmware / firmware / App

Controllers

Clone Tools

Stats

Commits this week: 0
Total Committers: 16
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Saturday 29 May 2021
12:58 am

Quang Nguyen <qnguyen@diality.com>

DEN-8103: Moved integrity module to fwcommon

Options
    • -3
    • +3
    ./TemperatureSensors.c
  2. … 4 more files in changeset.
Friday 28 May 2021
4:39 pm

qnguyen  (deleted user)

Done.

Done.

4:33 pm

qnguyen  (deleted user)

Noe said they updated the ID and this is the new ID for DG FPGA. The FPGA test will fail without this change.

Noe said they updated the ID and this is the new ID for DG FPGA.
The FPGA test will fail without this change.

3:20 pm

Sean Nash

Should mention somewhere that timer is counting ms.

Should mention somewhere that timer is counting ms.

3:19 pm

Sean Nash

Why did this change?

Why did this change?

3:18 pm

Sean Nash

Is there a reason why this module isn't in fwcommon? And if it can't be common for some reason, should this module (or group name) be named DGIntegrity?

Is there a reason why this module isn't in fwcommon? And if it can't be common for some reason, should this module (or group name) be named DGIntegrity?

3:18 pm

Sean Nash

Do we need to support more than one 32-bit CRC algorithm in firmware? If not, do we need this wrapper function?

Do we need to support more than one 32-bit CRC algorithm in firmware? If not, do we need this wrapper function?

Thursday 27 May 2021
10:34 am

qnguyen  (deleted user)

Done.

Done.

10:32 am

qnguyen  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:32 am

qnguyen  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:32 am

pmontazemi  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:31 am

pmontazemi  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:30 am

pmontazemi  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Wednesday 26 May 2021
9:35 am

Sean Nash

Fixed.

Fixed.

9:06 am

Sean Nash

Yes. Fixed.

Yes. Fixed.

9:03 am

qnguyen  (deleted user)

Consider re-word to something more general. This function might be used by ModeHeatDisinfect to tare on an active reservoir.

Consider re-word to something more general. This function might be used by ModeHeatDisinfect to tare on an active reservoir.

8:58 am

qnguyen  (deleted user)

Should this be in interval count?

Should this be in interval count?

Tuesday 25 May 2021
9:56 pm

Quang Nguyen <qnguyen@diality.com>

DEN-7802: Updated temperature sensor alarms

Options
    • -3
    • +3
    ./TemperatureSensors.c
4:14 pm

Quang Nguyen <qnguyen@diality.com>

DEN-7802: Added persistence to concentrate pumps check

Options
    • -3
    • +3
    ./TemperatureSensors.c
  2. … 1 more file in changeset.
1:12 pm

Sean Nash

Fixed merge conflicts.

Options
    • -7
    • +7
    ./ROPump.c
    • -3
    • +3
    ./TemperatureSensors.c
  3. … 6 more files in changeset.
Monday 24 May 2021
11:24 pm

Sean Nash

DEN-7605: Fixed merge conflicts.

Options
    • -3
    • +3
    ./TemperatureSensors.c
Friday 21 May 2021
10:42 am

Dara Navaei

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:21 am

Sean Nash

DEN-7605: Addressed code review feedback.

Options
    • -7
    • +7
    ./ROPump.c
10:20 am

Sean Nash

Fixed.

Fixed.

10:20 am

Sean Nash

Fixed.

Fixed.

9:18 am

Sean Nash

Fixed merge conflicts.

Options
    • -4
    • +109
    ./DrainPump.c
    • -2
    • +69
    ./ROPump.c
    • -8
    • +69
    ./Valves.c
    • -0
    • +1
    ./Valves.h
  5. … 5 more files in changeset.
8:54 am

Sean Nash

DEN-7605: Added delays to drain mode.

Options
    • -0
    • +12
    ./DrainPump.c
    • -1
    • +1
    ./DrainPump.h
  3. … 1 more file in changeset.
Thursday 20 May 2021
11:26 am

qnguyen  (deleted user)

The only preference is to put TRUE first if it is == such as below.

The only preference is to put TRUE first if it is == such as below.

8:58 am

Sean Nash

I have no preference on that. Data is temporary either way. By reference is a little easier on the stack.

I have no preference on that. Data is temporary either way. By reference is a little easier on the stack.

Wednesday 19 May 2021
5:15 pm

Sean Nash

Should we move this enum to separate .h file?

Should we move this enum to separate .h file?