dgfirmware / firmware / App

Controllers

Clone Tools

Stats

Commits this week: 0
Total Committers: 16
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Sunday 06 Jun 2021
6:13 pm

Dara Navaei

DEN-8030 added UI states to heat disinfect. Changed the heaters control.

Options
    • -3
    • +10
    ./DrainPump.c
    • -19
    • +48
    ./Heaters.c
    • -3
    • +0
    ./ROPump.c
  4. … 7 more files in changeset.
Friday 04 Jun 2021
2:13 pm

Sean Nash

Change order of comparison.

Change order of comparison.

2:11 pm

Sean Nash

Blank line after declaration.

Blank line after declaration.

2:08 pm

Sean Nash

I think we should add the new THd temperature sensor now. I know it's currently using TRo connection (and so we don't have a TRo), but we should handle that with build switch (THd reads from TRo ch...

I think we should add the new THd temperature sensor now. I know it's currently using TRo connection (and so we don't have a TRo), but we should handle that with build switch (THd reads from TRo channel and TRo can just be a copy of TDi for now if THD_USING_TRO_CONNECTOR build switch enabled, actual future code where both sensors exist on their own connectors if build switch is disabled).

12:42 pm

Sean Nash

Is this needed. Should we just let Standby mode set actuators as it wants on entry?

Is this needed. Should we just let Standby mode set actuators as it wants on entry?

12:40 pm

Sean Nash

I think we should at least say that the mode variables are reset to re-start the mode or something.

I think we should at least say that the mode variables are reset to re-start the mode or something.

12:37 pm

Sean Nash

Why are some values aligned at left and others at right? I think all values should align at left.

Why are some values aligned at left and others at right? I think all values should align at left.

12:32 pm

Sean Nash

I'm assuming HET was enabled to get access to a GPIO pin? If so, do we need these notifications? Is there a place in HalCOGen to disable HET interrupts?

I'm assuming HET was enabled to get access to a GPIO pin? If so, do we need these notifications? Is there a place in HalCOGen to disable HET interrupts?

12:28 pm

Sean Nash

Not necessary - included in .h file.

Not necessary - included in .h file.

12:26 pm

Sean Nash

Please keep this case in last position in switch statement.

Please keep this case in last position in switch statement.

11:50 am

Sean Nash

Why commented out?

Why commented out?

10:41 am

Sean Nash

Remove comments or add TODO.

Remove comments or add TODO.

10:41 am

Sean Nash

I think we can remove this test code now.

I think we can remove this test code now.

Thursday 03 Jun 2021
10:36 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:36 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:36 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:35 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:35 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Tuesday 01 Jun 2021
9:52 am

Sean Nash

DEN-8030: Updated heater PWM limits for V3.

Options
    • -0
    • +6
    ./Heaters.c
Monday 31 May 2021
4:33 pm

Dara Navaei

DEN-8030 tested modes and continued developing chemical disinfect

Options
    • -2
    • +0
    ./Heaters.c
    • -6
    • +53
    ./TemperatureSensors.c
  3. … 13 more files in changeset.
Sunday 30 May 2021
2:46 pm

Dara Navaei

DG-DEN-8030_DG-HD DEV Mode Chemical Disinfect
DG-DEN-8030_DG-HD DEV Mode Chemical Disinfect
Saturday 29 May 2021
1:16 am

qnguyen  (deleted user)

Good point. The module has been moved to fwcommon.

Good point. The module has been moved to fwcommon.

1:16 am

qnguyen  (deleted user)

Removed the wrapper function. For now, only support one type of 32-bit CRC algorithm.

Removed the wrapper function. For now, only support one type of 32-bit CRC algorithm.

12:58 am

Quang Nguyen <qnguyen@diality.com>

DEN-8103: Moved integrity module to fwcommon

Options
    • -3
    • +3
    ./TemperatureSensors.c
  2. … 4 more files in changeset.
Friday 28 May 2021
4:39 pm

qnguyen  (deleted user)

Done.

Done.

4:33 pm

qnguyen  (deleted user)

Noe said they updated the ID and this is the new ID for DG FPGA. The FPGA test will fail without this change.

Noe said they updated the ID and this is the new ID for DG FPGA.
The FPGA test will fail without this change.

3:20 pm

Sean Nash

Should mention somewhere that timer is counting ms.

Should mention somewhere that timer is counting ms.

3:19 pm

Sean Nash

Why did this change?

Why did this change?

3:18 pm

Sean Nash

Is there a reason why this module isn't in fwcommon? And if it can't be common for some reason, should this module (or group name) be named DGIntegrity?

Is there a reason why this module isn't in fwcommon? And if it can't be common for some reason, should this module (or group name) be named DGIntegrity?

3:18 pm

Sean Nash

Do we need to support more than one 32-bit CRC algorithm in firmware? If not, do we need this wrapper function?

Do we need to support more than one 32-bit CRC algorithm in firmware? If not, do we need this wrapper function?