Activity dgfirmware/firmware/App/Controllers

Tree
Accordion

Stats

Commits this week: 0

Total Committers:	16
Last Commit:	19 Nov 25
Commits this week:	0

Lines of code count not available

Commit Activity

last updated a few seconds ago

Constraints

Constraints: committers

Committer:

Log Comment:

Constraints: files

File Extension:

File Name:

Constraints: dates

Start Date:

Start Date:

End Date:

End Date:

Wednesday 21 Jul 2021

2:29 pm

Quang Nguyen <qnguyen@diality.com>

More
c127dcd
changed 1 file
DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 208 more DG-DEN-7802-1

DEN-7802: Reduced tolerance on consecutive tare

- -9
- +10
./LoadCell.c
- History
- Source
- Diff
./LoadCell.c

Tuesday 20 Jul 2021

10:12 pm

Dara Navaei

More
DG-DEN-9054-1
started review

DG-DEN-9054_DG HD Switches

DG-DEN-9054_DG HD Switches

1:32 pm

Sean Nash

More
Re: DG-DEN-7802-1
commented on review

Why not alarm?

Why not alarm?

1:25 pm

Sean Nash

More
Re: DG-DEN-7802-1
commented on review

I think this is pretty clear, but for consistency, add a comment for this condition.

I think this is pretty clear, but for consistency, add a comment for this condition.

Monday 19 Jul 2021

4:27 pm

Quang Nguyen <qnguyen@diality.com>

More
5d82009
changed 10 files
DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 208 more DG-DEN-7802-1

DEN-7802: Implemented fill mode with new changes

- -30
- +29
./ConcentratePumps.c
- History
- Source
- Diff
./ConcentratePumps.c
- -0
- +1
./ConcentratePumps.h
- History
- Source
- Diff
./ConcentratePumps.h
- -18
- +0
./ConductivitySensors.c
- History
- Source
- Diff
./ConductivitySensors.c
- -2
- +0
./ConductivitySensors.h
- History
- Source
- Diff
./ConductivitySensors.h
- -1
- +1
./Heaters.c
- History
- Source
- Diff
./Heaters.c
… 5 more files in changeset.

Wednesday 14 Jul 2021

10:03 am

Dara Navaei

More
c016036
changed 34 files
DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 210 more DG-DEN-9054-1 DG-DEN-7802-1

DEN-9054 updated the code

- -5
- +124
./ConcentratePumps.c
- History
- Source
- Diff
./ConcentratePumps.c
- -0
- +6
./ConcentratePumps.h
- History
- Source
- Diff
./ConcentratePumps.h
- -3
- +1
./ConductivitySensors.c
- History
- Source
- Diff
./ConductivitySensors.c
- -4
- +2
./DrainPump.c
- History
- Source
- Diff
./DrainPump.c
- -103
- +26
./Fans.c
- History
- Source
- Diff
./Fans.c
- -91
- +197
./Heaters.c
- History
- Source
- Diff
./Heaters.c
- -20
- +25
./LoadCell.c
- History
- Source
- Diff
./LoadCell.c
- -4
- +2
./Pressures.c
- History
- Source
- Diff
./Pressures.c
- -15
- +4
./ROPump.c
- History
- Source
- Diff
./ROPump.c
- -97
- +103
./TemperatureSensors.c
- History
- Source
- Diff
./TemperatureSensors.c
- -90
- +22
./Thermistors.c
- History
- Source
- Diff
./Thermistors.c
- -1
- +1
./Voltages.h
- History
- Source
- Diff
./Voltages.h
… 22 more files in changeset.

Wednesday 07 Jul 2021

12:16 am

Quang Nguyen <qnguyen@diality.com>

More
89259a1
changed 3 files
DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 208 more DG-DEN-7802-1

DEN-7802: Added delay to valves state change

- -2
- +2
./LoadCell.c
- History
- Source
- Diff
./LoadCell.c
… 2 more files in changeset.

Saturday 03 Jul 2021

8:01 pm

pmontazemi (deleted user)

More
DG-DEN-7802-1
resumed reviewing

Friday 02 Jul 2021

9:15 am

Dara Navaei

More
df0a0b9
changed 14 files
DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 210 more DG-DEN-7802-1 DG-DEN-9054-1

DEN-9054 continued updating the POST to get the calibration values for the drivers

- -21
- +34
./ConductivitySensors.c
- History
- Source
- Diff
./ConductivitySensors.c
- -0
- +2
./ConductivitySensors.h
- History
- Source
- Diff
./ConductivitySensors.h
- -0
- +75
./DrainPump.c
- History
- Source
- Diff
./DrainPump.c
- -0
- +4
./DrainPump.h
- History
- Source
- Diff
./DrainPump.h
- -1
- +1
./Fans.c
- History
- Source
- Diff
./Fans.c
- -14
- +11
./LoadCell.c
- History
- Source
- Diff
./LoadCell.c
- -14
- +14
./Pressures.c
- History
- Source
- Diff
./Pressures.c
- -12
- +35
./ROPump.c
- History
- Source
- Diff
./ROPump.c
- -0
- +2
./ROPump.h
- History
- Source
- Diff
./ROPump.h
… 5 more files in changeset.

Thursday 01 Jul 2021

11:27 am

Sean Nash

More
Re: DG-DEN-7802-1
commented on review

I believe this will eventually be a constant in the non-volatile calibration record. So will have a getter function in NV-Data module for this value.

I believe this will eventually be a constant in the non-volatile calibration record. So will have a getter function in NV-Data module for this value.

Tuesday 29 Jun 2021

9:41 pm

Dara Navaei

More
58d631f
changed 9 files
develop_1-24

Merged DEN-9054 and resolved merge conflicts

- -7
- +97
./ConductivitySensors.c
- History
- Source
- Diff
./ConductivitySensors.c
- -18
- +21
./LoadCell.c
- History
- Source
- Diff
./LoadCell.c
- -111
- +191
./Pressures.c
- History
- Source
- Diff
./Pressures.c
- -38
- +112
./ROPump.c
- History
- Source
- Diff
./ROPump.c
… 5 more files in changeset.

9:21 pm

Dara Navaei

More
6f1f269
changed 13 files
DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 211 more DG-DEN-9054-1

DEN-9054 updated some of the drivers with calibration code

- -7
- +97
./ConductivitySensors.c
- History
- Source
- Diff
./ConductivitySensors.c
- -5
- +7
./DrainPump.c
- History
- Source
- Diff
./DrainPump.c
- -18
- +21
./LoadCell.c
- History
- Source
- Diff
./LoadCell.c
- -111
- +191
./Pressures.c
- History
- Source
- Diff
./Pressures.c
- -38
- +112
./ROPump.c
- History
- Source
- Diff
./ROPump.c
… 8 more files in changeset.

6:24 pm

Sean Nash

More
6190a4a
changed 18 files
develop_1-24

Fixed merge conflicts.

- -2
- +0
./Heaters.h
- History
- Source
- Diff
./Heaters.h
- -2
- +2
./LoadCell.c
- History
- Source
- Diff
./LoadCell.c
- -4
- +59
./TemperatureSensors.c
- History
- Source
- Diff
./TemperatureSensors.c
… 15 more files in changeset.

Saturday 26 Jun 2021

1:14 am

qnguyen (deleted user)

More
Re: DG-DEN-7802-1
replied to Sean Nash

Fixed.

Fixed.

1:14 am

qnguyen (deleted user)

More
Re: DG-DEN-7802-1
replied to Sean Nash

Fixed.

Fixed.

1:08 am

Quang Nguyen <qnguyen@diality.com>

More
4b15ae8
changed 4 files
DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 208 more DG-DEN-7802-1

DEN-7802: Refactor conductivity checks

- -35
- +5
./ConductivitySensors.c
- History
- Source
- Diff
./ConductivitySensors.c
- -2
- +0
./ConductivitySensors.h
- History
- Source
- Diff
./ConductivitySensors.h
- -2
- +0
./UVReactors.c
- History
- Source
- Diff
./UVReactors.c
… 1 more file in changeset.

12:58 am

Quang Nguyen <qnguyen@diality.com>

More
037f0ed
changed 12 files
DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 208 more DG-DEN-7802-1

Merge branch 'staging' into DEN-7802-dg_dev-dialysate-generation

- -1
- +1
./ConductivitySensors.c
- History
- Source
- Diff
./ConductivitySensors.c
- -215
- +87
./Heaters.c
- History
- Source
- Diff
./Heaters.c
- -2
- +2
./Heaters.h
- History
- Source
- Diff
./Heaters.h
- -34
- +74
./ROPump.c
- History
- Source
- Diff
./ROPump.c
- -41
- +122
./TemperatureSensors.c
- History
- Source
- Diff
./TemperatureSensors.c
- -36
- +41
./UVReactors.c
- History
- Source
- Diff
./UVReactors.c
… 6 more files in changeset.

Friday 25 Jun 2021

4:45 pm

qnguyen (deleted user)

More
DG-DEN-8103-1
Closed

2:11 pm

Dara Navaei and pmontazemi (deleted user)

More
DG-DEN-8103-1
finished reviewing

11:28 am

Quang Nguyen <qnguyen@diality.com>

More
8b0c842
changed 4 files
DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 211 more DG-DEN-7802-1 DG-DEN-8103-1 DG-DEN-9054-1

DEN-8103: Fixed build errors

- -12
- +30
./Heaters.c
- History
- Source
- Diff
./Heaters.c
… 3 more files in changeset.

11:01 am

Quang Nguyen <qnguyen@diality.com>

More
2fff37f
changed 15 files
DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 211 more DG-DEN-8103-1 DG-DEN-7802-1 DG-DEN-9054-1

Merge branch 'staging' into DEN-8103-dg-hd_dev-alarm-design

- -201
- +79
./Heaters.c
- History
- Source
- Diff
./Heaters.c
- -23
- +49
./LoadCell.c
- History
- Source
- Diff
./LoadCell.c
- -30
- +38
./UVReactors.c
- History
- Source
- Diff
./UVReactors.c
… 12 more files in changeset.

Tuesday 22 Jun 2021

10:52 am

Dara Navaei

More
DG-DEN-8030-1
Closed

Monday 21 Jun 2021

10:38 am

qnguyen (deleted user)

More
Re: DG-DEN-8030-1
replied to Dara Navaei

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:13 am

Dara Navaei

More
81cd7f8
changed 4 files
DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 213 more DG-DEN-8103-1 DG-DEN-8030-1

DEN-8030 adderessed a code review comment

- -1
- +0
./Heaters.c
- History
- Source
- Diff
./Heaters.c
- -22
- +0
./ROPump.c
- History
- Source
- Diff
./ROPump.c
- -2
- +0
./ROPump.h
- History
- Source
- Diff
./ROPump.h
… 1 more file in changeset.

10:12 am

Dara Navaei

More
Re: DG-DEN-8030-1
replied to qnguyen (deleted user)

This a matter of trying the temperature sensors more than once before we start the cycle. Making the wait time longer will not necessarily help the sensors to read within the range.

This a matter of trying the temperature sensors more than once before we start the cycle. Making the wait time longer will not necessarily help the sensors to read within the range.

Thursday 17 Jun 2021

10:59 am

qnguyen (deleted user)

More
Re: DG-DEN-8030-1
replied to Dara Navaei

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:57 am

qnguyen (deleted user)

More
Re: DG-DEN-8030-1
replied to Dara Navaei

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:57 am

qnguyen (deleted user)

More
Re: DG-DEN-8030-1
replied to Dara Navaei

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:56 am

qnguyen (deleted user)

More
Re: DG-DEN-8030-1
replied to Dara Navaei

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:55 am

qnguyen (deleted user)

More
Re: DG-DEN-8030-1
replied to Dara Navaei

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Atlassian Fisheye Git analysis with Crucible code review. (Version:4.8.14 Build:20240111091859 2024-01-11 09:20) - Administration - Page generated 2026-04-03 10:17 -0700