Controllers

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Added back alarm.

Added back alarm.

Done.

Done.

Done.

Done.

Done.

Done.

Done.

Done.

VSP is never open until this state is done. The endSampleWaterRequest is for the user presses the stop button during the filter flush and end treatment, allowing DG to go back to standby idle state.

VSP is never open until this state is done.
The endSampleWaterRequest is for the user presses the stop button during the filter flush and end treatment, allowing DG to go back to standby idle state.

We have to flush the filter flush before user can request to sample water.

We have to flush the filter flush before user can request to sample water.

VSP should only be on when user requests to sample water.

VSP should only be on when user requests to sample water.

In DG standby mode, DG will transition to solo mode.

In DG standby mode, DG will transition to solo mode.

Why is there a magic number here?

Why is there a magic number here?

Add the doxygen comment.

Add the doxygen comment.

fushLinesVolumeL is an input.

fushLinesVolumeL is an input.

If HD is not communicating, should we got transition to standby solo mode?

If HD is not communicating, should we got transition to standby solo mode?

Input: startSampleWaterRequest, endSampleWaterRequest.

Input: startSampleWaterRequest, endSampleWaterRequest.

Output: startSampleWaterRequest, endSampleWaterRequest, waterSampleStartTime.

Output: startSampleWaterRequest, endSampleWaterRequest, waterSampleStartTime.

This should be flush filter idle state.

This should be flush filter idle state.

Why there is a endSampleWaterRequest in this state? We should never get here if sample water request is in place. Also, if this an endSampleWaterRequest here, VSP should be closed.

Why there is a endSampleWaterRequest in this state? We should never get here if sample water request is in place.
Also, if this an endSampleWaterRequest here, VSP should be closed.

Should we turn on VSP?

Should we turn on VSP?

Are we supposed to switch to water sample state? This does not go to water sample state.

Are we supposed to switch to water sample state? This does not go to water sample state.

The getter from non-volatile module is in my branch.

The getter from non-volatile module is in my branch.

DG-DEN-9054_DG HD Switches
DG-DEN-9054_DG HD Switches
Why not alarm?

Why not alarm?

I think this is pretty clear, but for consistency, add a comment for this condition.

I think this is pretty clear, but for consistency, add a comment for this condition.

I believe this will eventually be a constant in the non-volatile calibration record. So will have a getter function in NV-Data module for this value.

I believe this will eventually be a constant in the non-volatile calibration record. So will have a getter function in NV-Data module for this value.

Fixed.

Fixed.

Fixed.

Fixed.