dgfirmware / firmware / App

Controllers

Clone Tools

Stats

Commits this week: 0
Total Committers: 16
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 09 Nov 2021
8:51 pm

Dara Navaei

DEN-9480 addressed the code review comments

Options
    • -10
    • +8
    ./DrainPump.c
    • -6
    • +6
    ./Fans.c
    • -2
    • +2
    ./FluidLeak.c
    • -8
    • +7
    ./Heaters.c
    • -5
    • +2
    ./Heaters.h
    • -2
    • +7
    ./ROPump.c
  7. … 3 more files in changeset.
8:25 pm

Dara Navaei

I added an else to FALSE the persistent alarm.

I added an else to FALSE the persistent alarm.

8:17 pm

Dara Navaei

Done.

Done.

8:16 pm

Dara Navaei

Done.

Done.

8:13 pm

Dara Navaei

Done.

Done.

8:12 pm

Dara Navaei

Done.

Done.

8:09 pm

Dara Navaei

Done.

Done.

8:08 pm

Dara Navaei

Done.

Done.

4:45 pm

Sean Nash

That if has an extra condition (beyond pump is not on). So alarm persistence is only reset if other condition is met. If other condition is not met, persistence is left in limbo.

That if has an extra condition (beyond pump is not on). So alarm persistence is only reset if other condition is met. If other condition is not met, persistence is left in limbo.

4:22 pm

Dara Navaei

Done.

Done.

4:10 pm

Dara Navaei

I removed it.

I removed it.

4:09 pm

Dara Navaei

Done.

Done.

4:08 pm

Dara Navaei

Done.

Done.

4:06 pm

Dara Navaei

If we are in a non-heating mode, the heaters do not need to be on and we should not be in this state.

If we are in a non-heating mode, the heaters do not need to be on and we should not be in this state.

4:03 pm

Dara Navaei

This part is under development and I have been working on the happy path of the heaters. I added a build switch for now.

This part is under development and I have been working on the happy path of the heaters. I added a build switch for now.

4:01 pm

Dara Navaei

This is heaters monitor. This code is not going to be removed but I have commented it to disable any monitoring while the heaters are being monitored. I added a build switch for it.

This is heaters monitor. This code is not going to be removed but I have commented it to disable any monitoring while the heaters are being monitored. I added a build switch for it.

4:00 pm

Dara Navaei

Done.

Done.

3:59 pm

Dara Navaei

I removed it.

I removed it.

3:58 pm

Dara Navaei

Done.

Done.

3:57 pm

Dara Navaei

I uncommented it.

I uncommented it.

3:56 pm

Dara Navaei

If the pump is not on, the monitor checks the voltage to make sure it is reading 0. That code is a couple of lines above.

If the pump is not on, the monitor checks the voltage to make sure it is reading 0. That code is a couple of lines above.

3:54 pm

Dara Navaei

No, the voltage is monitored in the RO pump module.

No, the voltage is monitored in the RO pump module.

3:53 pm

Dara Navaei

This function is no longer needed.

This function is no longer needed.

3:51 pm

Dara Navaei

Can this be optimized later?

Can this be optimized later?

2:30 pm

hnguyen  (deleted user)

In @details Inputs and Outputs, replace heatersVoltageMonitorTimeCounter with voltageMonitorTimeCounter.

In @details Inputs and Outputs, replace heatersVoltageMonitorTimeCounter with voltageMonitorTimeCounter.

2:20 pm

hnguyen  (deleted user)

Add fansStatus to @details Inputs, since it is read at line 593

Add fansStatus to @details Inputs, since it is read at line 593

2:17 pm

hnguyen  (deleted user)

In @details Inputs and Outputs, change dataPublishCounter to fansPublishCounter

In @details Inputs and Outputs, change dataPublishCounter to fansPublishCounter

2:00 pm

hnguyen  (deleted user)

In @details Outputs, remove "fansStatus" because I don't think we count the local variables as outputs

In @details Outputs, remove "fansStatus" because I don't think we count the local variables as outputs

1:44 pm

hnguyen  (deleted user)

drainPumpDAC on line 611 should be added to @detail inputs?

drainPumpDAC on line 611 should be added to @detail inputs?

1:38 pm

hnguyen  (deleted user)

In @detail outputs, add signalNewRPMRequest

In @detail outputs, add signalNewRPMRequest