dgfirmware / firmware / App

Controllers

Clone Tools

Stats

Commits this week: 0
Total Committers: 16
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 07 Mar 2022
3:50 pm

Hung Nguyen <hnguyen@diality.com>

DEN-11928 Updated code per peer reviews comments

Options
    • -4
    • +3
    ./ConductivitySensors.c
    • -4
    • +4
    ./TemperatureSensors.c
  3. … 2 more files in changeset.
11:23 am

hnguyen  (deleted user)

set the RO pump rate to setROPumpTargetFlowRateLPM( getTargetFillFlowRateLPM(), TARGET_RO_PRESSURE_PSI );

set the RO pump rate to
setROPumpTargetFlowRateLPM( getTargetFillFlowRateLPM(), TARGET_RO_PRESSURE_PSI );

11:19 am

hnguyen  (deleted user)

Updated code to check for the difference in percent of conductivity between CD1 and CD2 and make sure it is < 5% otherwise alarm.

Updated code to check for the difference in percent of conductivity between CD1 and CD2 and make sure it is < 5% otherwise alarm.

11:19 am

hnguyen  (deleted user)

Updated code to check for the difference in percent of conductivity between CD1 and CD2 and make sure it is < 5% otherwise alarm.

Updated code to check for the difference in percent of conductivity between CD1 and CD2 and make sure it is < 5% otherwise alarm.

10:34 am

hnguyen  (deleted user)

Uncommented and recompiled without errors

Uncommented and recompiled without errors

Friday 04 Mar 2022
2:37 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

2:36 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

2:35 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

2:35 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

2:35 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

2:35 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

2:34 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

2:34 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

2:34 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

2:33 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

2:33 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

2:32 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

2:30 pm

Sean Nash

Alarm is recoverable. Should go to fill paused state. Paused state should go back to this test inlet water quality state when alarm acknowledged.

Alarm is recoverable. Should go to fill paused state. Paused state should go back to this test inlet water quality state when alarm acknowledged.

2:24 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

2:22 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

2:21 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

2:21 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

2:19 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

2:18 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

2:18 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

2:12 pm

hnguyen  (deleted user)

Added ALARM_ID_INLET_WATER_HIGH_CONDUCTIVITY to AlarmDefs.h Uncommented initPersistentAlarm(ALARM_ID_INLET_WATER_HIGH_CONDUCTIVITY

Added ALARM_ID_INLET_WATER_HIGH_CONDUCTIVITY to AlarmDefs.h
Uncommented initPersistentAlarm(ALARM_ID_INLET_WATER_HIGH_CONDUCTIVITY

2:07 pm

Sean Nash

Let's review requirement - may be obsolete.

Let's review requirement - may be obsolete.

2:04 pm

Sean Nash

Let's review that requirement - may be obsolete.

Let's review that requirement - may be obsolete.

2:04 pm

Sean Nash

But is it set to correct rate for product/delivery? Check with Dara. Produce/delivery rate should be set by HD I think, so may not be same as set in previous state.

But is it set to correct rate for product/delivery? Check with Dara. Produce/delivery rate should be set by HD I think, so may not be same as set in previous state.

2:02 pm

Sean Nash

Is ACID_TEST_CD2_TCD the right reference value for this check? Should we even be using the isValueWithinPercentRange function here? I think averageConductivity is already a percentage so you can ju...

Is ACID_TEST_CD2_TCD the right reference value for this check? Should we even be using the isValueWithinPercentRange function here?
I think averageConductivity is already a percentage so you can just see if it's less than 5%.