dgfirmware / firmware / App

Controllers

Clone Tools

Stats

Commits this week: 0
Total Committers: 16
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 06 Jul 2022
9:52 pm

Dara Navaei

DEN-12931 updated the drviers with DVT changes

Options
    • -76
    • +92
    ./ConcentratePumps.c
    • -2
    • +2
    ./ConcentratePumps.h
    • -53
    • +120
    ./ConductivitySensors.c
    • -6
    • +6
    ./DialysateFlow.c
    • -29
    • +35
    ./Heaters.c
    • -5
    • +5
    ./LoadCell.c
    • -2
    • +0
    ./Pressures.c
    • -166
    • +111
    ./TemperatureSensors.c
  9. … 10 more files in changeset.
7:46 pm

Dara Navaei

Fixed temperatureSensors driver with the newest faults

Options
    • -4
    • +4
    ./TemperatureSensors.c
10:54 am

wbracken  (deleted user)

That would also require a change to the requirements.

That would also require a change to the requirements.

Friday 01 Jul 2022
10:35 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:34 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:34 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:34 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:34 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:34 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Thursday 30 Jun 2022
10:09 am

Dara Navaei

Tuesday 28 Jun 2022
3:48 pm

Darren Cox <darren_m@cox.net>

DEN-12847 Code review comments update.

Options
    • -3
    • +0
    ./LoadCell.c
3:44 pm

dcox  (deleted user)

Alarm is not a fault. Updated clear immediate to false in AlarmDefs.h in Staging.

Alarm is not a fault. Updated clear immediate to false in AlarmDefs.h in Staging.

3:43 pm

dcox  (deleted user)

10-20 seems like a better number, but my sample size is small so I did not change it.

10-20 seems like a better number, but my sample size is small so I did not change it.

3:42 pm

dcox  (deleted user)

Updated

Updated

3:41 pm

dcox  (deleted user)

Updated

Updated

2:32 pm

Darren Cox <darren_m@cox.net>

DEN-12847 Code review comments update.

Options
    • -7
    • +10
    ./LoadCell.c
2:10 pm

Bill Bracken <bill@criticalsoftwaresolutions.com>

DEN-12974 Code review updates

Options
    • -1
    • +1
    ./ConductivitySensors.c
    • -1
    • +0
    ./ROPump.c
11:01 am

wbracken  (deleted user)

Seems like isADCValid should be returned.

Seems like isADCValid should be returned.

11:00 am

Dara Navaei

This will be addressed in DEN-12931.

This will be addressed in DEN-12931.

11:00 am

Dara Navaei

This will be addressed in DEN-12931.

This will be addressed in DEN-12931.

11:00 am

Dara Navaei

This will be addressed in DEN-12931.

This will be addressed in DEN-12931.

11:00 am

Dara Navaei

This will be addressed in DEN-12931.

This will be addressed in DEN-12931.

11:00 am

Dara Navaei

This will be addressed in DEN-12931.

This will be addressed in DEN-12931.

11:00 am

Dara Navaei

This will be addressed in DEN-12931.

This will be addressed in DEN-12931.

10:41 am

wbracken  (deleted user)

Removed blank line

Removed blank line

10:38 am

wbracken  (deleted user)

Will add back in.

Will add back in.

9:27 am

Sean Nash

Are we sticking with this threshold?

Are we sticking with this threshold?

9:26 am

Sean Nash

Need to address TODOs. Have we assessed what an appropriate max delta should be? Alarm should be cleared if it is recoverable (not a fault) and not cleared immediately (see alarm properties).

Need to address TODOs. Have we assessed what an appropriate max delta should be? Alarm should be cleared if it is recoverable (not a fault) and not cleared immediately (see alarm properties).

9:24 am

Sean Nash

Make this assignment explicitly BOOL (i.e. TRUE or FALSE), not implied bool.

Make this assignment explicitly BOOL (i.e. TRUE or FALSE), not implied bool.

9:23 am

Sean Nash

Use our boolean #define (FALSE) instead of built-in (false).

Use our boolean #define (FALSE) instead of built-in (false).