Activity dgfirmware/firmware/App/Controllers

1:16 pm

Dara Navaei

More
5c8f6d4
changed 2 files
DEN-12931-dg_hd_dev-hd_dg_dvt-update, DEN-12974-miscellaneous-flush-issues_bb and 196 more DG-DEN-12931-1

DEN-12931 updated the conductivity sensors' driver

- -58
- +68
./ConductivitySensors.c
- History
- Source
- Diff
./ConductivitySensors.c
- -1
- +0
./ConductivitySensors.h
- History
- Source
- Diff
./ConductivitySensors.h

8:56 pm

Dara Navaei

More
0d94694
changed 3 files
DEN-12931-dg_hd_dev-hd_dg_dvt-update, DEN-12974-miscellaneous-flush-issues_bb and 196 more DG-DEN-12931-1

DEN-12931 updated the conductivity sensors driver

- -20
- +196
./ConductivitySensors.c
- History
- Source
- Diff
./ConductivitySensors.c
… 2 more files in changeset.

7:05 am

Dara Navaei

More
DG-DEN-12931-1
started review

DG-DEN-12931_DG HD Dev HD DG Dvt Update

9:52 pm

Dara Navaei

More
224b86c
changed 18 files
DEN-12931-dg_hd_dev-hd_dg_dvt-update, DEN-12974-miscellaneous-flush-issues_bb and 196 more DG-DEN-12931-1

DEN-12931 updated the drviers with DVT changes

- -76
- +92
./ConcentratePumps.c
- History
- Source
- Diff
./ConcentratePumps.c
- -2
- +2
./ConcentratePumps.h
- History
- Source
- Diff
./ConcentratePumps.h
- -53
- +120
./ConductivitySensors.c
- History
- Source
- Diff
./ConductivitySensors.c
- -6
- +6
./DialysateFlow.c
- History
- Source
- Diff
./DialysateFlow.c
- -29
- +35
./Heaters.c
- History
- Source
- Diff
./Heaters.c
- -5
- +5
./LoadCell.c
- History
- Source
- Diff
./LoadCell.c
- -2
- +0
./Pressures.c
- History
- Source
- Diff
./Pressures.c
- -166
- +111
./TemperatureSensors.c
- History
- Source
- Diff
./TemperatureSensors.c
… 10 more files in changeset.

7:46 pm

Dara Navaei

More
421cae0
changed 1 file
DEN-14902-bootloader-for-dg, cdc-demo-branch-218 and 3 more

Fixed temperatureSensors driver with the newest faults

- -4
- +4
./TemperatureSensors.c
- History
- Source
- Diff
./TemperatureSensors.c

10:54 am

wbracken (deleted user)

More
Re: DG-DEN-12974-1
commented on review

That would also require a change to the requirements.

10:35 am

Sean Nash

More
Re: DG-DEN-12847-1
replied to Sean Nash

RESOLVED in CODE WALKTHROUGH.

10:34 am

Sean Nash

More
Re: DG-DEN-12847-1
replied to Sean Nash

RESOLVED in CODE WALKTHROUGH.

10:34 am

Sean Nash

More
Re: DG-DEN-12847-1
replied to dcox (deleted user)

RESOLVED in CODE WALKTHROUGH.

10:34 am

Sean Nash

More
Re: DG-DEN-12847-1
replied to dcox (deleted user)

RESOLVED in CODE WALKTHROUGH.

10:34 am

Sean Nash

More
Re: DG-DEN-12847-1
replied to dcox (deleted user)

RESOLVED in CODE WALKTHROUGH.

10:34 am

Sean Nash

More
Re: DG-DEN-12847-1
replied to dcox (deleted user)

RESOLVED in CODE WALKTHROUGH.

10:09 am

Dara Navaei

More
DG-DEN-12847-1
added wbracken (deleted user)

3:48 pm

Darren Cox <darren_m@cox.net>

More
3d0292d
changed 1 file
DEN-12847-sw_dev_sprint_71_darren, DEN-12931-dg_hd_dev-hd_dg_dvt-update and 197 more DG-DEN-12847-1

DEN-12847 Code review comments update.

- -3
- +0
./LoadCell.c
- History
- Source
- Diff
./LoadCell.c

3:44 pm

dcox (deleted user)

More
Re: DG-DEN-12847-1
replied to Sean Nash

Alarm is not a fault. Updated clear immediate to false in AlarmDefs.h in Staging.

3:43 pm

dcox (deleted user)

More
Re: DG-DEN-12847-1
replied to Sean Nash

10-20 seems like a better number, but my sample size is small so I did not change it.

3:42 pm

dcox (deleted user)

More
Re: DG-DEN-12847-1
replied to Sean Nash

Updated

3:41 pm

dcox (deleted user)

More
Re: DG-DEN-12847-1
replied to Sean Nash

Updated

2:32 pm

Darren Cox <darren_m@cox.net>

More
c119b9e
changed 1 file
DEN-12847-sw_dev_sprint_71_darren, DEN-12931-dg_hd_dev-hd_dg_dvt-update and 197 more DG-DEN-12847-1

DEN-12847 Code review comments update.

- -7
- +10
./LoadCell.c
- History
- Source
- Diff
./LoadCell.c

2:10 pm

Bill Bracken <bill@criticalsoftwaresolutions.com>

More
70f88b1
changed 2 files
DEN-12974-miscellaneous-flush-issues_bb, DEN-13050-vpi-does-not-close-after-sample-water-returns-to-flush-idle and 195 more DG-DEN-12974-1

DEN-12974 Code review updates

- -1
- +1
./ConductivitySensors.c
- History
- Source
- Diff
./ConductivitySensors.c
- -1
- +0
./ROPump.c
- History
- Source
- Diff
./ROPump.c

11:01 am

wbracken (deleted user)

More
Re: DG-DEN-12974-1
replied to Sean Nash

Seems like isADCValid should be returned.

11:00 am