dgfirmware / firmware / App

Controllers

Clone Tools

Stats

Commits this week: 4
Total Committers: 16
Last Commit: 10 Jun
Commits this week: 4

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 24 Oct 2022
1:28 pm

Bill Bracken <bill@criticalsoftwaresolutions.com>

Merge branch 'staging' into DEN-13786-hd_dg_dev-s78_bb

# Conflicts:

# firmware/App/Controllers/DialysateFlow.c

# firmware/App/Controllers/Heaters.c

# firmware/App/Controllers/ROPump.c

# firmware/App/Controllers/UVReactors.c

# firmware/App/Modes/ModeHeatDisinfect.c

Options
    • -16
    • +16
    ./ROPump.c
    • -186
    • +91
    ./TemperatureSensors.c
  3. … 1 more file in changeset.
11:05 am

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -2
    • +2
    ./Pressures.c
  2. … 1 more file in changeset.
11:02 am

Sean Nash

Why is RTC POST disabled?

Why is RTC POST disabled?

11:02 am

Sean Nash

Remove extra blank line.

Remove extra blank line.

11:01 am

Sean Nash

Use BOOL. And add a blank line after. And make following condition explicit (i.e. != TRUE).

Use BOOL. And add a blank line after. And make following condition explicit (i.e. != TRUE).

10:59 am

Dara Navaei

10:58 am

Sean Nash

Is this dead code? Can we remove?

Is this dead code? Can we remove?

10:57 am

Sean Nash

Remove blank line.

Remove blank line.

10:55 am

Sean Nash

Remove blank line.

Remove blank line.

10:53 am

Sean Nash

Alphabetize (move toward top of includes).

Alphabetize (move toward top of includes).

10:53 am

Sean Nash

Alphabetize (move toward top of includes).

Alphabetize (move toward top of includes).

10:52 am

Sean Nash

Alphabetize - move toward top of includes.

Alphabetize - move toward top of includes.

10:51 am

Sean Nash

Magic #?

Magic #?

10:48 am

Sean Nash

Is 30 sec permanent? If not, add TODO to revisit after RO control optimization is completed.

Is 30 sec permanent? If not, add TODO to revisit after RO control optimization is completed.

10:46 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:45 am

Dara Navaei

In V3, when TRo is requested, the firmware send the value of TDi.

In V3, when TRo is requested, the firmware send the value of TDi.

10:43 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:42 am

Dara Navaei

This is not a software fault. This has been addressed in DEN-14166.

This is not a software fault. This has been addressed in DEN-14166.

10:42 am

Sean Nash

Should use of TRo here be for DVT (if V3 s/w config, continue to use TDi)?

Should use of TRo here be for DVT (if V3 s/w config, continue to use TDi)?

10:40 am

Sean Nash

Can we do s/w fault now?

Can we do s/w fault now?

10:36 am

Sean Nash

Remove comment.

Remove comment.

8:30 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Sunday 23 Oct 2022
9:44 pm

Bill Bracken <bill@criticalsoftwaresolutions.com>

DEN-13768 Remove EMC build from ROPump. Don not set cancellationMode when exiting DG_HEAT_DISINFECT_STATE_COOL_DOWN_RO_FILTER.

Options
    • -3
    • +0
    ./ROPump.c
  2. … 1 more file in changeset.
Friday 21 Oct 2022
5:03 pm

Dara Navaei

Merged DEN-14166

Options
    • -8
    • +20
    ./LoadCell.c
    • -3
    • +3
    ./TemperatureSensors.c
  3. … 2 more files in changeset.
5:01 pm

Dara Navaei

DEN-14166 fixed the drain pump's direction check alarm

Options
    • -2
    • +2
    ./DrainPump.c
4:44 pm

Dara Navaei

DEN-14166 fixed the drain pump's direction alarm check and updated the heat disinfect caps check

Options
    • -2
    • +2
    ./DrainPump.c
  2. … 1 more file in changeset.
4:00 pm

wbracken  (deleted user) and Sean Nash

3:35 pm

Dara Navaei

DEN-14166 added DVT FPGA thermistors, addressed the code review comment and added load cells sign extension

Options
    • -1
    • +15
    ./DrainPump.c
    • -8
    • +20
    ./LoadCell.c
    • -9
    • +24
    ./Pressures.c
    • -3
    • +3
    ./TemperatureSensors.c
    • -2
    • +8
    ./Thermistors.c
  6. … 4 more files in changeset.
3:34 pm

Dara Navaei

Done.

Done.

Thursday 20 Oct 2022
8:59 pm

Dara Navaei

DG-DEN-13786_HD DG Dev S78 BB
DG-DEN-13786_HD DG Dev S78 BB