dgfirmware / firmware / App

Controllers

Clone Tools

Stats

Commits this week: 0
Total Committers: 16
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 24 Oct 2022
2:48 pm

Bill Bracken <bill@criticalsoftwaresolutions.com>

DEN-13786 Code review changes

Options
    • -1
    • +1
    ./ROPump.c
    • -1
    • +2
    ./TemperatureSensors.c
  3. … 3 more files in changeset.
2:43 pm

wbracken  (deleted user)

Removed.

Removed.

2:40 pm

wbracken  (deleted user)

This file has been removed.

This file has been removed.

2:37 pm

wbracken  (deleted user)

Add TODO to comment.

Add TODO to comment.

2:36 pm

wbracken  (deleted user)

Done.

Done.

2:35 pm

Dara Navaei

This function has been refactored.

This function has been refactored.

2:30 pm

Dara Navaei

This file has been deleted.

This file has been deleted.

2:27 pm

wbracken  (deleted user)

Moved.

Moved.

2:26 pm

wbracken  (deleted user)

Moved.

Moved.

2:24 pm

wbracken  (deleted user)

Moved.

Moved.

2:24 pm

Dara Navaei

Merged staging

Options
    • -2
    • +2
    ./Pressures.c
2:23 pm

wbracken  (deleted user)

Removed.

Removed.

2:22 pm

wbracken  (deleted user)

Removed.

Removed.

2:16 pm

wbracken  (deleted user)

Removed

Removed

2:07 pm

wbracken  (deleted user)

Change was made to get around earlier issues. Need discussion on whether or not to change back.

Change was made to get around earlier issues. Need discussion on whether or not to change back.

1:43 pm

Dara Navaei

This build switch has been removed.

This build switch has been removed.

1:28 pm

Bill Bracken <bill@criticalsoftwaresolutions.com>

Merge branch 'staging' into DEN-13786-hd_dg_dev-s78_bb

# Conflicts:

# firmware/App/Controllers/DialysateFlow.c

# firmware/App/Controllers/Heaters.c

# firmware/App/Controllers/ROPump.c

# firmware/App/Controllers/UVReactors.c

# firmware/App/Modes/ModeHeatDisinfect.c

Options
    • -16
    • +16
    ./ROPump.c
    • -186
    • +91
    ./TemperatureSensors.c
  3. … 1 more file in changeset.
11:05 am

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -2
    • +2
    ./Pressures.c
  2. … 1 more file in changeset.
11:02 am

Sean Nash

Why is RTC POST disabled?

Why is RTC POST disabled?

11:02 am

Sean Nash

Remove extra blank line.

Remove extra blank line.

11:01 am

Sean Nash

Use BOOL. And add a blank line after. And make following condition explicit (i.e. != TRUE).

Use BOOL. And add a blank line after. And make following condition explicit (i.e. != TRUE).

10:59 am

Dara Navaei

10:58 am

Sean Nash

Is this dead code? Can we remove?

Is this dead code? Can we remove?

10:57 am

Sean Nash

Remove blank line.

Remove blank line.

10:55 am

Sean Nash

Remove blank line.

Remove blank line.

10:53 am

Sean Nash

Alphabetize (move toward top of includes).

Alphabetize (move toward top of includes).

10:53 am

Sean Nash

Alphabetize (move toward top of includes).

Alphabetize (move toward top of includes).

10:52 am

Sean Nash

Alphabetize - move toward top of includes.

Alphabetize - move toward top of includes.

10:51 am

Sean Nash

Magic #?

Magic #?

10:48 am

Sean Nash

Is 30 sec permanent? If not, add TODO to revisit after RO control optimization is completed.

Is 30 sec permanent? If not, add TODO to revisit after RO control optimization is completed.