Activity dgfirmware/firmware/App/Controllers

DEN-14197: implemented RO pump profile switching. Implemented Flow to PWM function RO pump with profiles as a parameter. Created a SW fault for PI profiles out of range.

- -38
- +87
./ROPump.c
- History
- Source
- Diff
./ROPump.c
- -0
- +14
./ROPump.h
- History
- Source
- Diff
./ROPump.h
… 3 more files in changeset.

11:39 am

Michael Garthwaite

More
7104ce1
changed 3 files
DEN-13050-vpi-does-not-close-after-sample-water-returns-to-flush-idle, DEN-13154-heparin-syringe-empty-position-incorrect and 180 more DG-UCOMMITS-37

DEN-14197: Initial attempt at PI controller profiles with usage in ro pump

- -0
- +38
./ROPump.c
- History
- Source
- Diff
./ROPump.c
… 2 more files in changeset.

3:56 pm

Dara Navaei

Merge branch 'DEN-14175-dg_hd_dev-hd_dg_dvt-update-part-5' into develop

- -4
- +5
./ConcentratePumps.c
- History
- Source
- Diff
./ConcentratePumps.c
- -1
- +1
./ConductivitySensors.c
- History
- Source
- Diff
./ConductivitySensors.c
- -11
- +35
./Heaters.c
- History
- Source
- Diff
./Heaters.c
… 1 more file in changeset.

3:53 pm

Dara Navaei

More
8e0041d
changed 1 file
DEN-13050-vpi-does-not-close-after-sample-water-returns-to-flush-idle, DEN-13154-heparin-syringe-empty-position-incorrect and 183 more DG-DEN-14175-1

DEN-14175 added trimmer heater use last duty cycle to the broadcast data

- -4
- +5
./Heaters.c
- History
- Source
- Diff
./Heaters.c

10:37 am

wbracken (deleted user)

RESOLVED IN CODE WALKTHROUGH

10:32 am

wbracken (deleted user)

RESOLVED IN CODE WALKTHROUGH

10:29 am

wbracken (deleted user)

RESOLVED IN CODE WALKTHROUGH

10:03 am

Dara Navaei

More
6f29912
changed 17 files
DEN-13050-vpi-does-not-close-after-sample-water-returns-to-flush-idle, DEN-13154-heparin-syringe-empty-position-incorrect and 183 more DG-DEN-14175-1

DEN-14175 addressed the code review comments and replaced the V3 enable software configuration flag with the hardware configuration flag from FGPA. Updated the trimmer heater's ramp state to check the use previous duty cycle flag instead of estimating the duty cycle.

- -4
- +5
./ConcentratePumps.c
- History
- Source
- Diff
./ConcentratePumps.c
- -1
- +1
./ConductivitySensors.c
- History
- Source
- Diff
./ConductivitySensors.c
- -5
- +6
./DrainPump.c
- History
- Source
- Diff
./DrainPump.c
- -1
- +1
./Fans.c
- History
- Source
- Diff
./Fans.c
- -7
- +30
./Heaters.c
- History
- Source
- Diff
./Heaters.c
- -0
- +2
./Heaters.h
- History
- Source
- Diff
./Heaters.h
- -9
- +7
./Pressures.c
- History
- Source
- Diff
./Pressures.c
- -1
- +2
./ROPump.c
- History
- Source
- Diff
./ROPump.c
- -9
- +5
./TemperatureSensors.c
- History
- Source
- Diff
./TemperatureSensors.c
- -1
- +2
./Thermistors.c
- History
- Source
- Diff
./Thermistors.c
- -9
- +71
./Valves.c
- History
- Source
- Diff
./Valves.c
- -1
- +3
./Valves.h
- History
- Source
- Diff
./Valves.h
… 5 more files in changeset.

9:57 am

Dara Navaei

More
Re: DG-DEN-14175-1
replied to wbracken (deleted user)

This is done to get an average of the fill temperature as well as the last fill temperature prior to tranistioning to Gen Idle. These values are used for the next estimation and are different from ...

This is done to get an average of the fill temperature as well as the last fill temperature prior to tranistioning to Gen Idle. These values are used for the next estimation and are different from the heaters driver.

9:55 am

Dara Navaei

More
Re: DG-DEN-14175-1
replied to wbracken (deleted user)

Done.

9:54 am

Dara Navaei

More
Re: DG-DEN-14175-1
replied to wbracken (deleted user)

No, it should be removed.

2:17 pm

Dara Navaei

More
7ffa5c7
changed 1 file
DEN-13050-vpi-does-not-close-after-sample-water-returns-to-flush-idle, DEN-13154-heparin-syringe-empty-position-incorrect and 183 more DG-DEN-14175-1

DEN-14175, DEN-13999 uncommented DG pressure sensors alarm

- -2
- +1
./Pressures.c
- History
- Source
- Diff
./Pressures.c

2:06 pm

Dara Navaei

Merged DEN-14175

- -28
- +48
./Heaters.c
- History
- Source
- Diff
./Heaters.c
… 3 more files in changeset.

2:00 pm

wbracken (deleted user)

More
Re: DG-DEN-14175-1
commented on review

Where is valveSensedStates being updated?

1:53 pm

wbracken (deleted user)

More
Re: DG-DEN-14175-1
commented on review

Remove comment.

8:58 pm

Dara Navaei

More
cff72ec
changed 6 files
DEN-13050-vpi-does-not-close-after-sample-water-returns-to-flush-idle, DEN-13154-heparin-syringe-empty-position-incorrect and 183 more DG-DEN-14175-1

DEN-14175, DEN-13999 updated the pressure sensors persitent alarm. Added hardware configuration functions to check the status of the device (i.e. BETA, DVT)

- -1
- +1
./DrainPump.c
- History
- Source
- Diff
./DrainPump.c
- -31
- +61
./Pressures.c
- History
- Source
- Diff
./Pressures.c
- -1
- +2
./TemperatureSensors.c
- History
- Source
- Diff
./TemperatureSensors.c
- -17
- +8
./Valves.c
- History
- Source
- Diff
./Valves.c
… 2 more files in changeset.

11:59 am

wbracken (deleted user)

More
Re: DG-DEN-14175-1
commented on review

Not clear this needs to be done. I believe is properly handled in heaters when you get a temperature value and configured for V3.

9:56 am

Dara Navaei

More
0516c80
changed 1 file
DEN-13050-vpi-does-not-close-after-sample-water-returns-to-flush-idle, DEN-13154-heparin-syringe-empty-position-incorrect and 183 more DG-DEN-14175-1

Merge branch 'staging' into DEN-14175-dg_hd_dev-hd_dg_dvt-update-part-5

- -3
- +3
./Heaters.c
- History
- Source
- Diff
./Heaters.c

9:56 am

Dara Navaei

More
2b9d106
changed 9 files
DEN-13050-vpi-does-not-close-after-sample-water-returns-to-flush-idle, DEN-13154-heparin-syringe-empty-position-incorrect and 183 more DG-DEN-14175-1

DEN-14175, DIAL-213 added drain pump current and direction override commands, updated the heaters driver with the latest optimization requirements, added a DG valves sensed states override command