dgfirmware / firmware / App

Controllers

Clone Tools

Stats

Commits this week: 0
Total Committers: 16
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 21 Nov 2022
2:43 pm

Michael Garthwaite

DEN-14197: Addressed code review comments.

Options
    • -1
    • +1
    ./ROPump.c
2:42 pm

Michael Garthwaite

Fixed. Thanks!

Fixed. Thanks!

2:36 pm

Sean Nash

I thought we changed this to include "DG" in the enum name. Why is it deleted again?

I thought we changed this to include "DG" in the enum name. Why is it deleted again?

2:32 pm

Sean Nash

Change voltage to duty cycle.

Change voltage to duty cycle.

2:32 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

2:31 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

2:30 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

2:29 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

2:27 pm

Michael Garthwaite

Fixed. Thanks!

Fixed. Thanks!

2:27 pm

Michael Garthwaite

Fixed. Thanks!

Fixed. Thanks!

2:27 pm

Michael Garthwaite

DEN-14197: Addressed code review comments.

Options
    • -18
    • +18
    ./ROPump.c
  2. … 1 more file in changeset.
2:26 pm

Sean Nash

This line of code is not referencing a field in a structure. I do not see it declared anywhere. I've been unable to build this branch (I think because there is no fwcommon branch) so somebody may h...

This line of code is not referencing a field in a structure. I do not see it declared anywhere. I've been unable to build this branch (I think because there is no fwcommon branch) so somebody may have fixed this in develop.

2:23 pm

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

2:23 pm

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

2:22 pm

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

2:21 pm

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

2:21 pm

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

2:20 pm

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

2:20 pm

Michael Garthwaite

Fixed. Thanks!

Fixed. Thanks!

2:20 pm

Michael Garthwaite

Fixed. Thanks!

Fixed. Thanks!

2:20 pm

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

2:19 pm

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

2:19 pm

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

2:18 pm

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

2:18 pm

Sean Nash

Dara confirmed it is a duty cycle. We expect it to match our commanded duty cycle for the pump.

Dara confirmed it is a duty cycle. We expect it to match our commanded duty cycle for the pump.

2:17 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

2:13 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

2:12 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

2:11 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

2:11 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.