dgfirmware / firmware / App

Controllers

Clone Tools

Stats

Commits this week: 0
Total Committers: 16
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 30 Mar 2023
9:20 pm

Dara Navaei

DEN-14999 updated the code based on the alarms table changes

Options
    • -1
    • +0
    ./Heaters.c
  2. … 7 more files in changeset.
8:18 pm

Dara Navaei

DEN-14999 updated the code based on the alarms table update

Options
    • -2
    • +1
    ./ConductivitySensors.c
    • -12
    • +0
    ./Heaters.c
    • -2
    • +1
    ./Pressures.c
    • -2
    • +1
    ./TemperatureSensors.c
  5. … 5 more files in changeset.
7:04 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

7:04 pm

Dara Navaei

Merged DEN-14999

Options
    • -5
    • +28
    ./ConductivitySensors.c
  2. … 5 more files in changeset.
6:34 pm

Dara Navaei

DEN-14999 fixed the pressures self test

Options
    • -0
    • +1
    ./Pressures.c
5:06 pm

Sean Nash

DEN-14999: Updated 24V range alarms.

Options
    • -9
    • +17
    ./Voltages.c
    • -1
    • +1
    ./Voltages.h
2:36 pm

Bill Bracken <bill@criticalsoftwaresolutions.com>

DEN-14646 Changes per code review

Options
    • -1
    • +1
    ./ConductivitySensors.c
    • -3
    • +3
    ./Valves.c
1:42 pm

Bill Bracken <bill@criticalsoftwaresolutions.com>

Merge branch 'staging' into DEN-14646-fpga-alarm-properties-and-timing-3

Options
    • -4
    • +26
    ./ConductivitySensors.c
1:35 pm

Bill Bracken <bill@criticalsoftwaresolutions.com>

DEN-14646 Update per code review

Options
    • -1
    • +1
    ./ConductivitySensors.c
11:35 am

Dara Navaei

DEN-14999 merged the remote changes and updated the fill mode with the acid conductivity values

Options
    • -1
    • +2
    ./ConductivitySensors.c
  2. … 1 more file in changeset.
11:35 am

Sean Nash

I don't see it, but resolving anyway. RESOLVED in CODE WALKTHROUGH.

I don't see it, but resolving anyway.
RESOLVED in CODE WALKTHROUGH.

10:01 am

Dara Navaei

DG-DEN-14788_Dial 222 Sys Request
DG-DEN-14788_Dial 222 Sys Request
8:46 am

Michael Garthwaite

DIAL-222: removed heater check for reset override command.

Options
    • -4
    • +1
    ./Heaters.c
Wednesday 29 Mar 2023
11:25 pm

Sean Nash

DEN-14999: Removed alarm 203 (dg POST adc rail check for pressure sensors). Removed alarm 116 (dg temperature sensors adc rail check). Removed adc temperature sensors from alarm 115 (dg temperature sensors range check).

Options
    • -38
    • +1
    ./Pressures.c
    • -36
    • +1
    ./TemperatureSensors.c
2:52 pm

Sean Nash

Spaces inside (). And explicit condition (i.e. ( TRUE == isConvNotValid ).

Spaces inside (). And explicit condition (i.e. ( TRUE == isConvNotValid ).

11:25 am

wbracken  (deleted user)

Corrected

Corrected

8:39 am

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -1
    • +1
    ./ConductivitySensors.c
    • -1
    • +1
    ./ROPump.c
  3. … 6 more files in changeset.
8:37 am

Dara Navaei

8:08 am

Sean Nash

Tuesday 28 Mar 2023
5:28 pm

Bill Bracken <bill@criticalsoftwaresolutions.com>

DEN14646 - Valves variable renamed.

Options
    • -6
    • +6
    ./Valves.c
5:27 pm

Bill Bracken <bill@criticalsoftwaresolutions.com>

Merge branch 'staging' into DEN-14646-fpga-alarm-properties-and-timing-3

Options
    • -7
    • +15
    ./ConductivitySensors.c
    • -2
    • +7
    ./Heaters.c
    • -3
    • +3
    ./LoadCell.c
    • -1
    • +2
    ./TemperatureSensors.c
    • -3
    • +3
    ./Valves.c
5:19 pm

Dara Navaei

5:08 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

5:07 pm

Dara Navaei

Done

Done

5:03 pm

Sean Nash

I did. I still see a call to sendAckResponseMsg() and I don't think it should be here.

I did. I still see a call to sendAckResponseMsg() and I don't think it should be here.

5:00 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

4:59 pm

Dara Navaei

DEN-15014 addressed the code review comment

Options
    • -1
    • +1
    ./ROPump.c
4:59 pm

Dara Navaei

Check the diff of the last two commits.

Check the diff of the last two commits.

4:58 pm

Sean Nash

What I meant is that we don't need to send anything other than response.

What I meant is that we don't need to send anything other than response.

4:58 pm

Dara Navaei

Done

Done