Controllers

Clone Tools
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
DEN-14999 updated the code based on the alarms table changes

  1. … 7 more files in changeset.
DEN-14999 updated the code based on the alarms table update

  1. … 5 more files in changeset.
RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Merged DEN-14999

  1. … 5 more files in changeset.
DEN-14999 fixed the pressures self test

DEN-14999: Updated 24V range alarms.

DEN-14646 Changes per code review

Merge branch 'staging' into DEN-14646-fpga-alarm-properties-and-timing-3

DEN-14646 Update per code review

DEN-14999 merged the remote changes and updated the fill mode with the acid conductivity values

  1. … 1 more file in changeset.
I don't see it, but resolving anyway. RESOLVED in CODE WALKTHROUGH.

I don't see it, but resolving anyway.
RESOLVED in CODE WALKTHROUGH.

DG-DEN-14788_Dial 222 Sys Request
DG-DEN-14788_Dial 222 Sys Request
DIAL-222: removed heater check for reset override command.

DEN-14999: Removed alarm 203 (dg POST adc rail check for pressure sensors). Removed alarm 116 (dg temperature sensors adc rail check). Removed adc temperature sensors from alarm 115 (dg temperature sensors range check).

Spaces inside (). And explicit condition (i.e. ( TRUE == isConvNotValid ).

Spaces inside (). And explicit condition (i.e. ( TRUE == isConvNotValid ).

Corrected

Corrected

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

  1. … 6 more files in changeset.
DEN14646 - Valves variable renamed.

Merge branch 'staging' into DEN-14646-fpga-alarm-properties-and-timing-3

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Done

Done

I did. I still see a call to sendAckResponseMsg() and I don't think it should be here.

I did. I still see a call to sendAckResponseMsg() and I don't think it should be here.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

DEN-15014 addressed the code review comment

Check the diff of the last two commits.

Check the diff of the last two commits.

What I meant is that we don't need to send anything other than response.

What I meant is that we don't need to send anything other than response.

Done

Done