Activity dgfirmware/firmware/App/Controllers

9:44 am

Michael Garthwaite

More
de150a6
changed 1 file
DEN-14316-chemical-disinfect, DEN-14646-fpga-alarm-properties-and-timing-3 and 138 more DG-DEN-14788-5

DIAL-222: changed set heater duty cycle to consider overriden values on reset.

- -19
- +27
./Heaters.c
- History
- Source
- Diff
./Heaters.c

9:14 am

Michael Garthwaite

More
Re: DG-DEN-14999-2
replied to Sean Nash

RESOLVED IN CODE WALKTHROUGH.

9:03 am

I think VPi is closed during standby mode, so not sure why we want to check inlet conductivity in this mode. I imagine new system would get installed by service - would need some kind of priming do...

I think VPi is closed during standby mode, so not sure why we want to check inlet conductivity in this mode.
I imagine new system would get installed by service - would need some kind of priming done in service mode, so I'm not worried about that.

8:54 am

Michael Garthwaite

More
Re: DG-DEN-14999-2
commented on review

will these alarms trigger with open air? Ex: if a user has a device shipped to them, will they be greeted with conductivity alarms on first power up before any water has ran through the system? If...

will these alarms trigger with open air?

Ex: if a user has a device shipped to them, will they be greeted with conductivity alarms on first power up before any water has ran through the system? If so, how will they be able to fix it?

9:20 pm

Dara Navaei

More
ff676a9
changed 8 files
DEN-14316-chemical-disinfect, DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error and 136 more DG-DEN-14999-2

DEN-14999 updated the code based on the alarms table changes

- -1
- +0
./Heaters.c
- History
- Source
- Diff
./Heaters.c
… 7 more files in changeset.

8:18 pm

Dara Navaei

More
cd7ff56
changed 9 files
DEN-14316-chemical-disinfect, DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error and 136 more DG-DEN-14999-2

DEN-14999 updated the code based on the alarms table update

- -2
- +1
./ConductivitySensors.c
- History
- Source
- Diff
./ConductivitySensors.c
- -12
- +0
./Heaters.c
- History
- Source
- Diff
./Heaters.c
- -2
- +1
./Pressures.c
- History
- Source
- Diff
./Pressures.c
- -2
- +1
./TemperatureSensors.c
- History
- Source
- Diff
./TemperatureSensors.c
… 5 more files in changeset.

7:04 pm

Sean Nash

More
Re: DG-DEN-14646-1
replied to Sean Nash

RESOLVED in CODE WALKTHROUGH.

7:04 pm

Dara Navaei

Merged DEN-14999

- -5
- +28
./ConductivitySensors.c
- History
- Source
- Diff
./ConductivitySensors.c
… 5 more files in changeset.

6:34 pm

Dara Navaei

More
b68997b
changed 1 file
DEN-14316-chemical-disinfect, DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error and 136 more DG-DEN-14999-2

DEN-14999 fixed the pressures self test

- -0
- +1
./Pressures.c
- History
- Source
- Diff
./Pressures.c

5:06 pm

Sean Nash

More
9d81cf1
changed 2 files
DEN-14316-chemical-disinfect, DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error and 136 more DG-DEN-14999-2

DEN-14999: Updated 24V range alarms.

- -9
- +17
./Voltages.c
- History
- Source
- Diff
./Voltages.c
- -1
- +1
./Voltages.h
- History
- Source
- Diff
./Voltages.h

2:36 pm

Bill Bracken <bill@criticalsoftwaresolutions.com>

More
9488cd5
changed 2 files
DEN-14316-chemical-disinfect, DEN-14646-fpga-alarm-properties-and-timing-3 and 138 more DG-DEN-14646-1

DEN-14646 Changes per code review

- -1
- +1
./ConductivitySensors.c
- History
- Source
- Diff
./ConductivitySensors.c
- -3
- +3
./Valves.c
- History
- Source
- Diff
./Valves.c

1:42 pm

Bill Bracken <bill@criticalsoftwaresolutions.com>

More
f448119
changed 1 file
DEN-14316-chemical-disinfect, DEN-14646-fpga-alarm-properties-and-timing-3 and 138 more DG-DEN-14646-1

Merge branch 'staging' into DEN-14646-fpga-alarm-properties-and-timing-3

- -4
- +26
./ConductivitySensors.c
- History
- Source
- Diff
./ConductivitySensors.c

1:35 pm

Bill Bracken <bill@criticalsoftwaresolutions.com>

More
9485204
changed 1 file
DEN-14316-chemical-disinfect, DEN-14646-fpga-alarm-properties-and-timing-3 and 138 more DG-DEN-14646-1

DEN-14646 Update per code review

- -1
- +1
./ConductivitySensors.c
- History
- Source
- Diff
./ConductivitySensors.c

11:35 am

Dara Navaei

More
a069a79
changed 2 files
DEN-14316-chemical-disinfect, DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error and 136 more DG-DEN-14999-2

DEN-14999 merged the remote changes and updated the fill mode with the acid conductivity values

- -1
- +2
./ConductivitySensors.c
- History
- Source
- Diff
./ConductivitySensors.c
… 1 more file in changeset.

11:35 am

Sean Nash

More
Re: DG-DEN-14646-1
replied to wbracken (deleted user)

I don't see it, but resolving anyway. RESOLVED in CODE WALKTHROUGH.

I don't see it, but resolving anyway.
RESOLVED in CODE WALKTHROUGH.

10:01 am

Dara Navaei

More
DG-DEN-14788-5
started review

DG-DEN-14788_Dial 222 Sys Request

8:46 am

Michael Garthwaite

More
efeadc3
changed 1 file
DEN-14316-chemical-disinfect, DEN-14646-fpga-alarm-properties-and-timing-3 and 138 more DG-DEN-14788-5

DIAL-222: removed heater check for reset override command.

- -4
- +1
./Heaters.c
- History
- Source
- Diff
./Heaters.c

11:25 pm

Sean Nash

More
14ab8d8
changed 2 files
DEN-14316-chemical-disinfect, DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error and 136 more DG-DEN-14999-2

DEN-14999: Removed alarm 203 (dg POST adc rail check for pressure sensors). Removed alarm 116 (dg temperature sensors adc rail check). Removed adc temperature sensors from alarm 115 (dg temperature sensors range check).