Activity dgfirmware/firmware/App/Controllers

8:25 am

Dara Navaei

More
8f240a9
changed 1 file
DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 124 more DG-DEN-15199-1

Merge branch 'staging' into DEN-15199-fw_dn_sprint_95

- -5
- +6
./DrainPump.c
- History
- Source
- Diff
./DrainPump.c

8:22 am

Dara Navaei

More
def0601
changed 6 files
DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 124 more DG-DEN-15199-1

DEN-15199 added to code to check for dialin check in

- -2
- +2
./DrainPump.c
- History
- Source
- Diff
./DrainPump.c
- -1
- +7
./ROPump.c
- History
- Source
- Diff
./ROPump.c
… 4 more files in changeset.

8:47 am

jtaylor (deleted user)

More
Re: DG-DEN-13989-2
replied to Sean Nash

Removed. We'll want to watch for continued pump speed errors occurring on going to zero. There seem to be both RPM resolution and lag errors in the speed measurement, causing problems with the alar...

Removed. We'll want to watch for continued pump speed errors occurring on going to zero. There seem to be both RPM resolution and lag errors in the speed measurement, causing problems with the alarm. If problems continue, we should consider increasing the trigger interval, decreasing the clear interval, and/or resetting the alarm when the target is set to zero (or taking a large step).

5:11 pm

Sean Nash and dcox (deleted user)

More
DG-DEN-13989-2
resumed reviewing

5:11 pm

Sean Nash

More
Re: DG-DEN-13989-2
replied to jtaylor (deleted user)

I think we are regularly setting new targets on the concentrate pumps when we are mixing (trying to keep mix ratio same while RO flow is potentially changing due to control). That would mean the pe...

I think we are regularly setting new targets on the concentrate pumps when we are mixing (trying to keep mix ratio same while RO flow is potentially changing due to control). That would mean the persistence is being cleared all the time while mixing, essentially rendering the alarm disabled. I don't think we should reset here.

3:33 pm

jtaylor (deleted user)

Magnitude. Error limit for the case when the value is reaching the resolution of the measurement, where the error is specified as +-REL%, or +-MAG, whichever is greater.

3:29 pm

jtaylor (deleted user)

Two V&V runs seemed to trigger the pump speed alarm when pump was slowing, then turned off. It seemed possible that the change in pump target speed was occurring while the persistent alarm was on i...

Two V&V runs seemed to trigger the pump speed alarm when pump was slowing, then turned off. It seemed possible that the change in pump target speed was occurring while the persistent alarm was on it's way to being triggered.

3:19 pm

Dara Navaei

More
Re: DG-DEN-13989-2
commented on review

What does MAG stand for?

3:17 pm

Dara Navaei

More
Re: DG-DEN-13989-2
commented on review

Does target speed being less than 3.0 mean the target speed is 0.0? I understand that 3.0 mL/min is very close to 0.0 mL/min for this pump but I think we should be less than NEARLY_ZERO.

2:08 pm