dgfirmware / firmware / App

Controllers

Clone Tools

Stats

Commits this week: 0
Total Committers: 16
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 09 Jun 2023
9:00 am

Dara Navaei

DEN-15367, DEN-15404 work in progress. Updated the RO permeate sample mode code to be able to receive and send ready command to HD for further dispensing or canceling the run

Options
    • -1
    • +1
    ./ConcentratePumps.c
  2. … 5 more files in changeset.
Tuesday 06 Jun 2023
1:14 pm

wbracken  (deleted user)

Comments.

Comments.

Sunday 04 Jun 2023
3:53 pm

Dara Navaei

Merged DEN-15367

Options
    • -0
    • +1
    ./ConductivitySensors.c
    • -1
    • +1
    ./Heaters.c
  3. … 5 more files in changeset.
Friday 02 Jun 2023
1:10 pm

Dara Navaei

12:45 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -1
    • +1
    ./ROPump.c
  2. … 5 more files in changeset.
12:34 pm

Sean Nash , jtaylor  (deleted user) and Michael Garthwaite

12:05 pm

jtaylor  (deleted user) and Michael Garthwaite

11:47 am

Michael Garthwaite

11:47 am

Michael Garthwaite

9:09 am

jtaylor  (deleted user)

Thursday 01 Jun 2023
6:11 pm

Bill Bracken <bill@criticalsoftwaresolutions.com>

DEN-15477 Drain pump encoder support for FPGA Testing.

Options
    • -5
    • +19
    ./DrainPump.c
4:21 pm

wbracken  (deleted user)

3:40 pm

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

1:11 pm

jtaylor  (deleted user)

12:01 pm

Dara Navaei

DG-DEN-13989_FW Concentrate Pump Cp1 Speed Error Observed
DG-DEN-13989_FW Concentrate Pump Cp1 Speed Error Observed
10:01 am

Dara Navaei

DG-DEN-15443_Alarm 97 Dialysate Conductivity Out OF Range Triggers Periodically During Treatment
DG-DEN-15443_Alarm 97 Dialysate Conductivity Out OF Range Triggers Periodically During Treatment
8:39 am

Sean Nash

Looks like it's already there.

Looks like it's already there.

Wednesday 31 May 2023
2:59 pm

Dara Navaei

DEN-15455 updated chem disinfect and chem flush disinfect to not clear the acid insert and remove alarms

Options
    • -1
    • +1
    ./ROPump.c
  2. … 2 more files in changeset.
9:06 am

Dara Navaei

DEN-15329 added a minimum check for the RO pump duty cycle when it is in the control to pressure state

Options
    • -1
    • +3
    ./ROPump.c
Tuesday 30 May 2023
3:22 pm

wbracken  (deleted user)

Add alarmDetectedPendingTrigger to header.

Add alarmDetectedPendingTrigger to header.

12:02 pm

Dara Navaei

DG-DEN-15455_FW Dvt 6 And 16 Cap Switches DO Not Update When Caps Close - Ready
DG-DEN-15455_FW Dvt 6 And 16 Cap Switches DO Not Update When Caps Close - Ready
12:01 pm

Dara Navaei

DG-DEN-15477_Add Windowed Timer TO Drain Pump Encoder Error
DG-DEN-15477_Add Windowed Timer TO Drain Pump Encoder Error
8:34 am

Sean Nash

Fix alignment.

Fix alignment.

Monday 29 May 2023
9:23 pm

Dara Navaei

DEN-15404 work in progress. Worked on the RO permeat sample mode

Options
    • -0
    • +1
    ./ConductivitySensors.c
    • -0
    • +1
    ./Pressures.c
    • -0
    • +1
    ./TemperatureSensors.c
  4. … 5 more files in changeset.
Sunday 28 May 2023
12:39 pm

Dara Navaei

Merged staging

Options
    • -2
    • +3
    ./ConductivitySensors.c
    • -9
    • +27
    ./Heaters.c
  3. … 3 more files in changeset.
Friday 26 May 2023
8:01 pm

Dara Navaei

DG-DEN-13989_FW Concentrate Pump Cp1 Speed Error Observed
DG-DEN-13989_FW Concentrate Pump Cp1 Speed Error Observed
4:46 pm

Dara Navaei

4:33 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -1
    • +1
    ./Voltages.c
3:20 pm

jtaylor  (deleted user)

3:19 pm

jtaylor  (deleted user)

Yes. The pump minimum target is 3, attempting to set smaller than that limit results in the pump being turned off. The underlying issue is that stepConcentratePumpToTargetSpeed does not initialize...

Yes. The pump minimum target is 3, attempting to set smaller than that limit results in the pump being turned off.

The underlying issue is that stepConcentratePumpToTargetSpeed does not initialize speedIncrease or hasTgtBeenReached, or update the currentPumpSpeed target unless the currentToTargetDiff is < nearly zero. Since the speeds are quantized, we'll see zero more frequently than expected. Particularly when stopping the pump, the Diff will be zero, and currentPumpSpeed may never be updated, leading to odd transient conditions.

By increasing the "zero" level, and adding the initialization and else clauses for zero error and stopping the pump, we guarantee that the speed setting is always set intentionally. Also we already have a minimum speed parameter, used to determine when to stop the motor, and attempts at motor control at these low levels.