Controllers

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
DEN-15367, DEN-15404 work in progress. Updated the RO permeate sample mode code to be able to receive and send ready command to HD for further dispensing or canceling the run

  1. … 5 more files in changeset.
Comments.

Comments.

Merged DEN-15367

  1. … 5 more files in changeset.
Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

  1. … 5 more files in changeset.
DEN-15477 Drain pump encoder support for FPGA Testing.

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

DG-DEN-13989_FW Concentrate Pump Cp1 Speed Error Observed
DG-DEN-13989_FW Concentrate Pump Cp1 Speed Error Observed
DG-DEN-15443_Alarm 97 Dialysate Conductivity Out OF Range Triggers Periodically During Treatment
DG-DEN-15443_Alarm 97 Dialysate Conductivity Out OF Range Triggers Periodically During Treatment
Looks like it's already there.

Looks like it's already there.

DEN-15455 updated chem disinfect and chem flush disinfect to not clear the acid insert and remove alarms

  1. … 2 more files in changeset.
DEN-15329 added a minimum check for the RO pump duty cycle when it is in the control to pressure state

Add alarmDetectedPendingTrigger to header.

Add alarmDetectedPendingTrigger to header.

DG-DEN-15455_FW Dvt 6 And 16 Cap Switches DO Not Update When Caps Close - Ready
DG-DEN-15455_FW Dvt 6 And 16 Cap Switches DO Not Update When Caps Close - Ready
DG-DEN-15477_Add Windowed Timer TO Drain Pump Encoder Error
DG-DEN-15477_Add Windowed Timer TO Drain Pump Encoder Error
Fix alignment.

Fix alignment.

DEN-15404 work in progress. Worked on the RO permeat sample mode

  1. … 5 more files in changeset.
Merged staging

  1. … 3 more files in changeset.
DG-DEN-13989_FW Concentrate Pump Cp1 Speed Error Observed
DG-DEN-13989_FW Concentrate Pump Cp1 Speed Error Observed
Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Yes. The pump minimum target is 3, attempting to set smaller than that limit results in the pump being turned off. The underlying issue is that stepConcentratePumpToTargetSpeed does not initialize...

Yes. The pump minimum target is 3, attempting to set smaller than that limit results in the pump being turned off.

The underlying issue is that stepConcentratePumpToTargetSpeed does not initialize speedIncrease or hasTgtBeenReached, or update the currentPumpSpeed target unless the currentToTargetDiff is < nearly zero. Since the speeds are quantized, we'll see zero more frequently than expected. Particularly when stopping the pump, the Diff will be zero, and currentPumpSpeed may never be updated, leading to odd transient conditions.

By increasing the "zero" level, and adding the initialization and else clauses for zero error and stopping the pump, we guarantee that the speed setting is always set intentionally. Also we already have a minimum speed parameter, used to determine when to stop the motor, and attempts at motor control at these low levels.