dgfirmware / firmware / App

Controllers

Clone Tools

Stats

Commits this week: 3
Total Committers: 16
Last Commit: 10 Jun
Commits this week: 3

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 13 Jun 2023
10:37 am

Dara Navaei

DEN-15367 addressed the code review comments

Options
    • -2
    • +2
    ./ConcentratePumps.c
    • -4
    • +4
    ./DrainPump.c
    • -3
    • +3
    ./ROPump.c
  4. … 5 more files in changeset.
10:27 am

Dara Navaei

Done

Done

9:38 am

Sean Nash

Remove "handle" from this function name. It should start with "send". And why does this message have a payload. Message itself infers ready.

Remove "handle" from this function name. It should start with "send". And why does this message have a payload. Message itself infers ready.

9:37 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

9:34 am

Dara Navaei

This function will be overhauled.

This function will be overhauled.

9:33 am

Dara Navaei

Done

Done

9:33 am

Dara Navaei

Done

Done

9:32 am

Dara Navaei

Done

Done

9:27 am

Dara Navaei

Done

Done

9:25 am

Dara Navaei

Done

Done

9:24 am

Dara Navaei

This function is only to set the actuators. If the incorrect message status is selected the collect sample function will trigger the software fault.

This function is only to set the actuators. If the incorrect message status is selected the collect sample function will trigger the software fault.

9:23 am

Dara Navaei

This is the lower level function to set the actuators. If the state is incorrect the state machine in the exec function will trigger the software fault.

This is the lower level function to set the actuators. If the state is incorrect the state machine in the exec function will trigger the software fault.

9:22 am

Dara Navaei

Changed to TRUE. Yes this message is only dispatched when DG has finished dispensing and is sending HD a message that it is ready to process another dispense or cancel command.

Changed to TRUE. Yes this message is only dispatched when DG has finished dispensing and is sending HD a message that it is ready to process another dispense or cancel command.

Monday 12 Jun 2023
5:44 pm

wbracken  (deleted user)

5:35 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -2
    • +2
    ./DrainPump.c
2:47 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

2:44 pm

Sean Nash

We're always ready? Why does UI need to ask if DG is ready if always ready? Replace "1" with "TRUE".

We're always ready? Why does UI need to ask if DG is ready if always ready?
Replace "1" with "TRUE".

2:39 pm

Sean Nash

Should this be a s/w fault?

Should this be a s/w fault?

2:39 pm

Sean Nash

Should default be separate from DISPENSING? And should default have a s/w fault?

Should default be separate from DISPENSING? And should default have a s/w fault?

1:59 pm

Sean Nash

Cycle is mis-spelled.

Cycle is mis-spelled.

1:55 pm

Sean Nash

The check against nearly zero is pointless since we're looking for > 10 mL/min now. Is cpTargetSpeed always positive (even when in reverse)? If not, should absolute value speed before checking agai...

The check against nearly zero is pointless since we're looking for > 10 mL/min now.
Is cpTargetSpeed always positive (even when in reverse)? If not, should absolute value speed before checking against low speed threshold.

1:52 pm

Sean Nash

Not really "off". Should be applied when going slowly (<10 mL/min).

Not really "off". Should be applied when going slowly (<10 mL/min).

10:49 am

dcox  (deleted user)

8:44 am

Dara Navaei

Merge branch 'DEN-15367-hd_dg_test_configuration_setup' into develop

Options
    • -16
    • +20
    ./ConcentratePumps.c
  2. … 4 more files in changeset.
1:07 am

wbracken  (deleted user)

Update function header.

Update function header.

1:03 am

wbracken  (deleted user)

Update function header.

Update function header.

1:03 am

wbracken  (deleted user)

Update function header.

Update function header.

1:02 am

wbracken  (deleted user)

Update function header

Update function header

12:55 am

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

Sunday 11 Jun 2023
8:28 pm

Dara Navaei

DEN-15367 changed the RO permeate sample cancel water path. DEN-14004 changed the request message from UI to 0x89. DEN-15509 changed the reservoir threshold from 1700 to 1850 mL. DEN-15192 changed the concentrate pump low speed threshold.

Options
    • -10
    • +14
    ./ConcentratePumps.c
  2. … 3 more files in changeset.