dgfirmware / firmware / App

Controllers

Clone Tools

Stats

Commits this week: 0
Total Committers: 16
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 14 Jun 2023
3:50 pm

Dara Navaei

DEN-15443 added code to transition back to ramp state in concenrate pumps if the new requested target speed is greater than the threshold

Options
    • -2
    • +11
    ./ConcentratePumps.c
2:28 pm

Dara Navaei

DG-DEN-15571_Chemical Disinfect RX TO RY Timeout Alarms DO Not Trigger
DG-DEN-15571_Chemical Disinfect RX TO RY Timeout Alarms DO Not Trigger
1:31 pm

Dara Navaei

Merged staging

Options
    • -1
    • +1
    ./ConcentratePumps.c
    • -1
    • +1
    ./ConductivitySensors.c
    • -1
    • +1
    ./Heaters.c
  4. … 5 more files in changeset.
9:57 am

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -1
    • +1
    ./ConcentratePumps.c
    • -1
    • +1
    ./ConductivitySensors.c
    • -2
    • +2
    ./DrainPump.c
    • -1
    • +1
    ./Heaters.c
    • -1
    • +1
    ./Pressures.c
    • -1
    • +1
    ./ROPump.c
    • -1
    • +1
    ./TemperatureSensors.c
  8. … 19 more files in changeset.
9:39 am

Dara Navaei

9:12 am

Sean Nash

9:09 am

Dara Navaei

Merge branch 'staging' into DEN-15367-hd_dg_test_configuration_setup

Options
    • -7
    • +21
    ./DrainPump.c
9:05 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Tuesday 13 Jun 2023
5:04 pm

Dara Navaei

DEN-14657 removed code to not check the error bit of a temperature sensor and let the temperature out of range alarm trigger the alarm

Options
    • -52
    • +3
    ./TemperatureSensors.c
3:31 pm

Dara Navaei

Done

Done

1:34 pm

Dara Navaei

Merge branch 'DEN-15367-hd_dg_test_configuration_setup' into develop

Options
    • -3
    • +3
    ./ConcentratePumps.c
    • -4
    • +4
    ./DrainPump.c
  3. … 3 more files in changeset.
12:50 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

12:50 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

12:48 pm

Sean Nash

Still has a payload. Should remove it.

Still has a payload. Should remove it.

12:47 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

12:46 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

12:46 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

12:42 pm

Dara Navaei

DEN-15367 addressed a code review comment

Options
    • -1
    • +1
    ./ConcentratePumps.c
12:42 pm

Dara Navaei

Removed the check to make sure the target speed is > 0. The current speed is always >= 0.0 mL/min.

Removed the check to make sure the target speed is > 0. The current speed is always >= 0.0 mL/min.

11:39 am

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

11:38 am

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

11:38 am

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

11:37 am

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

10:37 am

Dara Navaei

DEN-15367 addressed the code review comments

Options
    • -2
    • +2
    ./ConcentratePumps.c
    • -4
    • +4
    ./DrainPump.c
    • -3
    • +3
    ./ROPump.c
  4. … 5 more files in changeset.
10:27 am

Dara Navaei

Done

Done

9:38 am

Sean Nash

Remove "handle" from this function name. It should start with "send". And why does this message have a payload. Message itself infers ready.

Remove "handle" from this function name. It should start with "send". And why does this message have a payload. Message itself infers ready.

9:37 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

9:34 am

Dara Navaei

This function will be overhauled.

This function will be overhauled.

9:33 am

Dara Navaei

Done

Done

9:33 am

Dara Navaei

Done

Done