ModeRecirculate.h

Clone Tools
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
RESOLVED in CODE WALKTHROUGH

RESOLVED in CODE WALKTHROUGH

DG-DEN-2650_DG Firmware Infrastructure
DG-DEN-2650_DG Firmware Infrastructure
DG Staging Unreviewed Commits
DG Staging Unreviewed Commits
RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Nice catch. Fixed.

Nice catch. Fixed.

The max part of these do not look right (backward).

The max part of these do not look right (backward).

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Done.

Done.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Done.

Done.

Done.

Done.

Done.

Done.

Done.

Done.

I would prefer we return a TRUE or FALSE explicitly (like function below).

I would prefer we return a TRUE or FALSE explicitly (like function below).

Removed.

Removed.

Start comments w/ capital letter.

Start comments w/ capital letter.

I know bicarb pump "on" request above does not immediately turn the pump on, but I still think we should set target speed before we request pump on.

I know bicarb pump "on" request above does not immediately turn the pump on, but I still think we should set target speed before we request pump on.

I know acid pump "on" request above does not immediately turn the pump on, but I still think we should set target speed before we request pump on.

I know acid pump "on" request above does not immediately turn the pump on, but I still think we should set target speed before we request pump on.