dgfirmware / firmware / App

Modes

Clone Tools

Stats

Commits this week: 0
Total Committers: 15
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 26 May 2021
10:55 am

Sean Nash

DEN-7605: Addressed code review feedback.

Options
    • -1
    • +2
    ./ModeDrain.c
  2. … 1 more file in changeset.
10:53 am

Sean Nash

DEN-7605: Addressed code review feedback.

Options
    • -1
    • +2
    ./ModeDrain.c
  2. … 1 more file in changeset.
9:35 am

Sean Nash

Fixed.

Fixed.

9:06 am

Sean Nash

Yes. Fixed.

Yes. Fixed.

9:03 am

qnguyen  (deleted user)

Consider re-word to something more general. This function might be used by ModeHeatDisinfect to tare on an active reservoir.

Consider re-word to something more general. This function might be used by ModeHeatDisinfect to tare on an active reservoir.

8:58 am

qnguyen  (deleted user)

Should this be in interval count?

Should this be in interval count?

Tuesday 25 May 2021
4:14 pm

Quang Nguyen <qnguyen@diality.com>

DEN-7802: Added persistence to concentrate pumps check

Options
    • -8
    • +28
    ./ModeFill.c
  2. … 1 more file in changeset.
1:12 pm

Sean Nash

Fixed merge conflicts.

Options
    • -5
    • +45
    ./ModeDrain.c
  2. … 7 more files in changeset.
Monday 24 May 2021
11:20 pm

Sean Nash

DEN-7605: Added POST messaging.

Options
    • -7
    • +15
    ./ModeInitPOST.c
  2. … 2 more files in changeset.
3:00 pm

Quang Nguyen <qnguyen@diality.com>

DEN-7802: Added safety check to fill using flow meter

Options
    • -5
    • +16
    ./ModeFill.c
  2. … 2 more files in changeset.
10:09 am

Quang Nguyen <qnguyen@diality.com>

DEN-8103: Enable water quality checks

Options
    • -0
    • +2
    ./ModeStandby.c
  2. … 1 more file in changeset.
Friday 21 May 2021
2:35 pm

Sean Nash

DEN-7605: Added tare state to drain mode to allow time for reservoir to settle first.

Options
    • -5
    • +45
    ./ModeDrain.c
  2. … 2 more files in changeset.
10:42 am

Dara Navaei

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:20 am

Sean Nash

Fixed.

Fixed.

10:20 am

Sean Nash

Fixed.

Fixed.

9:18 am

Sean Nash

Fixed merge conflicts.

Options
    • -6
    • +10
    ./ModeDrain.c
    • -1
    • +4
    ./ModeHeatDisinfect.c
    • -1
    • +0
    ./ModeStandby.c
  4. … 6 more files in changeset.
8:54 am

Sean Nash

DEN-7605: Added delays to drain mode.

Options
    • -4
    • +10
    ./ModeDrain.c
  2. … 2 more files in changeset.
Thursday 20 May 2021
11:26 am

qnguyen  (deleted user)

The only preference is to put TRUE first if it is == such as below.

The only preference is to put TRUE first if it is == such as below.

8:58 am

Sean Nash

I have no preference on that. Data is temporary either way. By reference is a little easier on the stack.

I have no preference on that. Data is temporary either way. By reference is a little easier on the stack.

Wednesday 19 May 2021
5:15 pm

Sean Nash

Should we move this enum to separate .h file?

Should we move this enum to separate .h file?

3:35 pm

pmontazemi  (deleted user)

Place TRUE as first argument.

Place TRUE as first argument.

3:29 pm

pmontazemi  (deleted user)

If we align, we align everything, otherwise, no extra spaces between variables and the "=" sign.

If we align, we align everything, otherwise, no extra spaces between variables and the "=" sign.

3:28 pm

pmontazemi  (deleted user)

Align comment.

Align comment.

Tuesday 18 May 2021
10:07 am

qnguyen  (deleted user)

DG-DEN-8103_DG HD Dev Alarm Design
DG-DEN-8103_DG HD Dev Alarm Design
Saturday 15 May 2021
9:51 am

Dara Navaei

I thought we decided to pass the broadcast data as a reference. Did we change that?

I thought we decided to pass the broadcast data as a reference. Did we change that?

Friday 14 May 2021
3:20 pm

qnguyen  (deleted user)

Removed casting.

Removed casting.

3:19 pm

Quang Nguyen <qnguyen@diality.com>

DEN-7802: Added fill mode paused state

Options
    • -3
    • +41
    ./ModeFill.c
  2. … 3 more files in changeset.
3:18 pm

qnguyen  (deleted user)

The macro already cast the data to U32.

The macro already cast the data to U32.

1:43 pm

Sean Nash

Should maybe cast here though.

Should maybe cast here though.

1:43 pm

Sean Nash

Why cast here?

Why cast here?