dgfirmware / firmware / App

Modes

Clone Tools

Stats

Commits this week: 0
Total Committers: 15
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 31 May 2021
4:33 pm

Dara Navaei

DEN-8030 tested modes and continued developing chemical disinfect

Options
    • -137
    • +342
    ./ModeChemicalDisinfect.c
    • -2
    • +8
    ./ModeChemicalDisinfect.h
    • -5
    • +32
    ./ModeDrain.c
    • -10
    • +3
    ./ModeFault.c
    • -0
    • +4
    ./ModeFill.c
    • -114
    • +26
    ./ModeHeatDisinfect.c
    • -2
    • +7
    ./ModeHeatDisinfect.h
    • -2
    • +2
    ./ModeRecirculate.c
    • -1
    • +1
    ./OperationModes.c
  10. … 6 more files in changeset.
Sunday 30 May 2021
2:46 pm

Dara Navaei

DG-DEN-8030_DG-HD DEV Mode Chemical Disinfect
DG-DEN-8030_DG-HD DEV Mode Chemical Disinfect
Saturday 29 May 2021
2:05 am

Quang Nguyen <qnguyen@diality.com>

DEN-8103: Added filter flush time period override

Options
    • -2
    • +77
    ./ModeStandby.c
    • -4
    • +4
    ./ModeStandby.h
  3. … 3 more files in changeset.
1:16 am

qnguyen  (deleted user)

Good point. The module has been moved to fwcommon.

Good point. The module has been moved to fwcommon.

1:16 am

qnguyen  (deleted user)

Removed the wrapper function. For now, only support one type of 32-bit CRC algorithm.

Removed the wrapper function. For now, only support one type of 32-bit CRC algorithm.

Friday 28 May 2021
4:39 pm

qnguyen  (deleted user)

Done.

Done.

4:33 pm

qnguyen  (deleted user)

Noe said they updated the ID and this is the new ID for DG FPGA. The FPGA test will fail without this change.

Noe said they updated the ID and this is the new ID for DG FPGA.
The FPGA test will fail without this change.

3:20 pm

Sean Nash

Should mention somewhere that timer is counting ms.

Should mention somewhere that timer is counting ms.

3:19 pm

Sean Nash

Why did this change?

Why did this change?

3:18 pm

Sean Nash

Is there a reason why this module isn't in fwcommon? And if it can't be common for some reason, should this module (or group name) be named DGIntegrity?

Is there a reason why this module isn't in fwcommon? And if it can't be common for some reason, should this module (or group name) be named DGIntegrity?

3:18 pm

Sean Nash

Do we need to support more than one 32-bit CRC algorithm in firmware? If not, do we need this wrapper function?

Do we need to support more than one 32-bit CRC algorithm in firmware? If not, do we need this wrapper function?

Thursday 27 May 2021
10:34 am

qnguyen  (deleted user)

Done.

Done.

10:32 am

qnguyen  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:32 am

qnguyen  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:32 am

pmontazemi  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:31 am

pmontazemi  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:30 am

pmontazemi  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Wednesday 26 May 2021
10:55 am

Sean Nash

DEN-7605: Addressed code review feedback.

Options
    • -1
    • +2
    ./ModeDrain.c
  2. … 1 more file in changeset.
10:53 am

Sean Nash

DEN-7605: Addressed code review feedback.

Options
    • -1
    • +2
    ./ModeDrain.c
  2. … 1 more file in changeset.
9:35 am

Sean Nash

Fixed.

Fixed.

9:06 am

Sean Nash

Yes. Fixed.

Yes. Fixed.

9:03 am

qnguyen  (deleted user)

Consider re-word to something more general. This function might be used by ModeHeatDisinfect to tare on an active reservoir.

Consider re-word to something more general. This function might be used by ModeHeatDisinfect to tare on an active reservoir.

8:58 am

qnguyen  (deleted user)

Should this be in interval count?

Should this be in interval count?

Tuesday 25 May 2021
4:14 pm

Quang Nguyen <qnguyen@diality.com>

DEN-7802: Added persistence to concentrate pumps check

Options
    • -8
    • +28
    ./ModeFill.c
  2. … 1 more file in changeset.
1:12 pm

Sean Nash

Fixed merge conflicts.

Options
    • -5
    • +45
    ./ModeDrain.c
  2. … 7 more files in changeset.
Monday 24 May 2021
11:20 pm

Sean Nash

DEN-7605: Added POST messaging.

Options
    • -7
    • +15
    ./ModeInitPOST.c
  2. … 2 more files in changeset.
3:00 pm

Quang Nguyen <qnguyen@diality.com>

DEN-7802: Added safety check to fill using flow meter

Options
    • -5
    • +16
    ./ModeFill.c
  2. … 2 more files in changeset.
10:09 am

Quang Nguyen <qnguyen@diality.com>

DEN-8103: Enable water quality checks

Options
    • -0
    • +2
    ./ModeStandby.c
  2. … 1 more file in changeset.
Friday 21 May 2021
2:35 pm

Sean Nash

DEN-7605: Added tare state to drain mode to allow time for reservoir to settle first.

Options
    • -5
    • +45
    ./ModeDrain.c
  2. … 2 more files in changeset.
10:42 am

Dara Navaei

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.