Activity dgfirmware/firmware/App/Modes

9:59 am

Quang Nguyen <qnguyen@diality.com>

More
2fafa57
changed 3 files
DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 208 more DG-DEN-7802-1

DEN-7802: Fixed conductivity fault condition

- -7
- +7
./ModeFill.c
- History
- Source
- Diff
./ModeFill.c
- -1
- +1
./ModeRecirculate.c
- History
- Source
- Diff
./ModeRecirculate.c
… 1 more file in changeset.

9:34 am

Sean Nash

More
Re: DG-DEN-7802-1
commented on review

I think we should not stop RO pump or heater. Just go to drain like production state (but no mixing).

9:31 am

Sean Nash

More
Re: DG-DEN-7802-1
commented on review

Call checkDialysateConductivity() once at top of function. Then use return value for the two if conditions. Also, this second if should be an else if to ensure you don't do both.

Call checkDialysateConductivity() once at top of function. Then use return value for the two if conditions.
Also, this second if should be an else if to ensure you don't do both.

9:36 am

Sean Nash

More
5156a85
changed 3 files
DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 214 more DG-DEN-7605-1 DG-DEN-8103-1 DG-DEN-8030-1

DEN-7605: Re-ordered DG POST tests. Fixed comments.

- -6
- +6
./ModeInitPOST.c
- History
- Source
- Diff
./ModeInitPOST.c
… 2 more files in changeset.

4:26 pm

Quang Nguyen <qnguyen@diality.com>

More
c17d3d8
changed 1 file
DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 208 more DG-DEN-7802-1

DEN-7802: Fixed water sample

- -1
- +10
./ModeStandby.c
- History
- Source
- Diff
./ModeStandby.c

1:55 pm

Dara Navaei

More
b63e03b
changed 3 files
DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 213 more DG-DEN-8030-1

DEN-8030 updated the drain pump RPM conversion

- -3
- +3
./ModeChemicalDisinfect.c
- History
- Source
- Diff
./ModeChemicalDisinfect.c
- -4
- +9
./ModeHeatDisinfect.c
- History
- Source
- Diff
./ModeHeatDisinfect.c
… 1 more file in changeset.

1:57 pm

Sean Nash

More
7df1fae
changed 8 files
develop_1-24

Fixed merge conflicts.

- -1
- +3
./ModeFault.c
- History
- Source
- Diff
./ModeFault.c
… 7 more files in changeset.

1:50 pm

Sean Nash

More
5f86e35
changed 7 files
DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 214 more DG-DEN-7605-1 DG-DEN-8103-1

DEN-7605: Minor fixes.

- -1
- +3
./ModeFault.c
- History
- Source
- Diff
./ModeFault.c
… 6 more files in changeset.

6:13 pm

Dara Navaei

More
3f7d30b
changed 10 files
DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 213 more DG-DEN-8030-1

DEN-8030 added UI states to heat disinfect. Changed the heaters control.

- -4
- +5
./ModeChemicalDisinfect.c
- History
- Source
- Diff
./ModeChemicalDisinfect.c
- -0
- +2
./ModeChemicalDisinfect.h
- History
- Source
- Diff
./ModeChemicalDisinfect.h
- -6
- +33
./ModeHeatDisinfect.c
- History
- Source
- Diff
./ModeHeatDisinfect.c
- -0
- +2
./ModeHeatDisinfect.h
- History
- Source
- Diff
./ModeHeatDisinfect.h
- -2
- +9
./ModeRecirculate.c
- History
- Source
- Diff
./ModeRecirculate.c
… 5 more files in changeset.

2:13 pm

Sean Nash

More
Re: DG-DEN-8030-1
commented on review

Change order of comparison.

2:11 pm

Sean Nash

More
Re: DG-DEN-8030-1
commented on review

Blank line after declaration.

2:08 pm

Sean Nash

More
Re: DG-DEN-8030-1
commented on review

I think we should add the new THd temperature sensor now. I know it's currently using TRo connection (and so we don't have a TRo), but we should handle that with build switch (THd reads from TRo ch...

I think we should add the new THd temperature sensor now. I know it's currently using TRo connection (and so we don't have a TRo), but we should handle that with build switch (THd reads from TRo channel and TRo can just be a copy of TDi for now if THD_USING_TRO_CONNECTOR build switch enabled, actual future code where both sensors exist on their own connectors if build switch is disabled).

12:42 pm

Sean Nash

More
Re: DG-DEN-8030-1
commented on review

Is this needed. Should we just let Standby mode set actuators as it wants on entry?

12:40 pm

Sean Nash

More
Re: DG-DEN-8030-1
commented on review

I think we should at least say that the mode variables are reset to re-start the mode or something.

12:37 pm

Sean Nash

More
Re: DG-DEN-8030-1
commented on review

Why are some values aligned at left and others at right? I think all values should align at left.

12:32 pm

Sean Nash

More
Re: DG-DEN-8030-1
commented on review

I'm assuming HET was enabled to get access to a GPIO pin? If so, do we need these notifications? Is there a place in HalCOGen to disable HET interrupts?

12:28 pm