dgfirmware / firmware / App

Modes

Clone Tools

Stats

Commits this week: 0
Total Committers: 15
Last Commit: 10 Jun
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 17 Jun 2021
9:56 am

Dara Navaei

DEN-8030 addressed code review comments

Options
    • -17
    • +18
    ./ModeChemicalDisinfect.c
    • -21
    • +1
    ./ModeDrain.c
    • -5
    • +0
    ./ModeFill.c
    • -13
    • +27
    ./ModeHeatDisinfect.c
    • -12
    • +0
    ./ModeHeatDisinfect.h
  6. … 5 more files in changeset.
9:56 am

Dara Navaei

CONC_PUMPS_REVERSE_SPEED_ML_PER_MIN = -30.0 to indicate that the direction is in reverse.

CONC_PUMPS_REVERSE_SPEED_ML_PER_MIN = -30.0 to indicate that the direction is in reverse.

Wednesday 16 Jun 2021
9:36 pm

Dara Navaei

Done.

Done.

9:33 pm

Dara Navaei

Good catch, thanks. I changed it.

Good catch, thanks. I changed it.

9:32 pm

Dara Navaei

I check in the inlet pressure only at the states that are needed. There are times that I am not even pulling water from the inlet line.

I check in the inlet pressure only at the states that are needed. There are times that I am not even pulling water from the inlet line.

9:31 pm

Dara Navaei

It is no longer needed.

It is no longer needed.

9:27 pm

Dara Navaei

2000 uS/cm is a safe value to determine if the acid is inserted in. Due to sensor to sensor variations, we decided to keep it a little lower than its conductivity value is.

2000 uS/cm is a safe value to determine if the acid is inserted in. Due to sensor to sensor variations, we decided to keep it a little lower than its conductivity value is.

9:15 pm

Dara Navaei

Done.

Done.

9:15 pm

Dara Navaei

We should keep this for now in case we wanted to lower the heaters duty cycle to previous limits.

We should keep this for now in case we wanted to lower the heaters duty cycle to previous limits.

8:32 pm

Dara Navaei

These functions are automatically generated once a HET driver is enabled in HALCoGen.

These functions are automatically generated once a HET driver is enabled in HALCoGen.

3:03 pm

Sean Nash

10:43 am

qnguyen  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:41 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:40 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:39 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:38 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:35 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:35 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:34 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:34 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:33 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:33 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:33 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:32 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:31 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:29 am

qnguyen  (deleted user)

Target speed has to set to get direction going before turning the pumps on.

Target speed has to set to get direction going before turning the pumps on.

10:26 am

qnguyen  (deleted user)

Do we need this include?

Do we need this include?

10:17 am

qnguyen  (deleted user)

Why is this check removed?

Why is this check removed?

10:13 am

qnguyen  (deleted user)

Should this value be higher? The user could be using wrong concentrate jug if it is too low?

Should this value be higher? The user could be using wrong concentrate jug if it is too low?

10:10 am

qnguyen  (deleted user)

This should be a separate if. Otherwise, this else if is not reachable.

This should be a separate if. Otherwise, this else if is not reachable.