dgfirmware / firmware / App

Modes

Clone Tools

Stats

Commits this week: 0
Total Committers: 15
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 19 Aug 2021
10:13 am

Quang Nguyen <qnguyen@diality.com>

DEN-7802: Addressed code review comments

Options
    • -4
    • +4
    ./ModeChemicalDisinfect.c
    • -2
    • +2
    ./ModeFault.c
    • -58
    • +19
    ./ModeFill.c
    • -4
    • +4
    ./ModeFlush.c
    • -2
    • +2
    ./ModeGenIdle.c
    • -4
    • +4
    ./ModeHeatDisinfect.c
  7. … 3 more files in changeset.
10:10 am

qnguyen  (deleted user)

Done.

Done.

10:10 am

qnguyen  (deleted user)

Done.

Done.

10:08 am

qnguyen  (deleted user)

Done.

Done.

9:26 am

Sean Nash

I would prefer we return a TRUE or FALSE explicitly (like function below).

I would prefer we return a TRUE or FALSE explicitly (like function below).

9:26 am

qnguyen  (deleted user)

Removed.

Removed.

9:25 am

Sean Nash

Start comments w/ capital letter.

Start comments w/ capital letter.

9:23 am

Sean Nash

I know bicarb pump "on" request above does not immediately turn the pump on, but I still think we should set target speed before we request pump on.

I know bicarb pump "on" request above does not immediately turn the pump on, but I still think we should set target speed before we request pump on.

9:22 am

Sean Nash

I know acid pump "on" request above does not immediately turn the pump on, but I still think we should set target speed before we request pump on.

I know acid pump "on" request above does not immediately turn the pump on, but I still think we should set target speed before we request pump on.

9:20 am

Sean Nash

Changes "Pumps" to "Pump". Request is for single pump.

Changes "Pumps" to "Pump". Request is for single pump.

9:15 am

Sean Nash

So we are not monitoring these, but we are publishing them?

So we are not monitoring these, but we are publishing them?

Wednesday 18 Aug 2021
4:55 pm

Quang Nguyen <qnguyen@diality.com>

DEN-7802: Removed concentrate pumps voltage monitor and fixed pressure checks

Options
    • -0
    • +5
    ./ModeInitPOST.c
  2. … 4 more files in changeset.
1:16 am

Quang Nguyen <qnguyen@diality.com>

Merge branch 'staging' into DEN-7802-dg_dev-dialysate-generation

Options
    • -7
    • +12
    ./ModeFill.c
    • -16
    • +41
    ./ModeFlush.c
    • -32
    • +33
    ./ModeGenIdle.c
    • -26
    • +45
    ./ModeHeatDisinfect.c
  5. … 18 more files in changeset.
12:59 am

qnguyen  (deleted user)

Removed as it is not needed anymore.

Removed as it is not needed anymore.

12:59 am

qnguyen  (deleted user)

Renamed to match new alarm ID.

Renamed to match new alarm ID.

12:56 am

Quang Nguyen <qnguyen@diality.com>

DEN-7802: Removed V2 system define

Options
    • -6
    • +0
    ./ModeDrain.c
    • -52
    • +1
    ./ModeFlush.c
    • -2
    • +0
    ./ModeGenIdle.c
    • -97
    • +0
    ./ModeHeatDisinfect.c
    • -12
    • +0
    ./ModeStandby.c
  6. … 5 more files in changeset.
Tuesday 17 Aug 2021
4:18 pm

Quang Nguyen <qnguyen@diality.com>

Revert "Merge branch 'DEN-9480-dialysate-temperature-control' into develop"

This reverts commit c0375e039dd42ecf7b7d68ce7f2407e52dfe83eb, reversing

changes made to 7838caf7aff7f6a3d890d21c13a4a695782c97bd.

Options
    • -3
    • +3
    ./ModeInitPOST.c
  2. … 10 more files in changeset.
11:14 am

Sean Nash

Made function void.

Made function void.

Friday 13 Aug 2021
5:55 pm

Dara Navaei

DEN-9480 added target RPM to the fans publication. Updated the load cells

Options
    • -1
    • +1
    ./ModeHeatDisinfect.c
  2. … 8 more files in changeset.
3:39 pm

Sean Nash

DEN-8886: Local merge from staging.

Options
    • -20
    • +42
    ./ModeInitPOST.c
    • -39
    • +43
    ./ModeRecirculate.c
  3. … 9 more files in changeset.
1:37 pm

Quang Nguyen <qnguyen@diality.com>

DEN-7802: Addressed code reviews

Options
    • -0
    • +4
    ./ModeFill.c
  2. … 3 more files in changeset.
11:23 am

qnguyen  (deleted user)

Missing return for non-void function.

Missing return for non-void function.

11:22 am

Quang Nguyen <qnguyen@diality.com>

Merge branch 'DEN-9480-dialysate-temperature-control' into develop

Options
    • -3
    • +3
    ./ModeInitPOST.c
  2. … 3 more files in changeset.
10:59 am

Dara Navaei

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:59 am

Dara Navaei

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:58 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:55 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:54 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:54 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:53 am

qnguyen  (deleted user)

Done.

Done.