Modes

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
DEN-9480 worked on developing new heaters control

  1. … 7 more files in changeset.
DEN-7802: Renamed re-circ to generation idle

  1. … 2 more files in changeset.
DEN-7802: Used test support get override value

  1. … 17 more files in changeset.
RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Done.

Done.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Done.

Done.

DEN-7802: Addressed code review comments

  1. … 3 more files in changeset.
Done.

Done.

Done.

Done.

Done.

Done.

I would prefer we return a TRUE or FALSE explicitly (like function below).

I would prefer we return a TRUE or FALSE explicitly (like function below).

Removed.

Removed.

Start comments w/ capital letter.

Start comments w/ capital letter.

I know bicarb pump "on" request above does not immediately turn the pump on, but I still think we should set target speed before we request pump on.

I know bicarb pump "on" request above does not immediately turn the pump on, but I still think we should set target speed before we request pump on.

I know acid pump "on" request above does not immediately turn the pump on, but I still think we should set target speed before we request pump on.

I know acid pump "on" request above does not immediately turn the pump on, but I still think we should set target speed before we request pump on.

Changes "Pumps" to "Pump". Request is for single pump.

Changes "Pumps" to "Pump". Request is for single pump.

So we are not monitoring these, but we are publishing them?

So we are not monitoring these, but we are publishing them?

DEN-7802: Removed concentrate pumps voltage monitor and fixed pressure checks

  1. … 4 more files in changeset.
Merge branch 'staging' into DEN-7802-dg_dev-dialysate-generation

  1. … 18 more files in changeset.
Removed as it is not needed anymore.

Removed as it is not needed anymore.