Activity dgfirmware/firmware/App/Modes

3:50 pm

Hung Nguyen <hnguyen@diality.com>

More
2f3090f
changed 4 files
DEN-11928-dg-conductivity-update-den-tbd, DEN-12224-dg_hd_dev-switches-monitor and 201 more DG-DEN-11928-1

DEN-11928 Updated code per peer reviews comments

- -12
- +17
./ModeFill.c
- History
- Source
- Diff
./ModeFill.c
… 3 more files in changeset.

2:55 pm

Michael Garthwaite

More
Re: DG-DEN-12121-1
replied to Sean Nash

Not Always. ovData will stay True until the Reset function is called (which is then assigned ovInitData's value). Our handler only calls the Set/Reset function. No parameters are given.

2:47 pm

Michael Garthwaite

Looks like it was commented out in this commit in August. http://dvm-linux02:7990/projects/DG/repos/dgfirmware/commits/47205a5002f27add91d8548f31c8a6fa18993fea#firmware/App/Services/SystemComm.c ...

Looks like it was commented out in this commit in August.

http://dvm-linux02:7990/projects/DG/repos/dgfirmware/commits/47205a5002f27add91d8548f31c8a6fa18993fea#firmware/App/Services/SystemComm.c

Should I uncomment it?

11:23 am

hnguyen (deleted user)

More
Re: DG-DEN-11928-1
replied to Sean Nash

set the RO pump rate to setROPumpTargetFlowRateLPM( getTargetFillFlowRateLPM(), TARGET_RO_PRESSURE_PSI );

set the RO pump rate to
setROPumpTargetFlowRateLPM( getTargetFillFlowRateLPM(), TARGET_RO_PRESSURE_PSI );

11:19 am

hnguyen (deleted user)

More
Re: DG-DEN-11928-1
replied to Sean Nash

Updated code to check for the difference in percent of conductivity between CD1 and CD2 and make sure it is < 5% otherwise alarm.

11:19 am

hnguyen (deleted user)

More
Re: DG-DEN-11928-1
replied to Sean Nash

Updated code to check for the difference in percent of conductivity between CD1 and CD2 and make sure it is < 5% otherwise alarm.

10:34 am

hnguyen (deleted user)

More
Re: DG-DEN-11928-1
replied to Sean Nash

Uncommented and recompiled without errors

8:53 pm

Dara Navaei

More
Re: DG-DEN-12121-1
commented on review

We do not have doxygen comments for the function declarations.

8:52 pm

Dara Navaei

More
Re: DG-DEN-12121-1
commented on review

Add a space.

8:52 pm

Dara Navaei

More
Re: DG-DEN-12121-1
commented on review

Add a space.

8:50 pm

Dara Navaei

More
Re: DG-DEN-12121-1
commented on review

I noticed you are using a U32 as a boolean without typecasting. I know a boolean is an unsigned integer behind the scenes but to be specific we should explicitly typecast.

8:45 pm

Dara Navaei

More
Re: DG-DEN-12121-1
commented on review

Why is this commented out?

2:37 pm

Stats

Commits this week: 0

Commit Activity

52 week commits volume

Commits by day

Commits by hour

Commit calendar

Most active committers (90 days)

hnguyen (deleted user)

hnguyen (deleted user)

hnguyen (deleted user)

hnguyen (deleted user)