Activity dgfirmware/firmware/App/Modes

9:32 am

Dara Navaei

More
2f13a0f
changed 2 files
DEN-14902-bootloader-for-dg, cdc-demo-branch-218 and 3 more

Pulled remote

- -1
- +1
./ModeDrain.c
- History
- Source
- Diff
./ModeDrain.c
… 1 more file in changeset.

9:31 am

Dara Navaei

More
9279d01
changed 12 files
DEN-14902-bootloader-for-dg, cdc-demo-branch-218 and 3 more

Merged DEN-11928

- -3
- +15
./ModeDrain.c
- History
- Source
- Diff
./ModeDrain.c
- -188
- +551
./ModeFill.c
- History
- Source
- Diff
./ModeFill.c
- -43
- +291
./ModeGenIdle.c
- History
- Source
- Diff
./ModeGenIdle.c
- -2
- +3
./ModeGenIdle.h
- History
- Source
- Diff
./ModeGenIdle.h
… 8 more files in changeset.

9:11 am

Dara Navaei

More
a096685
changed 3 files
DEN-12224-dg_hd_dev-switches-monitor, DEN-12845-sw_dev_sprint_s71_steve and 199 more DG-DEN-12224-7

DEN-12224 updated the fill mode and the drain mode and added build switches

- -2
- +4
./ModeDrain.c
- History
- Source
- Diff
./ModeDrain.c
- -10
- +8
./ModeFill.c
- History
- Source
- Diff
./ModeFill.c
… 1 more file in changeset.

7:14 pm

Dara Navaei

More
1722e97
changed 5 files
DEN-12224-dg_hd_dev-switches-monitor, DEN-12845-sw_dev_sprint_s71_steve and 199 more DG-DEN-12224-7

DEN-12224 updated the concentrate pumps, temperature sensors, mode drain and fill

- -19
- +25
./ModeDrain.c
- History
- Source
- Diff
./ModeDrain.c
- -69
- +54
./ModeFill.c
- History
- Source
- Diff
./ModeFill.c
- -3
- +10
./ModeFill.h
- History
- Source
- Diff
./ModeFill.h
… 2 more files in changeset.

9:07 pm

Dara Navaei

More
66cc826
changed 13 files
DEN-12224-dg_hd_dev-switches-monitor, DEN-12845-sw_dev_sprint_s71_steve and 199 more DG-DEN-12224-7

DEN-12224 merged staging

- -4
- +16
./ModeDrain.c
- History
- Source
- Diff
./ModeDrain.c
- -53
- +306
./ModeGenIdle.c
- History
- Source
- Diff
./ModeGenIdle.c
… 11 more files in changeset.

2:44 pm

Dara Navaei

More
c3d6651
changed 1 file
DEN-12224-dg_hd_dev-switches-monitor, DEN-12845-sw_dev_sprint_s71_steve and 199 more DG-DEN-12224-7

DEN-12224 updated the flush drain RPM

- -1
- +1
./ModeFlush.c
- History
- Source
- Diff
./ModeFlush.c

2:27 pm

Dara Navaei

More
604d8aa
changed 17 files
DEN-12224-dg_hd_dev-switches-monitor, DEN-12845-sw_dev_sprint_s71_steve and 200 more DG-DEN-12224-7

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

- -1
- +1
./ModeDrain.c
- History
- Source
- Diff
./ModeDrain.c
- -1
- +1
./ModeFill.c
- History
- Source
- Diff
./ModeFill.c
- -1
- +1
./ModeFill.h
- History
- Source
- Diff
./ModeFill.h
- -1
- +1
./ModeGenIdle.c
- History
- Source
- Diff
./ModeGenIdle.c
- -1
- +1
./ModeGenIdle.h
- History
- Source
- Diff
./ModeGenIdle.h
… 12 more files in changeset.

2:24 pm

Dara Navaei

More
DG-DEN-11928-1
Closed

2:08 pm

Sean Nash

More
DG-DEN-11928-1
finished reviewing

1:55 pm

Dara Navaei

More
c7ed4f9
changed 16 files
DEN-11928-dg-conductivity-update-den-tbd, DEN-12224-dg_hd_dev-switches-monitor and 201 more DG-DEN-11928-1

DEN-11928 merged staging

- -5
- +7
./ModeDrain.c
- History
- Source
- Diff
./ModeDrain.c
- -1
- +1
./ModeFill.c
- History
- Source
- Diff
./ModeFill.c
- -2
- +2
./ModeGenIdle.c
- History
- Source
- Diff
./ModeGenIdle.c
- -1
- +1
./ModeGenIdle.h
- History
- Source
- Diff
./ModeGenIdle.h
… 12 more files in changeset.

1:35 pm

Dara Navaei

More
ddeff95
changed 1 file
DEN-11928-dg-conductivity-update-den-tbd, DEN-12224-dg_hd_dev-switches-monitor and 201 more DG-DEN-11928-1

DEN-12224 addressed the code review comments

- -10
- +11
./ModeFill.c
- History
- Source
- Diff
./ModeFill.c

1:24 pm

Sean Nash

More
Re: DG-DEN-11928-1
replied to hnguyen (deleted user)

RESOLVED in WALKTHROUGH.

1:24 pm

Sean Nash

More
Re: DG-DEN-11928-1
replied to hnguyen (deleted user)

RESOLVED in WALKTHROUGH.

1:23 pm

Sean Nash

More
Re: DG-DEN-11928-1
replied to hnguyen (deleted user)

RESOLVED in WALKTHROUGH.

1:23 pm

Sean Nash

More
Re: DG-DEN-11928-1
replied to hnguyen (deleted user)

RESOLVED in WALKTHROUGH.

1:22 pm

Sean Nash

RESOLVED in WALKTHROUGH.

1:21 pm

Sean Nash

More
Re: DG-DEN-11928-1
replied to hnguyen (deleted user)

RESOLVED in WALKTHROUGH.

1:21 pm

Sean Nash

More
Re: DG-DEN-11928-1
replied to hnguyen (deleted user)

RESOLVED in WALKTHROUGH.

1:20 pm

Sean Nash

RESOLVED in WALKTHROUGH.

1:20 pm

Sean Nash

More
Re: DG-DEN-11928-1
replied to hnguyen (deleted user)

RESOLVED in WALKTHROUGH.

1:18 pm

Sean Nash

RESOLVED in WALKTHROUGH.

12:46 pm

Dara Navaei

More
Re: DG-DEN-11928-1
replied to Sean Nash

It is zeroed in transition function and it is not used until the acid state.

11:09 am

Dara Navaei

More
df73b89
changed 2 files
DEN-14902-bootloader-for-dg, cdc-demo-branch-218 and 3 more

Merge branch 'DEN-12224-dg_hd_dev-switches-monitor' into develop

- -1
- +1
./ModeDrain.c
- History
- Source
- Diff
./ModeDrain.c
… 1 more file in changeset.

9:09 am

Dara Navaei

More
674e18b
changed 4 files
DEN-11928-dg-conductivity-update-den-tbd, DEN-12224-dg_hd_dev-switches-monitor and 201 more DG-DEN-11928-1

DEN-11928 addressed the code review comments

- -2
- +27
./ModeFill.c
- History
- Source
- Diff
./ModeFill.c
- -23
- +28
./ModeGenIdle.c
- History
- Source
- Diff
./ModeGenIdle.c
- -0
- +3
./ModeGenIdle.h
- History
- Source
- Diff
./ModeGenIdle.h
… 1 more file in changeset.

9:38 pm

Dara Navaei

More
Re: DG-DEN-11928-1
replied to Sean Nash

Done.

9:33 pm

Dara Navaei

More
Re: DG-DEN-11928-1
replied to hnguyen (deleted user)

It is initialized in the init function and it is staggered.

8:55 pm

Dara Navaei

More
6f62e99
changed 4 files
DEN-11928-dg-conductivity-update-den-tbd, DEN-12224-dg_hd_dev-switches-monitor and 201 more DG-DEN-11928-1

DEN-11928 updated the fill mode and the RO pump

- -8
- +3
./ModeFill.c
- History
- Source
- Diff
./ModeFill.c
… 3 more files in changeset.

7:41 pm

Hung Nguyen <hnguyen@diality.com>

More
1786636
changed 1 file
DEN-11928-dg-conductivity-update-den-tbd, DEN-12224-dg_hd_dev-switches-monitor and 201 more DG-DEN-11928-1

DEN-11928 Corrected logic errors

- -2
- +2
./ModeFill.c
- History
- Source
- Diff
./ModeFill.c

4:31 pm

Dara Navaei

More
aa8dbad
changed 9 files
DEN-11928-dg-conductivity-update-den-tbd, DEN-12224-dg_hd_dev-switches-monitor and 201 more DG-DEN-11928-1

DEN-11928 updated the alarms and fill mode

- -37
- +16
./ModeFill.c
- History
- Source
- Diff
./ModeFill.c
- -2
- +3
./ModeFill.h
- History
- Source
- Diff
./ModeFill.h
… 7 more files in changeset.

3:31 pm

Hung Nguyen <hnguyen@diality.com>

More
c9368ea
changed 1 file
DEN-11928-dg-conductivity-update-den-tbd, DEN-12224-dg_hd_dev-switches-monitor and 201 more DG-DEN-11928-1

DEN-11928 Updated code per peer review

- -0
- +1
./ModeGenIdle.c
- History
- Source
- Diff
./ModeGenIdle.c

Modes

Stats

Commits this week: 0

Commit Activity

52 week commits volume

Commits by day

Commits by hour

Commit calendar

Most active committers (90 days)

Dara Navaei

Dara Navaei

Dara Navaei

Dara Navaei

Dara Navaei

Dara Navaei

Dara Navaei

Dara Navaei

Sean Nash

Dara Navaei

Dara Navaei

Sean Nash

Sean Nash

Sean Nash

Sean Nash

Sean Nash

Sean Nash

Sean Nash

Sean Nash

Sean Nash

Sean Nash

Dara Navaei

Dara Navaei

Dara Navaei

Dara Navaei

Dara Navaei

Dara Navaei

Hung Nguyen <hnguyen@diality.com>

Dara Navaei

Hung Nguyen <hnguyen@diality.com>