Modes

Clone Tools
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
DEN-12931 updated the drviers with DVT changes

  1. … 16 more files in changeset.
DEN-12974, DEN-13078 correct setting of VPo when entering handleFlushModeDrainR2State.

That would also require a change to the requirements.

That would also require a change to the requirements.

Seems like isADCValid should be returned.

Seems like isADCValid should be returned.

This will be addressed in DEN-12931.

This will be addressed in DEN-12931.

This will be addressed in DEN-12931.

This will be addressed in DEN-12931.

This will be addressed in DEN-12931.

This will be addressed in DEN-12931.

This will be addressed in DEN-12931.

This will be addressed in DEN-12931.

This will be addressed in DEN-12931.

This will be addressed in DEN-12931.

This will be addressed in DEN-12931.

This will be addressed in DEN-12931.

Removed blank line

Removed blank line

Will add back in.

Will add back in.

Should we return isADCValid? Pick one, remove the other.

Should we return isADCValid? Pick one, remove the other.

Can we remove this code now?

Can we remove this code now?

Why is this commented out?

Why is this commented out?

Can we just remove this code now?

Can we just remove this code now?

Does this function activate alarm too? Why needed if line above activates alarm already? Why commented out?

Does this function activate alarm too? Why needed if line above activates alarm already? Why commented out?

Why is this alarm commented out?

Why is this alarm commented out?

I think we need two separate minimums here. 1. used by ROPump.c should be 0.2 and private (declared in ROPump.c) with this name. 2. used by UVReactors.c should be 0.3 and private (declared in UVRea...

I think we need two separate minimums here.
1. used by ROPump.c should be 0.2 and private (declared in ROPump.c) with this name.
2. used by UVReactors.c should be 0.3 and private (declared in UVReactors.c) with a different name like MIN_RO_FLOW_FOR_UV_LPM.

Remove extra blank line.

Remove extra blank line.

Why did this change? I think it's needed for doxygen.

Why did this change? I think it's needed for doxygen.

DG-DEN-12974_Miscellaneous Flush Issues BB
DG-DEN-12974_Miscellaneous Flush Issues BB
DEN-12974, DEN-13078 Set VPo to VALVE_STATE_NOFILL_C_TO_NO in DrainR2State.

Merge remote-tracking branch 'origin/DEN-12974-miscellaneous-flush-issues_bb' into develop

# Conflicts:

# firmware/App/Controllers/ConductivitySensors.c

# firmware/App/Controllers/ROPump.c

  1. … 2 more files in changeset.
DEN-12931 updated the heaters driver and DVT

  1. … 13 more files in changeset.
DEN-12974, DEN-13078 correct setting of VPo when entering Drain_R1 and Drain_R2

Merge remote-tracking branch 'origin/DEN-12974-miscellaneous-flush-issues_bb' into develop

  1. … 3 more files in changeset.
Revert "DEN-13047 Implement unique haveDrainParamsBeenInit for both reservoirs."

This reverts commit 81872acd6f2ce222c6b9a9b93f65b7cd3665f28f.

  1. … 2 more files in changeset.