dgfirmware / firmware / App

Modes

Clone Tools

Stats

Commits this week: 0
Total Committers: 15
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 06 Jul 2022
9:52 pm

Dara Navaei

DEN-12931 updated the drviers with DVT changes

Options
    • -0
    • +7
    ./ModeInitPOST.c
    • -0
    • +1
    ./ModeService.c
  3. … 16 more files in changeset.
1:38 pm

Bill Bracken <bill@criticalsoftwaresolutions.com>

DEN-12974, DEN-13078 correct setting of VPo when entering handleFlushModeDrainR2State.

Options
    • -0
    • +1
    ./ModeFlush.c
10:54 am

wbracken  (deleted user)

That would also require a change to the requirements.

That would also require a change to the requirements.

Tuesday 28 Jun 2022
11:01 am

wbracken  (deleted user)

Seems like isADCValid should be returned.

Seems like isADCValid should be returned.

11:00 am

Dara Navaei

This will be addressed in DEN-12931.

This will be addressed in DEN-12931.

11:00 am

Dara Navaei

This will be addressed in DEN-12931.

This will be addressed in DEN-12931.

11:00 am

Dara Navaei

This will be addressed in DEN-12931.

This will be addressed in DEN-12931.

11:00 am

Dara Navaei

This will be addressed in DEN-12931.

This will be addressed in DEN-12931.

11:00 am

Dara Navaei

This will be addressed in DEN-12931.

This will be addressed in DEN-12931.

11:00 am

Dara Navaei

This will be addressed in DEN-12931.

This will be addressed in DEN-12931.

10:41 am

wbracken  (deleted user)

Removed blank line

Removed blank line

10:38 am

wbracken  (deleted user)

Will add back in.

Will add back in.

9:01 am

Sean Nash

Should we return isADCValid? Pick one, remove the other.

Should we return isADCValid? Pick one, remove the other.

8:59 am

Sean Nash

Can we remove this code now?

Can we remove this code now?

8:59 am

Sean Nash

Why is this commented out?

Why is this commented out?

8:58 am

Sean Nash

Can we just remove this code now?

Can we just remove this code now?

8:58 am

Sean Nash

Does this function activate alarm too? Why needed if line above activates alarm already? Why commented out?

Does this function activate alarm too? Why needed if line above activates alarm already? Why commented out?

8:56 am

Sean Nash

Why is this alarm commented out?

Why is this alarm commented out?

8:55 am

Sean Nash

I think we need two separate minimums here. 1. used by ROPump.c should be 0.2 and private (declared in ROPump.c) with this name. 2. used by UVReactors.c should be 0.3 and private (declared in UVRea...

I think we need two separate minimums here.
1. used by ROPump.c should be 0.2 and private (declared in ROPump.c) with this name.
2. used by UVReactors.c should be 0.3 and private (declared in UVReactors.c) with a different name like MIN_RO_FLOW_FOR_UV_LPM.

8:51 am

Sean Nash

Remove extra blank line.

Remove extra blank line.

8:49 am

Sean Nash

Why did this change? I think it's needed for doxygen.

Why did this change? I think it's needed for doxygen.

Saturday 25 Jun 2022
8:19 pm

Dara Navaei

DG-DEN-12974_Miscellaneous Flush Issues BB
DG-DEN-12974_Miscellaneous Flush Issues BB
Thursday 23 Jun 2022
4:26 pm

Bill Bracken <bill@criticalsoftwaresolutions.com>

DEN-12974, DEN-13078 Set VPo to VALVE_STATE_NOFILL_C_TO_NO in DrainR2State.

Options
    • -0
    • +1
    ./ModeFlush.c
2:57 pm

Bill Bracken <bill@criticalsoftwaresolutions.com>

Merge remote-tracking branch 'origin/DEN-12974-miscellaneous-flush-issues_bb' into develop

# Conflicts:

# firmware/App/Controllers/ConductivitySensors.c

# firmware/App/Controllers/ROPump.c

Options
    • -0
    • +7
    ./ModeFlush.c
  2. … 2 more files in changeset.
Tuesday 21 Jun 2022
5:33 pm

Dara Navaei

DEN-12931 updated the heaters driver and DVT

Options
    • -8
    • +8
    ./ModeFill.c
    • -1
    • +1
    ./ModeFill.h
  3. … 13 more files in changeset.
Monday 20 Jun 2022
5:04 pm

Bill Bracken <bill@criticalsoftwaresolutions.com>

DEN-12974, DEN-13078 correct setting of VPo when entering Drain_R1 and Drain_R2

Options
    • -0
    • +7
    ./ModeFlush.c
Friday 17 Jun 2022
3:38 pm

Bill Bracken <bill@criticalsoftwaresolutions.com>

Merge remote-tracking branch 'origin/DEN-12974-miscellaneous-flush-issues_bb' into develop

Options
    • -29
    • +28
    ./ModeChemicalDisinfect.c
    • -24
    • +23
    ./ModeFlush.c
    • -34
    • +33
    ./ModeHeatDisinfect.c
  4. … 3 more files in changeset.
3:31 pm

Bill Bracken <bill@criticalsoftwaresolutions.com>

Revert "DEN-13047 Implement unique haveDrainParamsBeenInit for both reservoirs."

This reverts commit 81872acd6f2ce222c6b9a9b93f65b7cd3665f28f.

Options
    • -29
    • +28
    ./ModeChemicalDisinfect.c
    • -24
    • +23
    ./ModeFlush.c
    • -34
    • +33
    ./ModeHeatDisinfect.c
  4. … 2 more files in changeset.
Tuesday 14 Jun 2022
5:27 pm

Dara Navaei

5:07 pm

Sean Nash and Michael Garthwaite