dgfirmware / firmware / App

Modes

Clone Tools

Stats

Commits this week: 0
Total Committers: 15
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 01 Aug 2022
5:16 pm

Sean Nash

DEN-13460: Fixed 2 broadcast interval bugs.

Options
    • -1
    • +1
    ./ModeStandby.c
  2. … 1 more file in changeset.
2:52 pm

wbracken  (deleted user)

Remove comment at end of line. Is fpgaReadByteSize replacing sizeof(DG_FPGA_SENSORS_T)?

Remove comment at end of line. Is fpgaReadByteSize replacing sizeof(DG_FPGA_SENSORS_T)?

2:46 pm

wbracken  (deleted user)

Remove comment at end of line? sam for 710/822.

Remove comment at end of line? sam for 710/822.

10:44 am

wbracken  (deleted user)

Does the monitorPumpSpeed function generate the alarm

Does the monitorPumpSpeed function generate the alarm

Thursday 28 Jul 2022
10:41 am

Michael Garthwaite

DEN-13427: DG Service Mode deenergizes and can Fault

Service Mode deenergizes actuators when we enter the mode. Fault is raised in Service Mode if we get a submode out of range.

Options
    • -2
    • +7
    ./ModeService.c
    • -0
    • +1
    ./ModeService.h
  3. … 1 more file in changeset.
Wednesday 27 Jul 2022
3:29 pm

Sean Nash

Merge branch 'DEN-13460-dg_hd_dev-hd_dg_dvt-update-part-2' of ssh://dvm-linux02:7999/dg/dgfirmware into DEN-13460-dg_hd_dev-hd_dg_dvt-update-part-2

Options
    • -3
    • +7
    ./ModeFill.c
3:29 pm

Sean Nash

DEN-13460: Reset bad fill state in gen idle mode when detecting bad fill in case 2 bad fills back to back edge case.

Options
    • -1
    • +3
    ./ModeFill.c
    • -0
    • +1
    ./ModeGenIdle.c
  3. … 1 more file in changeset.
3:20 pm

Bill Bracken <bill@criticalsoftwaresolutions.com>

DEN-12974 DEN-13556 Correct logic per SRSDG 333.

Options
    • -2
    • +2
    ./ModeHeatDisinfect.c
3:00 pm

Bill Bracken <bill@criticalsoftwaresolutions.com>

DEN12974 DEN-13558 Do not reset stateTimer in FlushR2AndDrainR1. Same issue will be in ModeChemicalDisinfect.

Options
    • -35
    • +41
    ./ModeChemicalDisinfect.c
    • -6
    • +6
    ./ModeHeatDisinfect.c
2:11 pm

Bill Bracken <bill@criticalsoftwaresolutions.com>

DEN-12974 DEN-13560 Do not reset stateTimer in FlushR1AndR2.

Options
    • -1
    • +1
    ./ModeChemicalDisinfect.c
    • -33
    • +39
    ./ModeHeatDisinfect.c
Tuesday 26 Jul 2022
4:01 pm

Dara Navaei

DEN-13460 updated the heaters with the latest primary heater gain check

Options
    • -4
    • +8
    ./ModeFill.c
    • -1
    • +1
    ./ModeStandby.c
  3. … 4 more files in changeset.
Saturday 23 Jul 2022
2:46 pm

Sean Nash

Should 0.5 be a #define?

Should 0.5 be a #define?

2:45 pm

Sean Nash

TODO should be all CAPS.

TODO should be all CAPS.

2:43 pm

Sean Nash

Is it really true that all function below this line are DVT?

Is it really true that all function below this line are DVT?

2:42 pm

Sean Nash

If these comment outs are not permanent, add a TODO. Otherwise remove the commented out code.

If these comment outs are not permanent, add a TODO. Otherwise remove the commented out code.

2:37 pm

Sean Nash

Is this logic right? Looks like it should be || instead of && and it should be == instead of != DG_MODE_INIT.

Is this logic right? Looks like it should be || instead of && and it should be == instead of != DG_MODE_INIT.

2:35 pm

Sean Nash

No point in initializing here - gets set by exec function.

No point in initializing here - gets set by exec function.

2:29 pm

Sean Nash

Is this a TODO?

Is this a TODO?

2:26 pm

Sean Nash

Fix alignment.

Fix alignment.

2:25 pm

Sean Nash

Fix alignment.

Fix alignment.

2:24 pm

Sean Nash

Should go to NV data POST state regardless of RTC pass/fail. Still need to get calibration and system records read.

Should go to NV data POST state regardless of RTC pass/fail. Still need to get calibration and system records read.

1:52 pm

Sean Nash

Keep this blank line.

Keep this blank line.

1:51 pm

Sean Nash

Magic number.

Magic number.

1:51 pm

Sean Nash

Keep this blank line.

Keep this blank line.

1:50 pm

Sean Nash

Add blank line between declarations and code.

Add blank line between declarations and code.

1:50 pm

Sean Nash

Add comments like others.

Add comments like others.

1:49 pm

Sean Nash

DVT software configuration?

DVT software configuration?

1:46 pm

Sean Nash

Keep this blank line.

Keep this blank line.

1:45 pm

Sean Nash

Flow rate is F32 so change 0 to 0.0F.

Flow rate is F32 so change 0 to 0.0F.

1:42 pm

Sean Nash

Fix alignment.

Fix alignment.