Activity dgfirmware/firmware/App/Modes

10:36 am

Steve Jarpe <sjarpe@diality.com>

More
3fae8c2
changed 1 file
DEN-13050-vpi-does-not-close-after-sample-water-returns-to-flush-idle, DEN-13154-heparin-syringe-empty-position-incorrect and 175 more DG-DEN-14316-1

DEN-14316. Initial modifications of ModeChemicalDisinfect.c for new chem disinfect process. Some new states have been added but not fully implmemented and are currently not active

- -1038
- +485
./ModeChemicalDisinfect.c
- History
- Source
- Diff
./ModeChemicalDisinfect.c

9:27 am

Dara Navaei

More
DG-DEN-14316-1
started review

DG-DEN-14316_Chemical Disinfect

7:29 pm

Dara Navaei

More
DG-DEN-14307-1
started review

DG-DEN-14307_DG HD Dev HD DG Dvt Update Part 6

5:57 pm

Dara Navaei

More
715b851
changed 2 files
DEN-13050-vpi-does-not-close-after-sample-water-returns-to-flush-idle, DEN-13154-heparin-syringe-empty-position-incorrect and 181 more DG-DEN-14197-1

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

- -1
- +1
./ModeFill.c
- History
- Source
- Diff
./ModeFill.c
- -1
- +1
./ModeHeatDisinfect.c
- History
- Source
- Diff
./ModeHeatDisinfect.c

5:55 pm

Dara Navaei and Sean Nash

More
DG-DEN-14237-1
finished reviewing

11:11 am

Dara Navaei

More
8810c50
changed 1 file
DEN-13050-vpi-does-not-close-after-sample-water-returns-to-flush-idle, DEN-13154-heparin-syringe-empty-position-incorrect and 182 more DG-DEN-14237-1

DEN-14237 added the _RELEASE_ macro around a configuration check in ModeFill

- -0
- +2
./ModeFill.c
- History
- Source
- Diff
./ModeFill.c

1:14 pm

Bill Bracken <bill@criticalsoftwaresolutions.com>

More
56880de
changed 1 file
DEN-13050-vpi-does-not-close-after-sample-water-returns-to-flush-idle, DEN-13154-heparin-syringe-empty-position-incorrect and 182 more DG-DEN-14237-1

Merge branch 'staging' into DEN-14237-remove-heat-disinfect-rinse-states

# Conflicts:

# firmware/App/Modes/ModeHeatDisinfect.c

- -28
- +32
./ModeHeatDisinfect.c
- History
- Source
- Diff
./ModeHeatDisinfect.c

10:35 am

Dara Navaei

More
9cc5da6
changed 23 files
DEN-13050-vpi-does-not-close-after-sample-water-returns-to-flush-idle, DEN-13154-heparin-syringe-empty-position-incorrect and 182 more DG-DEN-14101-1 DG-DEN-14197-1 DG-DEN-14237-1

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

- -1
- +1
./ModeFill.c
- History
- Source
- Diff
./ModeFill.c
- -1
- +1
./ModeFill.h
- History
- Source
- Diff
./ModeFill.h
- -1
- +1
./ModeHeatDisinfect.c
- History
- Source
- Diff
./ModeHeatDisinfect.c
… 20 more files in changeset.

10:34 am

wbracken (deleted user) and Sean Nash

More
DG-DEN-14175-1
finished reviewing

10:19 am

wbracken (deleted user)

RESOLVED IN CODE WALKTHROUGH

10:04 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

9:10 am

Dara Navaei

More
985bd4c
changed 2 files
DEN-13050-vpi-does-not-close-after-sample-water-returns-to-flush-idle, DEN-13154-heparin-syringe-empty-position-incorrect and 183 more DG-DEN-14175-1

DEN-14175 addressed the code review comments

- -3
- +1
./ModeHeatDisinfect.c
- History
- Source
- Diff
./ModeHeatDisinfect.c
… 1 more file in changeset.

9:08 am

Dara Navaei

More
Re: DG-DEN-14175-1
replied to Sean Nash

Done.

9:07 am

Dara Navaei

More
Re: DG-DEN-14175-1
replied to wbracken (deleted user)

Done.

3:05 pm

wbracken (deleted user)

More
Re: DG-DEN-14175-1
commented on review

Isn't fpgaSensorReadings an input?

2:23 pm

Sean Nash

More
Re: DG-DEN-14175-1
commented on review

Restore or remove.

1:04 pm

Dara Navaei

More
d28018e
changed 1 file
DEN-13050-vpi-does-not-close-after-sample-water-returns-to-flush-idle, DEN-13154-heparin-syringe-empty-position-incorrect and 183 more DG-DEN-14175-1

DEN-14175 merged staging

- -10
- +17
./ModeHeatDisinfect.c
- History
- Source
- Diff
./ModeHeatDisinfect.c

1:02 pm

Dara Navaei

More
7cc7794
changed 1 file
DEN-13050-vpi-does-not-close-after-sample-water-returns-to-flush-idle, DEN-13154-heparin-syringe-empty-position-incorrect and 183 more DG-DEN-14175-1

DEN-14175 uncommented the code that was commented to test heat disinfect drain/RO pumps

- -17
- +9
./ModeHeatDisinfect.c
- History
- Source
- Diff
./ModeHeatDisinfect.c

3:14 pm

Michael Garthwaite

More
2b6abbe
changed 5 files
DEN-13050-vpi-does-not-close-after-sample-water-returns-to-flush-idle, DEN-13154-heparin-syringe-empty-position-incorrect and 180 more DG-DEN-14197-1

DEN-14197: updated Dialin msg handling DIAL-200: Implemented handler for total fill volume override. Implemented fill mode broadcast override handler. DIAL-212: Implemented RO feedback voltage override handler.