Activity dgfirmware/firmware/App/Modes

2:30 pm

Dara Navaei

More
eceb190
changed 17 files
DEN-13050-vpi-does-not-close-after-sample-water-returns-to-flush-idle, DEN-13154-heparin-syringe-empty-position-incorrect and 175 more DG-DEN-14307-1 DG-DEN-14101-1

Merged staging

- -1302
- +856
./ModeChemicalDisinfect.c
- History
- Source
- Diff
./ModeChemicalDisinfect.c
- -0
- +1073
./ModeChemicalDisinfectFlush.c
- History
- Source
- Diff
./ModeChemicalDisinfectFlush.c
- -2
- +2
./ModeDrain.c
- History
- Source
- Diff
./ModeDrain.c
- -10
- +69
./ModeFill.c
- History
- Source
- Diff
./ModeFill.c
- -2
- +2
./ModeFlush.c
- History
- Source
- Diff
./ModeFlush.c
- -4
- +4
./ModeGenIdle.c
- History
- Source
- Diff
./ModeGenIdle.c
- -4
- +7
./ModeHeatDisinfect.c
- History
- Source
- Diff
./ModeHeatDisinfect.c
- -4
- +63
./ModeStandby.c
- History
- Source
- Diff
./ModeStandby.c
- -3
- +4
./ModeStandby.h
- History
- Source
- Diff
./ModeStandby.h
- -2
- +11
./OperationModes.c
- History
- Source
- Diff
./OperationModes.c
… 7 more files in changeset.

1:40 pm

Dara Navaei

More
3d977e0
changed 12 files
DEN-13050-vpi-does-not-close-after-sample-water-returns-to-flush-idle, DEN-13154-heparin-syringe-empty-position-incorrect and 175 more DG-DEN-14307-1

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

- -2
- +2
./ModeChemicalDisinfect.c
- History
- Source
- Diff
./ModeChemicalDisinfect.c
- -5
- +5
./ModeChemicalDisinfectFlush.c
- History
- Source
- Diff
./ModeChemicalDisinfectFlush.c
- -5
- +5
./ModeChemicalDisinfectFlush.h
- History
- Source
- Diff
./ModeChemicalDisinfectFlush.h
- -2
- +2
./ModeFlush.c
- History
- Source
- Diff
./ModeFlush.c
- -2
- +2
./ModeStandby.c
- History
- Source
- Diff
./ModeStandby.c
- -2
- +2
./ModeStandby.h
- History
- Source
- Diff
./ModeStandby.h
- -2
- +2
./OperationModes.c
- History
- Source
- Diff
./OperationModes.c
… 5 more files in changeset.

1:36 pm

Dara Navaei

More
DG-DEN-14316-1
Closed

1:32 pm

Sean Nash

More
DG-DEN-14316-1
finished reviewing

1:24 pm

Dara Navaei

More
d32847d
changed 6 files
DEN-13050-vpi-does-not-close-after-sample-water-returns-to-flush-idle, DEN-13154-heparin-syringe-empty-position-incorrect and 175 more DG-DEN-14316-1

DEN-14316 merged staging

- -2
- +3
./ModeStandby.c
- History
- Source
- Diff
./ModeStandby.c
… 5 more files in changeset.

1:05 pm

Dara Navaei

More
35cbd8e
changed 1 file
DEN-13050-vpi-does-not-close-after-sample-water-returns-to-flush-idle, DEN-13154-heparin-syringe-empty-position-incorrect and 175 more DG-DEN-14307-1

DEN-14307 addressed the code review comment

- -1
- +1
./ModeFlush.c
- History
- Source
- Diff
./ModeFlush.c

1:04 pm

Dara Navaei

More
Re: DG-DEN-14307-1
replied to wbracken (deleted user)

Done

1:04 pm

Sean Nash

More
Re: DG-DEN-14307-1
replied to Sean Nash

RESOLVED in CODE WALKTHROUGH.

12:52 pm

Sean Nash

More
523e9d3
changed 1 file
DEN-13050-vpi-does-not-close-after-sample-water-returns-to-flush-idle, DEN-13154-heparin-syringe-empty-position-incorrect and 175 more DG-DEN-14316-1

DEN-14316: Addressed code review comments.

- -5
- +6
./ModeChemicalDisinfectFlush.c
- History
- Source
- Diff
./ModeChemicalDisinfectFlush.c

12:52 pm

Sean Nash

More
Re: DG-DEN-14316-1
replied to wbracken (deleted user)

RESOLVED in CODE WALKTHROUGH.

12:50 pm

Sean Nash

More
Re: DG-DEN-14316-1
replied to wbracken (deleted user)

RESOLVED in CODE WALKTHROUGH.

12:48 pm

Sean Nash

More
Re: DG-DEN-14316-1
replied to wbracken (deleted user)

RESOLVED in CODE WALKTHROUGH.

12:46 pm

Sean Nash

More
Re: DG-DEN-14316-1
replied to wbracken (deleted user)

RESOLVED in CODE WALKTHROUGH.

12:13 pm

wbracken (deleted user)

RESOLVED IN CODEWALKTHROUGH.

12:12 pm

wbracken (deleted user)

Should add alarmDetectedPendingTrigger and preFlushState.

12:10 pm

wbracken (deleted user)

RESOLVED IN CODEWALKTHROUGH.

12:09 pm

wbracken (deleted user)

More
Re: DG-DEN-14307-1
replied to wbracken (deleted user)

RESOLVED IN CODEWALKTHROUGH.

12:06 pm

wbracken (deleted user)

More
Re: DG-DEN-14307-1
replied to wbracken (deleted user)

RESOLVED IN CODEWALKTHROUGH.

12:05 pm

wbracken (deleted user)

RESOLVED IN CODEWALKTHROUGH.

11:50 am

wbracken (deleted user)

drainTimer, waitTimer

11:48 am

wbracken (deleted user)

drainTimer, numberOfPostDisinfectRinses, rsrvFillFillToFullStableTimerCounter

11:44 am

wbracken (deleted user)

More
Re: DG-DEN-14316-1
replied to wbracken (deleted user)

RESOLVED IN CODE WALKTHROUGH.

11:43 am

wbracken (deleted user)

More
Re: DG-DEN-14316-1
replied to wbracken (deleted user)

RESOLVED IN CODE WALKTHROUGH.

11:41 am

wbracken (deleted user)

More
Re: DG-DEN-14316-1
replied to wbracken (deleted user)

prevChemDisinfectFlushState is not used.

11:37 am

wbracken (deleted user)

RESOLVED IN CODEWALKTHROUGH.

11:36 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

11:36 am

wbracken (deleted user)

It is definitely in the code.

11:35 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

11:34 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

11:34 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

Modes

Stats

Commits this week: 0

Commit Activity

52 week commits volume

Commits by day

Commits by hour

Commit calendar

Most active committers (90 days)

Dara Navaei

Dara Navaei

Dara Navaei

Sean Nash

Dara Navaei

Dara Navaei

Dara Navaei

Sean Nash

Sean Nash

Sean Nash

Sean Nash

Sean Nash

Sean Nash

wbracken (deleted user)

wbracken (deleted user)

wbracken (deleted user)

wbracken (deleted user)

wbracken (deleted user)

wbracken (deleted user)

wbracken (deleted user)

wbracken (deleted user)

wbracken (deleted user)

wbracken (deleted user)

wbracken (deleted user)

wbracken (deleted user)

Sean Nash

wbracken (deleted user)

Sean Nash

Sean Nash

Sean Nash