Modes

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Seems like there are several variables missing.

Seems like there are several variables missing.

DG-DEN-14604_DG HD Dev HD DG Dvt Update Part 9
DG-DEN-14604_DG HD Dev HD DG Dvt Update Part 9
Removed

Removed

This looks strange. Why is TD2 temp usually 0.0, but read if using TPo?

This looks strange. Why is TD2 temp usually 0.0, but read if using TPo?

Prefer doing this kind of thing with a loop iterating through the enum in case we add/remove a reservoir.

Prefer doing this kind of thing with a loop iterating through the enum in case we add/remove a reservoir.

Does hasAlarmBeenTriggered need to be set here too? If not, need to clarify what that flag really means.

Does hasAlarmBeenTriggered need to be set here too? If not, need to clarify what that flag really means.

Need to be careful with these. These functions are currently resetting the POST functions to start at beginning, but also need to reset ANY variables that the POST functions use/set (not override v...

Need to be careful with these.
These functions are currently resetting the POST functions to start at beginning, but also need to reset ANY variables that the POST functions use/set (not override variables though).
Also, since we are not re-initializing everything like a true reset does, we need to make sure that these modules are setup to restart or resume (whichever is more appropriate for the module) after POST completes if the module is in any way interrupted/deferred by POST or competing with POST for a resource/driver (e.g. RTC or NV-Data).

Variable should already be a BOOL.

Variable should already be a BOOL.

Set to TRUE here.

Set to TRUE here.

Initialize to FALSE.

Initialize to FALSE.

Rename to isDGFaultActive.

Rename to isDGFaultActive.

Name is too broad and comment is too specific. Should probably be a BOOL flag that indicates there is an active DG fault.

Name is too broad and comment is too specific. Should probably be a BOOL flag that indicates there is an active DG fault.

This alarm does not appear to be available. Correct description in last column (trigger condition).

This alarm does not appear to be available. Correct description in last column (trigger condition).

Do we need to re-queue these reads? We've already done it at real POST. And if we do need to queue them, why does queue have to be empty? Shouldn't we always queue them if they're needed?

Do we need to re-queue these reads? We've already done it at real POST. And if we do need to queue them, why does queue have to be empty? Shouldn't we always queue them if they're needed?

Is this #define still used/needed?

Is this #define still used/needed?

DG-DEN-14561_Release Preprocessor Flag Specifies Code That Conflicts With SW Config Debug
DG-DEN-14561_Release Preprocessor Flag Specifies Code That Conflicts With SW Config Debug
Alignment

Alignment

Alignment

Alignment

DG-DEN-13676_Bicarb Low Alarm Threshold Incorrect
DG-DEN-13676_Bicarb Low Alarm Threshold Incorrect
DG-DEN-14559_DG HD Dev HD DG Dvt Update Part 8
DG-DEN-14559_DG HD Dev HD DG Dvt Update Part 8
RESOLVED IN CODEWALKTHROUGH.

RESOLVED IN CODEWALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH.