dgfirmware / firmware / App

Modes

Clone Tools

Stats

Commits this week: 0
Total Committers: 15
Last Commit: 10 Jun
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 20 Mar 2023
8:42 pm

Dara Navaei

DEN-14763 merged staging

Options
    • -3
    • +3
    ./ModeStandby.c
    • -2
    • +2
    ./OperationModes.c
  3. … 2 more files in changeset.
8:31 pm

wbracken  (deleted user) and jtaylor  (deleted user)

4:34 pm

jtaylor  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

1:32 pm

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

12:01 pm

Dara Navaei

DG-DEN-14788_DIAL-243_integrated_fill_incorrect
DG-DEN-14788_DIAL-243_integrated_fill_incorrect
9:49 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

9:48 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

9:48 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

9:45 am

Dara Navaei

DEN-14763 addressed the code review comments

Options
    • -20
    • +29
    ./ModeHeatDisinfectActiveCool.c
9:34 am

Dara Navaei

Done. Thanks for catching it.

Done. Thanks for catching it.

9:33 am

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -2
    • +2
    ./ModeStandby.c
    • -1
    • +1
    ./OperationModes.c
  3. … 7 more files in changeset.
9:30 am

Michael Garthwaite

9:28 am

Dara Navaei

Done

Done

9:28 am

Dara Navaei

Done

Done

9:18 am

Sean Nash

8:57 am

Sean Nash

Not all of these are disinfect usage (e.g. RO water generated) so I don't think disinfect_usage is appropriate. I am ok with usage_info, though I think DG_USAGE_INFO is better.

Not all of these are disinfect usage (e.g. RO water generated) so I don't think disinfect_usage is appropriate. I am ok with usage_info, though I think DG_USAGE_INFO is better.

8:48 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

8:43 am

Sean Nash

Missing comment?

Missing comment?

8:42 am

Sean Nash

Everything else in this function should be in an else body if given reservoir ID is invalid so we don't try to use an invalid ID.

Everything else in this function should be in an else body if given reservoir ID is invalid so we don't try to use an invalid ID.

8:36 am

Sean Nash

Why lower case when others are uppercase?

Why lower case when others are uppercase?

Sunday 19 Mar 2023
2:45 pm

Dara Navaei

DEN-14763, DEN-14960 added an event to report the reservoir base weight and filled volume at the end of the fill mode.

Options
    • -0
    • +1
    ./ModeFill.c
Saturday 18 Mar 2023
2:43 pm

Dara Navaei

DEN-14763 addressed the code review comments'

Options
    • -1
    • +1
    ./ModeHeatDisinfectActiveCool.c
  2. … 2 more files in changeset.
2:41 pm

Dara Navaei

This is to find the target configuration which in our case it is XDS-110 automatically. It seems the .ccxml file in the targetConfigs folder sets the right debugger and target regardless of this ch...

This is to find the target configuration which in our case it is XDS-110 automatically. It seems the .ccxml file in the targetConfigs folder sets the right debugger and target regardless of this check box being true or false. I set it back to true to be consistent.

Friday 17 Mar 2023
2:42 pm

Dara Navaei

Done

Done

8:56 am

jtaylor  (deleted user)

I would suggest a more consistent naming for the enum items. "DISINFECT_USAGE_" rather than USAGE_INFO_ in the enum elements, and eliminating the "_DIS". This would be more specific since "USAGE" a...

I would suggest a more consistent naming for the enum items. "DISINFECT_USAGE_" rather than USAGE_INFO_ in the enum elements, and eliminating the "_DIS".
This would be more specific since "USAGE" and "INFO" are redundant, and "DIS" can be confused with "dis-", the Latin prefix.

Thursday 16 Mar 2023
10:08 pm

wbracken  (deleted user)

Comment alignment.

Comment alignment.

8:33 pm

Dara Navaei

DEN-14763 updated the heat disinfect active cool per the requirements

Options
    • -24
    • +38
    ./ModeHeatDisinfectActiveCool.c
2:01 pm

Michael Garthwaite

Merge branch 'DIAL-243-integrated-volume-is-not-working' into develop

Options
    • -1
    • +1
    ./ModeFill.c
  2. … 1 more file in changeset.
2:00 pm

Michael Garthwaite

DIAL-243: Fixed header.

Options
    • -1
    • +1
    ./ModeFill.h
1:57 pm

Michael Garthwaite

DIAL-243: fixed integrated volume data type from u32 to f32

Options
    • -1
    • +1
    ./ModeFill.c
  2. … 1 more file in changeset.