Modes

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
DG-DEN-15014_DG HD Dev HD DG Dvt Update Part 11
DG-DEN-15014_DG HD Dev HD DG Dvt Update Part 11
DG-DEN-14999_Alarm Table Updates
DG-DEN-14999_Alarm Table Updates
RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Done

Done

Done

Done

This seems wrong.

This seems wrong.

This seems wrong.

This seems wrong.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

DG-DEN-14788_DIAL-243_integrated_fill_incorrect
DG-DEN-14788_DIAL-243_integrated_fill_incorrect
RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Done. Thanks for catching it.

Done. Thanks for catching it.

Done

Done

Done

Done

Not all of these are disinfect usage (e.g. RO water generated) so I don't think disinfect_usage is appropriate. I am ok with usage_info, though I think DG_USAGE_INFO is better.

Not all of these are disinfect usage (e.g. RO water generated) so I don't think disinfect_usage is appropriate. I am ok with usage_info, though I think DG_USAGE_INFO is better.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Missing comment?

Missing comment?

Everything else in this function should be in an else body if given reservoir ID is invalid so we don't try to use an invalid ID.

Everything else in this function should be in an else body if given reservoir ID is invalid so we don't try to use an invalid ID.

Why lower case when others are uppercase?

Why lower case when others are uppercase?